From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 992A042A9A; Mon, 8 May 2023 21:22:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72725410F2; Mon, 8 May 2023 21:22:39 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id 1BD79410ED for ; Mon, 8 May 2023 21:22:38 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-44fc48d993fso1765691e0c.1 for ; Mon, 08 May 2023 12:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683573757; x=1686165757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fdC3xAu14E3MnEd6fcJp1LGwe4KSUI01yZ2UZQJgj5Y=; b=4CZDNrvgcLH3jrPybBDA5WDEDmXlfDWdY7Sqg5XRPmXRN71GzUdWu+Ci9S8bOC3zeK v0NcmX4diRFRwQslDPWNy5LVl9HP+LNzEH7NMLxtJXqk7yvL4mvPLJY5Mb2t6tyf0AV8 7hN/8b2Od+PtG3OwtQZaXvn3T1tnYGNwzaVQONwdgQEekUcVTW1+HXMDYGQ51Q4QpOt+ ptt1OYWbi9EALOxeNw+S4VzjIxcKvA5iOtMbz36icKqICJV+OKfDARPwNnhV3XHcgewe RIm1sBLpOcT/CgE2L5MHpPUL/aUullzYjNBG9TY87BBVTv4JpUpA+PiAm6Bzzl2N8U6h UEGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683573757; x=1686165757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fdC3xAu14E3MnEd6fcJp1LGwe4KSUI01yZ2UZQJgj5Y=; b=VpsUauSwGf2w+e+VTYAwoRroKbuS/V+LA/VqvF3CG5Jh2sY2E0DiT9YTIbgW9dPa5E +jISVVkQ7RKKlKgYYdY6/XkPenORVNBpa7NjfPQiBhs3PU9+DERz/Cv5X/vVgpcWRpoI mroxtgENzPO4pp5Epo91zAwjc9Mnz+DwSoVl9chww++pscb1a1YLf89H/W8EUJfCtpiU E+3P8mm2RHSusJfRkgv6rAmbhZMhTyEjHDUfpmF3tYHP0sQg3lRDJfenJ8c+OoWP/CtN cyNMNKERKsyPZmnRYV/qEMKjSKqVpALfjkN0h+hao5KA6zMnhDXKyiclqjKMbqavfTS9 5vqw== X-Gm-Message-State: AC+VfDzxx9iBR2ZYGX3aklqZwWUaXzJtO671TRo32G5fMEvxVXOTgH32 a6mi14w/5bTKGtM2JBqPa6hWVZwMEUtAxRYWrjdvKw== X-Google-Smtp-Source: ACHHUZ4LgqveZvruOPdEFXSPRN0XTUGhzG1RdcP1ddmOUat/BAhHOumi3Hr2tajJu0nSyUZa1QBEbLztnYQIoGiYhS4= X-Received: by 2002:a1f:41ca:0:b0:44b:2450:e4c8 with SMTP id o193-20020a1f41ca000000b0044b2450e4c8mr3264160vka.9.1683573757242; Mon, 08 May 2023 12:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20230414051454.1245936-1-rushilg@google.com> <20230426213700.2668699-1-rushilg@google.com> <7eb32bfb-7c0e-3073-2e81-eb39f16c26fc@amd.com> In-Reply-To: <7eb32bfb-7c0e-3073-2e81-eb39f16c26fc@amd.com> From: Rushil Gupta Date: Mon, 8 May 2023 12:22:26 -0700 Message-ID: Subject: Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented. To: Ferruh Yigit Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sounds good. I will document the versioning in a separate patch. For now, the DPDK driver with DQO changes is reported as 1.0.0. I think there is some confusion here. The base code is not coming from the linux kernel driver. Linux kernel driver is in a different repository and it has nothing to do with the dpdk driver version. Ideally, we'd want the base code of both drivers to be the same but there are several higher priority projects that are taking precedence. Btw I have addressed your comments: http://patchwork.dpdk.org/project/dpdk/patch/20230508191552.104540-1-rushil= g@google.com/ On Mon, May 8, 2023 at 9:00=E2=80=AFAM Ferruh Yigit = wrote: > > On 5/8/2023 7:23 AM, Rushil Gupta wrote: > >>> +#ifndef _GVE_VERSION_H_ > >>> +#define _GVE_VERSION_H_ > >>> + > >>> +#include > >>> + > >>> +#define GVE_VERSION_PREFIX "DPDK-" > >>> +#define GVE_VERSION_MAJOR 1 > >>> +#define GVE_VERSION_MINOR 0 > >>> +#define GVE_VERSION_SUB 0 > >>> + > >> Is this GVE base version, or DPDK gve version? > >> Previous version information was "GVE-1.3.0", now it is becoming > >> "DPDK-1.0.0", > >> is this breaking the version link with GVE base version and creating a > >> new versioning scheme for DPDK GVE driver? > >> > >> Btw, documentation still has "v1.3.0. GVE base code", should it be > >> updated as well? > >> > > DPDK-1.0.0 is the DPDK driver version. GVE driver versioning only > > applies for linux kernel Gvnic driver. > > Similarly Windows Gvnic driver has different versioning system. > > So creating a new versioning scheme for DPDK driver, I guess that is OK. > Since there is a new version, is it clear how to manage the versioning, > like when to update major version and when to update minor etc? If so > can you please document this? > > And base code is still coming from the Linux kernel driver, I wonder if > a mapping between versions of these two is required. > As mentioned "v1.3.0" is still in the documentation, what happens if > base code updated and some relevant update is required in the dpdk > driver code? How to record/manage this? > Some drivers records the base code version in a readme file in the base > folder, maybe same can be done. >