From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65AE842C12; Fri, 2 Jun 2023 23:44:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AE1240ED8; Fri, 2 Jun 2023 23:44:53 +0200 (CEST) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by mails.dpdk.org (Postfix) with ESMTP id F32E5406B8 for ; Fri, 2 Jun 2023 23:44:50 +0200 (CEST) Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-789d36c830cso524810241.2 for ; Fri, 02 Jun 2023 14:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685742290; x=1688334290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eymIoqtHH/htIdex6Oo86u+Ia9bTsL0VN0KpWwQl8R8=; b=SMmLRE/AcH8MFxLY5RWRZFN+htjuoYojC+2FCgyqqek6gNjnHo48Lq7B6RzGSGhWUf m4hJuf00w8mV5NrS4Geya/Cjltni0Gfkmq+o1Iwh4Bd3amSEWXGvciEtcwBuJnyI1JYR 6cGKaUJEU1Cfstb5uRc647JveA0/aJgmope6KailEJpv8IT8riVpclBKF3qaNS/HN4aX T+1XUCchO/vaMwQeKe9YJelcH/pnMuD4HitKSRaI0RkDKoDa2rMKNEFjmPMVlvIoaiaD +FABJ4nx2+a3zVaMdb1QpT5+/WtpqVdJ0A/GO4T3bhQsad27ewf2jP255jWbj3gP2G/p 9FrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685742290; x=1688334290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eymIoqtHH/htIdex6Oo86u+Ia9bTsL0VN0KpWwQl8R8=; b=alAurgu96yuPsVuOmik3Akh9ZVX7qcR+Rtbba4VkewYb2/QmtyIjj9s1EJs6aYLwol cGFHrxdbMT5Gv49u/lEHjKtZx8TVKuAE5N1thIbLoiu8z//j9xB7I0JbOsf5mHBWRF/s DKqF8LOo6cHmbUATsOIyrq7qpTa0vXfjUOUEypoDR5ZF7CBmx8PWaz0iAkAWC+vs7D7L b8BfHEE+XX0cXuokTDjYaN96hZSvDd4u3seBTRhmo2mBypFAzZL75C71XIVtHVtX3yTP rhmj1vursxQMZua7e6RHlfiyUWglgDY+Vn85uLM6R/ZlLA5KbaLzI4fIoX7bu1DycAAd omCQ== X-Gm-Message-State: AC+VfDyoHkgmqXtsKpGNDr90oYVbLXyNc3+nmn/+fEdePVyCdwzPLiKj JElOdsE88VqvwS7/n/tl5Z+4C94x2/oDzPNVp5N6/Q== X-Google-Smtp-Source: ACHHUZ5J3tOCe7o/HO1cCOsJ341sa+NQ00XRcPL5mus+jp5Obegfb2DGh4LDXWf6fg1LCQEhP5+jZCilVT/iuKO/XRs= X-Received: by 2002:a67:e3d8:0:b0:439:7a8d:3729 with SMTP id k24-20020a67e3d8000000b004397a8d3729mr7278812vsm.17.1685742290100; Fri, 02 Jun 2023 14:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> <6f87b15e-2618-46a8-e43c-ddec57270c6d@amd.com> In-Reply-To: <6f87b15e-2618-46a8-e43c-ddec57270c6d@amd.com> From: Rushil Gupta Date: Fri, 2 Jun 2023 14:44:39 -0700 Message-ID: Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility To: Ferruh Yigit Cc: qi.z.zhang@intel.com, junfeng.guo@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks for the clarification and for squashing the bug into the main commit= . I just tested the net-next branch and it seems to log the right message on the device. On Fri, Jun 2, 2023 at 7:49=E2=80=AFAM Ferruh Yigit = wrote: > > On 6/1/2023 5:32 PM, Rushil Gupta wrote: > > Thanks for the quick response! > > Just for my own knowledge, what Junfeng described is the process to > > fix the bug if a bug is present in the main dpdk repo? > > > > Correct. > > As main dpdk repo doesn't rewrite git history, any bug there needs to be > fixed with an incremental commit, and fix commit should have some > metadata to describe what it is fixing (this is to help LTS maintainers > and developers tracing down a change). > > But sub-trees (like next-net) allowed to rewrite git history, so allowed > to squash/rebase commits when it is more practical to do so as this case= . > But changing directly in the git repo has its problems, like tracing, > justifying source of the change and missing consensus etc. So, even it > is squashed, the patch should be publicly available in the mail list firs= t. > > For developers it is best to send incremental patch as if it will be > merged as incremental commit, but can request a squash if the commit > still not pulled by main repo, or maintainer can prefer to squash the > fix to original commit, to reduce the churn & process overhead. > > > On Thu, Jun 1, 2023 at 3:24=E2=80=AFAM Ferruh Yigit wrote: > >> > >> On 6/1/2023 9:26 AM, Ferruh Yigit wrote: > >>> On 6/1/2023 5:49 AM, Rushil Gupta wrote: > >>>> gVNIC requires physical address to be passed in the adminq command. > >>>> This was initially rightly pointed by ferruh.yigit@. > >>>> Fixed by passing 'driver_info_mem->iova'. > >>>> > >>>> Signed-off-by: Rushil Gupta > >>>> --- > >>>> drivers/net/gve/gve_ethdev.c | 3 ++- > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethd= ev.c > >>>> index 2c1e73d07a..aa75abe102 100644 > >>>> --- a/drivers/net/gve/gve_ethdev.c > >>>> +++ b/drivers/net/gve/gve_ethdev.c > >>>> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv = *priv) > >>>> (char *)driver_info->os_version_str2); > >>>> > >>>> err =3D gve_adminq_verify_driver_compatibility(priv, > >>>> - sizeof(struct gve_driver_info), (dma_addr_t)driver_info= ); > >>>> + sizeof(struct gve_driver_info), > >>>> + (dma_addr_t)driver_info_mem->iova); > >>>> > >>> > >>> Yep, this was my point, let me squashed onto original patch in next-n= et. > >>> > >>> > >> > >> Squashed into relevant commit in next-net, thanks. > >> Can you please verify latest code in next-net? >