From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D740241CB5; Thu, 16 Feb 2023 21:14:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84C3640FDF; Thu, 16 Feb 2023 21:14:43 +0100 (CET) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by mails.dpdk.org (Postfix) with ESMTP id 301A140E25 for ; Thu, 16 Feb 2023 21:14:42 +0100 (CET) Received: by mail-vs1-f53.google.com with SMTP id g9so3174488vst.10 for ; Thu, 16 Feb 2023 12:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2+mM37TOZJhxj/lvbwcHPwRa5N9WCbUNYr+sCLp7D2A=; b=fx2cYrp2Tx8S2Ya+iTwdMPnEZBSJBIMIChtfGNlO1akCAoLg2HPd2G/2U5BDzh1HYc 84SstN6CASNsFvXwuxC5s2dV/6l+Ek8KPYB0LFquGIaehvKpWwNEe5hBdLqT/dfCDXPe a06V2TQpfO8emNm1d1DB6RjW+TsO70htJ5+NsPQlJfhs9XuZkkjZNIbn5mLgVf/jM6DL qqaXocCWKrdg5vCrgo4FYaraP/SsethdxlIvpXo6srdpGAzjc/FDjU+ES1xCJUAjPiPS FPFXWj7vJZ+9hw29jMoBMVQpYPctde2WIiXTp1kokvUUxImoQbJU2tnaVpoColVHy37C KriQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2+mM37TOZJhxj/lvbwcHPwRa5N9WCbUNYr+sCLp7D2A=; b=mvTy7DS6REo/nxw0ps2zJuH02M5oTdwc7KEkqtgLuhUFFpHSxOIGCbKtBTh/leQRHO M8V3sa6cppeh0kdaBqpDDJugoutbLnQThFZZV3ST0wAm00mVjB4chtl6vaILnGQBsds6 FOFRq7zWgnQhor0y/E5hMJdMP0UmioelygvH3tr3JBubB/nDcxxevSLwGkBQZDF+V8SS BEVPTNy85T1X19f+/hCIjzyewBRiYcaPx9LMNXOOGbhit59S0uhrgOJae8NaiPNSz20z XrZ2Rm37Cb8HCBOp/6NnQsdmdqfFG+GQ1bk8VQOYS5lEBb+mxl4D1P2nUtEsZEUXuQ1S xA6Q== X-Gm-Message-State: AO0yUKVIahKnIjtn+3haZi/4+5mFvVm3AN2gdjx33j0/njGQAXXk6KQQ sRZOuDtGXkwmbYuKEKqFUe5BGbUP2ky/ZvdF8UhGrw== X-Google-Smtp-Source: AK7set/1QoehBiyWfx3nZYdbF+o29VSGrHLFOTY2esqk8Ild1x8M7ZgLzBVKAtNMb/NTtobUaEZG71qY7c7VRDoyfjQ= X-Received: by 2002:a05:6102:304a:b0:40f:b3a4:ccbc with SMTP id w10-20020a056102304a00b0040fb3a4ccbcmr1237317vsa.45.1676578481391; Thu, 16 Feb 2023 12:14:41 -0800 (PST) MIME-Version: 1.0 References: <20230216185814.27830-1-levendsayar@gmail.com> In-Reply-To: <20230216185814.27830-1-levendsayar@gmail.com> From: Rushil Gupta Date: Thu, 16 Feb 2023 12:14:30 -0800 Message-ID: Subject: Re: [PATCH 1/2] net/gve: change offloading capability To: Levend Sayar Cc: junfeng.guo@intel.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000d29ca705f4d6d86b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000d29ca705f4d6d86b Content-Type: text/plain; charset="UTF-8" Makes sense. The virtual device only does L4 checksum. Acked-by: Rushil Gupta On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar wrote: > Google Virtual NIC is not doing IPv4 checksummimg. > Removed that capability from PMD. > > Signed-off-by: Levend Sayar > --- > drivers/net/gve/gve_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index 06d1b796c8..fef2458a16 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > dev_info->rx_offload_capa = 0; > dev_info->tx_offload_capa = > RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | > RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > -- > 2.37.1 (Apple Git-137.1) > > --000000000000d29ca705f4d6d86b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Makes sense. The virtual dev= ice only does L4 checksum.

Acked-by: Rushil Gupta <rushilg@google.com>

On Thu, Feb 16, = 2023 at 10:58 AM Levend Sayar <= levendsayar@gmail.com> wrote:
Google Virtual NIC is not doing IPv4 checksummimg.
Removed that capability from PMD.

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
=C2=A0drivers/net/gve/gve_ethdev.c | 1 -
=C2=A01 file changed, 1 deletion(-)

diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 06d1b796c8..fef2458a16 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_et= h_dev_info *dev_info)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 dev_info->rx_offload_capa =3D 0;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 dev_info->tx_offload_capa =3D
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_ETH_TX_OFFLOAD_= MULTI_SEGS=C2=A0 =C2=A0|
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_ETH_TX_OFFLOAD_= IPV4_CKSUM=C2=A0 =C2=A0|
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_ETH_TX_OFFLOAD_= UDP_CKSUM=C2=A0 =C2=A0 |
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_ETH_TX_OFFLOAD_= TCP_CKSUM=C2=A0 =C2=A0 |
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_ETH_TX_OFFLOAD_= SCTP_CKSUM=C2=A0 =C2=A0|
--
2.37.1 (Apple Git-137.1)

--000000000000d29ca705f4d6d86b--