From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6179943AD8; Tue, 20 Feb 2024 04:38:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3913A402B8; Tue, 20 Feb 2024 04:38:30 +0100 (CET) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id A4FB24029B for ; Tue, 20 Feb 2024 04:38:28 +0100 (CET) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-512b42b6697so1851394e87.1 for ; Mon, 19 Feb 2024 19:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708400308; x=1709005108; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7BCP5VoKF2t7YAQHkdRloe+CkoJzRsd/tYtRsAegVaw=; b=cqMnZlF82NRSSqNfxqZ1HGQy39RrwkgWiUX6b2EEFeK+msCj7OAtLqS6xPYi0qKiI1 JlNBNPhmV8Gu5KbbhqMXCD68SMf7YhUzj5tH5WHBYgh7Eof2fB/66AyQVIdNnad7Mm0y BpxtUsaboler5pKfxM0CQmjhExF6VPZ7HDVGXRb8wVhksb275PEu3z9crciIFs+Fh9Tj NhKglKsGouV7pAIXxAhHF9NzZpZw5m4XshRl4FWdPZTB22I8wQptVgXUYboWx4Hn7Jwl WjgGcAHngGGU3JMLNgzCKGDgj/8VP1fo/MeYBkvLYEEojeSmVu594mvixVRpRt7ieihn pwfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708400308; x=1709005108; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7BCP5VoKF2t7YAQHkdRloe+CkoJzRsd/tYtRsAegVaw=; b=hqOOu+vO53SBwLncT1RwQexMGu6Mt9gcYFY0uSqIGLyIX8aCsnaSe3eLjX1TG+UqMV pk6LIT+Y2+oq59qrNeas4q2H9dCYluKOLY65n0wm8hREUu0RwqAT4IToKVTChLV8l64p c3JQwaPr5QqB8ne6vjKCNUd2kwstuSMOCHgcPh5E/IL+dNQC3p7HObvKl9L7AA3P/oZI 4VvIey5kbnta7VptT2lzloHfq5MzG81SD36/D0bzLSulhRnk9WofMhiPsHwmgE6RtaOU rT+7O0quRpybvHS7rUoltGlpIK+EDlUzbS+4jGE85VsJaLMsUUllf8nZCM+SpaJt91iW FnIQ== X-Forwarded-Encrypted: i=1; AJvYcCUNx3O5s589WtMXYhT2dOvHeDrGzlsqymX+MUoUVFBrF/z4ibk/hxwOw36oGZkJXqTri+9vz6yLLGPZeU0= X-Gm-Message-State: AOJu0YyVrHYmEu1/iqkK7apaP0oRYuY5OD6OBKkr9m8T6Sj3Wg5iNYNF AJSjBqTkaexZrz4CRXl79NcfqlgyeOmWKgPiBe6naczNhA/KrGp1WTzbmCW08QUs613MNMErhCo 0CqWWjKIgDjt1nHMOVNUuJ3HCg2vgRUj+TqnU X-Google-Smtp-Source: AGHT+IEhpjJhRcgQ4gHAsLHvo3pbv9XNMLQlyDPVoSFCtg9H1X7asuWB+vPdvNWsz7OMK+AqcMDUS7e1NmeXuNmZXkU= X-Received: by 2002:a05:6512:3b8f:b0:512:ae9b:559 with SMTP id g15-20020a0565123b8f00b00512ae9b0559mr4947315lfv.34.1708400307852; Mon, 19 Feb 2024 19:38:27 -0800 (PST) MIME-Version: 1.0 References: <20240219024436.1010010-1-rushilg@google.com> <20240219092643.4f0a0cac@hermes.local> In-Reply-To: <20240219092643.4f0a0cac@hermes.local> From: Rushil Gupta Date: Tue, 20 Feb 2024 09:08:15 +0530 Message-ID: Subject: Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo. To: Stephen Hemminger Cc: "Guo, Junfeng" , Jeroen de Borst , Joshua Washington , Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Content-Type: multipart/alternative; boundary="0000000000007c671c0611c7f1f6" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000007c671c0611c7f1f6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I agree. This bug has manifested for a while before I fixed it partially in "[PATCH] net/gve: fix dqo bug for chained descriptors" However, for higher queue counts (> 13); we still see this behavior. I'll add a statistic. On Mon, Feb 19, 2024, 10:56=E2=80=AFPM Stephen Hemminger wrote: > On Mon, 19 Feb 2024 02:44:35 +0000 > Rushil Gupta wrote: > > > This was causing failure for testpmd runs (for queues >=3D15) > > presumably due to flooding of logs due to descriptor ring being > > overwritten. > > > > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") > > Cc: stable@dpdk.org > > > > Signed-off-by: Rushil Gupta > > Reviewed-by: Joshua Washington > > Isn't this still an error. What about the descriptor overwritten is there > an mbuf leak? > Maybe a statistic would be better than a message? > --0000000000007c671c0611c7f1f6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I agree.=C2=A0
This bu= g has manifested for a while before I fixed it partially in "[PATCH] n= et/gve: fix dqo bug for chained descriptors"
However,= for higher queue counts (> 13); we still see this behavior. I'll ad= d a statistic.

On Mon, Feb 19, 2024, 10:56=E2=80=AFPM Step= hen Hemminger <stephen@net= workplumber.org> wrote:
On M= on, 19 Feb 2024 02:44:35 +0000
Rushil Gupta <rushilg@google.com> wrote:

> This was causing failure for testpmd runs (for queues >=3D15)
> presumably due to flooding of logs due to descriptor ring being
> overwritten.
>
> Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors"= ;)
> Cc: stable@dpdk.org
>
> Signed-off-by: Rushil Gupta <rushilg@google.com>
> Reviewed-by: Joshua Washington <joshwash@google.com>

Isn't this still an error. What about the descriptor overwritten is the= re an mbuf leak?
Maybe a statistic would be better than a message?
--0000000000007c671c0611c7f1f6--