[PATCH] net/virtio: Implement {rxq,txq}_info_get callbacks

[PATCH] net/virtio: Implement {rxq,txq}_info_get callbacks

[Hengqi Chen]

Currently, there are no ways to retrieve the queue size
set by vhost backend. Implement the {rxq,txq}_info_get
callbacks so that DPDK applications can use the queue
size to setup mempool properly.

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
---
 drivers/net/virtio/virtio_ethdev.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 2d2635b669..b61d251814 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -616,6 +616,28 @@ virtio_dev_priv_dump(struct rte_eth_dev *dev, FILE *f)
 	return 0;
 }
 
+static void
+virtio_rxq_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
+		    struct rte_eth_rxq_info *qinfo)
+{
+	uint16_t vq_idx = 2 * rx_queue_id + VTNET_SQ_RQ_QUEUE_IDX;
+	struct virtio_hw *hw = dev->data->dev_private;
+	struct virtqueue *vq = hw->vqs[vq_idx];
+
+	qinfo->nb_desc = vq->vq_nentries;
+}
+
+static void
+virtio_txq_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
+		    struct rte_eth_txq_info *qinfo)
+{
+	uint16_t vq_idx = 2 * tx_queue_id + VTNET_SQ_TQ_QUEUE_IDX;
+	struct virtio_hw *hw = dev->data->dev_private;
+	struct virtqueue *vq = hw->vqs[vq_idx];
+
+	qinfo->nb_desc = vq->vq_nentries;
+}
+
 /*
  * dev_ops for virtio, bare necessities for basic operation
  */
@@ -630,6 +652,8 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
 	.allmulticast_disable    = virtio_dev_allmulticast_disable,
 	.mtu_set                 = virtio_mtu_set,
 	.dev_infos_get           = virtio_dev_info_get,
+	.rxq_info_get            = virtio_rxq_info_get,
+	.txq_info_get            = virtio_txq_info_get,
 	.stats_get               = virtio_dev_stats_get,
 	.xstats_get              = virtio_dev_xstats_get,
 	.xstats_get_names        = virtio_dev_xstats_get_names,
-- 
2.43.5

Re: [PATCH] net/virtio: Implement {rxq,txq}_info_get callbacks

[Hengqi Chen]

Hi Maxime, Chenbo,

Gentle ping on this. Does this change make sense ?

On Thu, Jun 19, 2025 at 7:55 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>
> Currently, there are no ways to retrieve the queue size
> set by vhost backend. Implement the {rxq,txq}_info_get
> callbacks so that DPDK applications can use the queue
> size to setup mempool properly.
>
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 2d2635b669..b61d251814 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -616,6 +616,28 @@ virtio_dev_priv_dump(struct rte_eth_dev *dev, FILE *f)
>         return 0;
>  }
>
> +static void
> +virtio_rxq_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
> +                   struct rte_eth_rxq_info *qinfo)
> +{
> +       uint16_t vq_idx = 2 * rx_queue_id + VTNET_SQ_RQ_QUEUE_IDX;
> +       struct virtio_hw *hw = dev->data->dev_private;
> +       struct virtqueue *vq = hw->vqs[vq_idx];
> +
> +       qinfo->nb_desc = vq->vq_nentries;
> +}
> +
> +static void
> +virtio_txq_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
> +                   struct rte_eth_txq_info *qinfo)
> +{
> +       uint16_t vq_idx = 2 * tx_queue_id + VTNET_SQ_TQ_QUEUE_IDX;
> +       struct virtio_hw *hw = dev->data->dev_private;
> +       struct virtqueue *vq = hw->vqs[vq_idx];
> +
> +       qinfo->nb_desc = vq->vq_nentries;
> +}
> +
>  /*
>   * dev_ops for virtio, bare necessities for basic operation
>   */
> @@ -630,6 +652,8 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
>         .allmulticast_disable    = virtio_dev_allmulticast_disable,
>         .mtu_set                 = virtio_mtu_set,
>         .dev_infos_get           = virtio_dev_info_get,
> +       .rxq_info_get            = virtio_rxq_info_get,
> +       .txq_info_get            = virtio_txq_info_get,
>         .stats_get               = virtio_dev_stats_get,
>         .xstats_get              = virtio_dev_xstats_get,
>         .xstats_get_names        = virtio_dev_xstats_get_names,
> --
> 2.43.5
>

Re: [PATCH] net/virtio: Implement {rxq,txq}_info_get callbacks

[Maxime Coquelin]

On Thu, Jun 19, 2025 at 1:55 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>
> Currently, there are no ways to retrieve the queue size
> set by vhost backend. Implement the {rxq,txq}_info_get
> callbacks so that DPDK applications can use the queue
> size to setup mempool properly.
>
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [PATCH] net/virtio: Implement {rxq,txq}_info_get callbacks

[Maxime Coquelin]

On Wed, Jul 2, 2025 at 2:17 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>
> Hi Maxime, Chenbo,
>
> Gentle ping on this. Does this change make sense ?
>
> On Thu, Jun 19, 2025 at 7:55 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
> >
> > Currently, there are no ways to retrieve the queue size
> > set by vhost backend. Implement the {rxq,txq}_info_get
> > callbacks so that DPDK applications can use the queue
> > size to setup mempool properly.
> >
> > Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
> > ---
> >  drivers/net/virtio/virtio_ethdev.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
Applied to next-virtio/for-next-net.

Thanks,
Maxime