From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C415DA0C56; Mon, 23 Aug 2021 08:38:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1EAF40143; Mon, 23 Aug 2021 08:38:57 +0200 (CEST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by mails.dpdk.org (Postfix) with ESMTP id AA14E4003E for ; Mon, 23 Aug 2021 08:38:56 +0200 (CEST) Received: by mail-yb1-f170.google.com with SMTP id z18so32082564ybg.8 for ; Sun, 22 Aug 2021 23:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YWHH4ky1D4rgd0yjI367YngvwRev20Mgxk9Yz7qFHpo=; b=WHHRzWZ4y0T+iZ6lR2VwT1skmKSulJE6M4tPN4gyArQJNT3Qsygup3J3NERFNtyRmA l1dNyHYUJD/l1oyHhQ46dTUg82qRou0MfKHelIIssmjMh6a4wUil6RkkYcbG5200B0ee paMJ77+cZCI0SoF4OzlgIdZ5OMnqjn6SGXvDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YWHH4ky1D4rgd0yjI367YngvwRev20Mgxk9Yz7qFHpo=; b=jwfSwrw7T/85vZJTxqllRCp/hyxQ4bxm+9NbvrIaJWulHLwaPaT9N1ry72Z6tozjoT ewQJOLyCps0qfQKn3ohXpxnxofBzHvil7sY7OfScgoTBw2VOm/bVZocY4sL2V47xJKFb toTY1lRi30dQKPiqtzS9grCT3u2QOcr2rtsZn8wCOe4XulzqKivKF4MTkAh+6/5KNnlv 3J7tsvsCMOzlbCWLc3ZSMDV4xv7G2xa84MOu29fnY4pScZ/VhTC63UvYafSq0bGyU9s+ Ca95aYzA4kJRpiItl9mWchBX5fzz9ccKCsJSa2ry4VD1azUasecFid4BTBBaXc5nHbkl h76g== X-Gm-Message-State: AOAM53363JMaAjxwH6CNvdLtP11f036ZYwKXzBd7EJB/N2Sm7d3fmprK pbdVsWNpLErH6biBNeSlZvbBDDdfu0290PJglJ9ECg== X-Google-Smtp-Source: ABdhPJzRE5cDFdf8xdMPvWNaSen5hhwy+5rmnnLVw5LGvl/t1GMEjqgMgRKM1pnFItoBXTlA7GuubAGwARVsQxYSeqA= X-Received: by 2002:a5b:50b:: with SMTP id o11mr15844923ybp.466.1629700735906; Sun, 22 Aug 2021 23:38:55 -0700 (PDT) MIME-Version: 1.0 References: <20210810060731.30127-1-somnath.kotur@broadcom.com> <64bb2ddc-f160-ee25-51c4-917141898b0c@intel.com> In-Reply-To: <64bb2ddc-f160-ee25-51c4-917141898b0c@intel.com> From: Somnath Kotur Date: Mon, 23 Aug 2021 12:08:44 +0530 Message-ID: To: Ferruh Yigit Cc: dev , dpdk stable , Kalesh AP , Ajit Khaparde Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000079fa2b05ca3445f6" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to reset Rx next consumer index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000079fa2b05ca3445f6 Content-Type: text/plain; charset="UTF-8" Thank you Ferruh, have sent V2 with updated commit log, please see if it sounds good now? -Som On Fri, Aug 20, 2021 at 6:17 PM Ferruh Yigit wrote: > On 8/10/2021 7:07 AM, Somnath Kotur wrote: > > In bnxt_init_one_rx_ring(), reset this variable internal to the driver > > ring to 0, so that there is no mismatch with actual value in HW on > > traffic resumption. > > > > Hi Somnath, > > What is the impact of the patch, what are you fixing? > > If the 'rx_next_cons' (next consumer index) is not matching with HW value, > what > happens, does the Rx fails completely and unrecoverable? Or does miss one > or > more packet? > > And when/how this happens, since driver is not new I assume this doesn't > happen > in first ring init. Does this happen after uninit and init again? > Providing this > information helps clarifying scope of the fix. > > Can you please send a new version with updated commit log? > > Thanks, > ferruh > > > Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") > > Cc: stable@dpdk.org > > > > Signed-off-by: Somnath Kotur > > Reviewed-by: Kalesh AP > > Reviewed-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_rxr.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > > index aea71703d1..73fbdd17d1 100644 > > --- a/drivers/net/bnxt/bnxt_rxr.c > > +++ b/drivers/net/bnxt/bnxt_rxr.c > > @@ -1379,6 +1379,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue > *rxq) > > } > > PMD_DRV_LOG(DEBUG, "TPA alloc Done!\n"); > > > > + /* Explicitly reset this driver internal tracker on a ring init */ > > + rxr->rx_next_cons = 0; > > + > > return 0; > > } > > > > > > --00000000000079fa2b05ca3445f6--