From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B6DA04DB; Fri, 16 Oct 2020 11:06:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 160AD1DD88; Fri, 16 Oct 2020 11:06:52 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 9F1B21DCF7 for ; Fri, 16 Oct 2020 11:06:49 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id g29so1058055pgl.2 for ; Fri, 16 Oct 2020 02:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XClHghNs/A3GPhr3cD7IcpsVoM5xytoJlar5Eegebgs=; b=WXXyN/wALQ8NzTfN6jsh1TNYagBzMDjd5inRBAWBJOzk5Y5ds90hJ/08YHyANgPy7d H67q1S58mFyBEIyCNPWoq5maOwgmPm/Tq+uqN2bRaMzJAmXaAHuLTxnvzIeye8sYVQfh eU2b3c5r6xGoMbsAhNpsv+vs95/YacRZqhLK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XClHghNs/A3GPhr3cD7IcpsVoM5xytoJlar5Eegebgs=; b=MnzjT0N6u1XaX7HAABItj4IeXJXHMx+xcC3l3bPKYHRcwOYnHEt2vWGV4ROChqHOI2 wG9j5c232RDdsb/MNFRLvabf1kThu7BUEejSXH5AwP+b5eLKdnDQFFSLWygJaJrsnrsp DIhb9hBAY0l3r78OHz02o2jU52RcDL+yxBEUEFt6Y8jHWyVaXCnNiSfAWWiD0oxkLcTi 8b8uYAYZH2z2EvJJKGkBJ9Op4/V0F2bBJ9q+A7GmQfj8LAuOIVfIOWu7EePIds+u4wQV b1HNb/FR2dlOIOrUqJcMzsGa9VVD4qZAsO6hm5npDOConDmyfHeXpq5ux7cdvxmKxS/5 4mwg== X-Gm-Message-State: AOAM533n78YBHqS6is6c2nSDBC/KKTkF3xBTrIP2b3/219hcolKTl+x9 J+2VLqTiwxVlZzUrOrUNoiAA2CwcRjsCf8/8uiaIyA== X-Google-Smtp-Source: ABdhPJwriCnhbvrANmta1KfRuwhkSP9cbU8YkEulav3o3gUsXZAzmaI2qldsm3LSZlB42z6IXxBp78UVhAFmxaiJWsY= X-Received: by 2002:a62:5b85:0:b029:142:2501:34e1 with SMTP id p127-20020a625b850000b0290142250134e1mr2733658pfb.58.1602839207593; Fri, 16 Oct 2020 02:06:47 -0700 (PDT) MIME-Version: 1.0 References: <20200807155859.63888-1-ciara.power@intel.com> <20201016081320.186775-1-ciara.power@intel.com> <20201016081320.186775-6-ciara.power@intel.com> In-Reply-To: <20201016081320.186775-6-ciara.power@intel.com> From: Somnath Kotur Date: Fri, 16 Oct 2020 14:36:35 +0530 Message-ID: To: Ciara Power Cc: dev , viktorin@rehivetech.com, ruifeng.wang@arm.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, Bruce Richardson , "Ananyev, Konstantin" , David Marchand , Ajit Khaparde Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v8 05/18] net/bnxt: add checks for max SIMD bitwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 1:43 PM Ciara Power wrote: > > When choosing a vector path to take, an extra condition must be > satisfied to ensure the max SIMD bitwidth allows for the CPU enabled > path. > > Cc: Ajit Khaparde > Cc: Somnath Kotur > > Signed-off-by: Ciara Power > > --- > v4: Updated enum name. > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 8b63134c39..07d1a1a6ab 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1169,7 +1169,8 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev) > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > DEV_RX_OFFLOAD_RSS_HASH | > DEV_RX_OFFLOAD_VLAN_FILTER)) && > - !BNXT_TRUFLOW_EN(bp) && BNXT_NUM_ASYNC_CPR(bp)) { > + !BNXT_TRUFLOW_EN(bp) && BNXT_NUM_ASYNC_CPR(bp) && > + rte_get_max_simd_bitwidth() >= RTE_SIMD_128) { > PMD_DRV_LOG(INFO, "Using vector mode receive for port %d\n", > eth_dev->data->port_id); > bp->flags |= BNXT_FLAG_RX_VECTOR_PKT_MODE; > @@ -1202,7 +1203,8 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev) > */ > if (!eth_dev->data->scattered_rx && > !(offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) && > - !BNXT_TRUFLOW_EN(bp)) { > + !BNXT_TRUFLOW_EN(bp) && > + rte_get_max_simd_bitwidth() >= RTE_SIMD_128) { > PMD_DRV_LOG(INFO, "Using vector mode transmit for port %d\n", > eth_dev->data->port_id); > return bnxt_xmit_pkts_vec; > -- > 2.22.0 > Acked-by Somnath kotur