From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29669A0C45; Wed, 6 Oct 2021 08:55:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E267B41103; Wed, 6 Oct 2021 08:55:39 +0200 (CEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id 1AFC0410FA for ; Wed, 6 Oct 2021 08:55:39 +0200 (CEST) Received: by mail-yb1-f172.google.com with SMTP id a7so3086259yba.6 for ; Tue, 05 Oct 2021 23:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4o3c/O85oVIZcavOHvlQBx1YjCVR3ACeP3+UQl3j5Ks=; b=D3YjVIuYf7SuR8UibmNO01fo/2FVkMhyB37tX89odaYv/gpmqI4xzCYluUfBIGxXHX hcKcFyFP5Mt4YV8Rq89Jn3xY4ZKx7AAHv0cHYUCFJ2soYE1jX8M7Rh6fO+DLtOzIKQkV C86CtaV8bYsjknO4hhJnn0yjwNkNuR7xY2eSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4o3c/O85oVIZcavOHvlQBx1YjCVR3ACeP3+UQl3j5Ks=; b=E8wo0gOxymHDjWFM2NmqisOPZmBxsY8p0GZkKqS8TbFRekHzmoCEug1e7sOMwvvONQ US7rC/vTRkeGkxjTDlOy9kdyc29HAp/sNvTjkNOIm1Dq7SJg0ktNxpPFFzeMZaNhdNUK NqfwzKtnYj84BDTQkhPRtvwRXxUetZepyG6eKzYZjiq1/XwX+6IiiccsIibzIK5kF+Le The/dGVXg1DKBE3vtsbjzP+u9YOa+/pX/uEiTzMjNQPPsmj0wuH+Yi7rrwrmZfpm41rB 3OO+l4lWMq5XF4S+VNzYtrk0E0uN/4uP/g1+/Iw+HF4gnE6iZPaIOilshsH0ZBVON2sE GTeA== X-Gm-Message-State: AOAM532Bpejm+n5epSW+deKsWPQwJ2paaHxc6RowreEl9b2iUWKuG1P+ 3fX18vUQlpvbmhlkXW2XOmCf9UgvdXPOy88Kq+NAtw== X-Google-Smtp-Source: ABdhPJxn7CUXcbze5IbvbPPkpqyACcQQiN5r0vIs5CFqA1eYnAhiEDjtRua6Y845q1weG+pxDqiZxbCMceM+SUwPoIQ= X-Received: by 2002:a05:6902:100b:: with SMTP id w11mr354339ybt.19.1633503338427; Tue, 05 Oct 2021 23:55:38 -0700 (PDT) MIME-Version: 1.0 References: <20211005005216.2427489-1-dkozlyuk@nvidia.com> <20211005005216.2427489-2-dkozlyuk@nvidia.com> In-Reply-To: From: Somnath Kotur Date: Wed, 6 Oct 2021 12:25:27 +0530 Message-ID: To: Ori Kam Cc: Dmitry Kozlyuk , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003e5d9b05cda9a207" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add capability to keep flow rules on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000003e5d9b05cda9a207 Content-Type: text/plain; charset="UTF-8" On Wed, Oct 6, 2021 at 11:45 AM Ori Kam wrote: > > Hi Dmitry, > > > -----Original Message----- > > From: Dmitry Kozlyuk > > Sent: Tuesday, October 5, 2021 3:52 AM > > Subject: [PATCH 1/5] ethdev: add capability to keep flow rules on restart > > > > From: Dmitry Kozlyuk > > > > Currently, it is not specified what happens to the flow rules when the device is > > stopped, possibly reconfigured, then started. > > If flow rules were kept, it could be convenient for application developers, > > because they wouldn't need to save and restore them. > > However, due to the number of flows and possible creation rate it is > > impractical to save all flow rules in DPDK layer. This means that flow rules > > persistence really depends on whether PMD and HW can implement it > > efficiently. It is proposed for PMDs to advertise this capability if supported > > using a new flag. > > > > If the device is being reconfigured in a way that is incompatible with existing > > flow rules, PMD is required to report an error. > > This is mandatory, because flow API does not supply users with capabilities, so > > this is the only way for a user to learn that configuration is invalid. For > > example, if queue count changes and the action of a flow rule specifies queues > > that are going away, the user must update or remove the flow rule before > > removing the queues. > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > Acked-by: Ori Kam > Thanks, > Ori Acked-by: Somnath Kotur --0000000000003e5d9b05cda9a207--