From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FC8443BA4; Fri, 1 Mar 2024 03:54:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A720402CD; Fri, 1 Mar 2024 03:54:42 +0100 (CET) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by mails.dpdk.org (Postfix) with ESMTP id D20114025C for ; Fri, 1 Mar 2024 03:54:40 +0100 (CET) Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-7d5c2502ea2so778309241.1 for ; Thu, 29 Feb 2024 18:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1709261680; x=1709866480; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AtMxs/N7DtKuSfPp8Aq1I5rP9V3u5zJf4lt1xyWZqnU=; b=DxbE4YPD3/hor6a+f4YYEReqm2qXRPjaXSXieq6yAUtaIBU8kdO9hlPPoeCszOLI3a h57EiG42HLrgRJZ5+W104YWFjnFDGsTfoozTTmQ5INzrPFt/c8cdIcT9VHzGsdSrBMCx Ez1mvzcyc1Ocw5sJ+ov+8ce4ngUd+fZWqGu+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709261680; x=1709866480; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AtMxs/N7DtKuSfPp8Aq1I5rP9V3u5zJf4lt1xyWZqnU=; b=H8zeqvdkamo9V4Pi3Y8NMNH7m4zQt5KAITTN6OJ6ojksx0/JQJuqxqAU+gyNDh5a6L rouecVmOuNS8YiDWPgIJZwzR5agXAu14BLOkqlvkdgWmjkhlPMvHUWBN3SdKlk7+Qzim cjQPQiBloJoS7zxZJrVSFXNBYiO1QgVIcVS/UujV3FJzDCe82JwKZjr0AW3yhcg1/iXh 4nd+MOiWZBY9fXh8dAJRRA1383TBEoP2PHXpj+0msf2MNl24NiFOaMguQE8iQzs35vWS MSdzLeF1n23SejUocohIFD6UrI3kSZJOU1Rv1r1NwnrD6roL0W0d/RQQMs/7QzDDZlhL K0lA== X-Gm-Message-State: AOJu0Ywh9cEAs28IRxXQ5qlNfyzWCH2yLHEWb4VweEMVFvFHNz0GPU9x XfyMBbIvEib/sotmBClLKqc88l4XAWq54SDvTf8T8X8iwaz9MDuziJJPmf7EGKdt2fnmVeUSFCJ jzoq9W986hOUEsDFghVd1LVI3OCf2GX4OIGQD X-Google-Smtp-Source: AGHT+IHsDzFxf8/Scc9jEIVJ7zf5zVWKsJftk1/huHVfUFIsCA8FRsGcjheITpZdIP2Nush3Jt1OIeo6bg4K0PpK1fw= X-Received: by 2002:a05:6102:549e:b0:472:6e7e:fd68 with SMTP id bk30-20020a056102549e00b004726e7efd68mr241671vsb.35.1709261680094; Thu, 29 Feb 2024 18:54:40 -0800 (PST) MIME-Version: 1.0 References: <20240229225936.483472-1-stephen@networkplumber.org> <20240229225936.483472-56-stephen@networkplumber.org> In-Reply-To: <20240229225936.483472-56-stephen@networkplumber.org> From: Somnath Kotur Date: Fri, 1 Mar 2024 08:24:27 +0530 Message-ID: Subject: Re: [PATCH 55/71] net/bnxt: replace use of fixed size rte_memcpy To: Stephen Hemminger Cc: dev@dpdk.org, Ajit Khaparde Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000004956380612907fe0" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000004956380612907fe0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 1, 2024 at 4:30=E2=80=AFAM Stephen Hemminger wrote: > > Automatically generated by devtools/cocci/rte_memcpy.cocci > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index f25bc6ff78c7..6466aa394af1 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -233,8 +233,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_fl= ow_attr *attr, > "DMAC is invalid!\n")= ; > return -rte_errno; > } > - rte_memcpy(filter->dst_macaddr, > - ð_spec->hdr.dst_addr, RTE_E= THER_ADDR_LEN); > + memcpy(filter->dst_macaddr, > + ð_spec->hdr.dst_addr, > + RTE_ETHER_ADDR_LEN); > en |=3D use_ntuple ? > NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MA= CADDR : > EM_FLOW_ALLOC_INPUT_EN_DST_MACADD= R; > @@ -257,8 +258,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_fl= ow_attr *attr, > "SMAC is invalid!\n")= ; > return -rte_errno; > } > - rte_memcpy(filter->src_macaddr, > - ð_spec->hdr.src_addr, RTE_E= THER_ADDR_LEN); > + memcpy(filter->src_macaddr, > + ð_spec->hdr.src_addr, > + RTE_ETHER_ADDR_LEN); > en |=3D use_ntuple ? > NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MA= CADDR : > EM_FLOW_ALLOC_INPUT_EN_SRC_MACADD= R; > @@ -423,23 +425,23 @@ bnxt_validate_and_parse_flow_type(const struct rte_= flow_attr *attr, > en |=3D EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR= | > EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR= ; > > - rte_memcpy(filter->src_ipaddr, > - ipv6_spec->hdr.src_addr, 16); > - rte_memcpy(filter->dst_ipaddr, > - ipv6_spec->hdr.dst_addr, 16); > + memcpy(filter->src_ipaddr, ipv6_spec->hdr.src_add= r, > + 16); > + memcpy(filter->dst_ipaddr, ipv6_spec->hdr.dst_add= r, > + 16); > > if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_add= r, > 16)) { > - rte_memcpy(filter->src_ipaddr_mask, > - ipv6_mask->hdr.src_addr, 16); > + memcpy(filter->src_ipaddr_mask, > + ipv6_mask->hdr.src_addr, 16); > en |=3D !use_ntuple ? 0 : > NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR= _MASK; > } > > if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_add= r, > 16)) { > - rte_memcpy(filter->dst_ipaddr_mask, > - ipv6_mask->hdr.dst_addr, 16); > + memcpy(filter->dst_ipaddr_mask, > + ipv6_mask->hdr.dst_addr, 16); > en |=3D !use_ntuple ? 0 : > NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADD= R_MASK; > } > @@ -591,8 +593,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_fl= ow_attr *attr, > return -rte_errno; > } > > - rte_memcpy(((uint8_t *)&tenant_id_be + 1)= , > - vxlan_spec->hdr.vni, 3); > + memcpy(((uint8_t *)&tenant_id_be + 1), > + vxlan_spec->hdr.vni, 3); > filter->vni =3D > rte_be_to_cpu_32(tenant_id_be); > filter->tunnel_type =3D > @@ -645,8 +647,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_fl= ow_attr *attr, > "Invalid TNI mask"); > return -rte_errno; > } > - rte_memcpy(((uint8_t *)&tenant_id_be + 1)= , > - nvgre_spec->tni, 3); > + memcpy(((uint8_t *)&tenant_id_be + 1), > + nvgre_spec->tni, 3); > filter->vni =3D > rte_be_to_cpu_32(tenant_id_be); > filter->tunnel_type =3D > -- > 2.43.0 > Acked-by: Somnath Kotur --0000000000004956380612907fe0 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDHrACvo11BjSxMYbtzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDJaFw0yNTA5MTAwODE4NDJaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVNvbW5hdGggS290dXIxKTAnBgkqhkiG9w0B CQEWGnNvbW5hdGgua290dXJAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAwSM6HryOBKGRppHga4G18QnbgnWFlW7A7HePfwcVN3QOMgkXq0EfqT2hd3VAX9Dgoi2U JeG28tGwAJpNxAD+aAlL0MVG7D4IcsTW9MrBzUGFMBpeUqG+81YWwUNqxL47kkNHZU5ecEbaUto9 ochP8uGU16ud4wv60eNK59ZvoBDzhc5Po2bEQxrJ5c8V5JHX1K2czTnR6IH6aPmycffF/qHXfWHN nSGLsSobByQoGh1GyLfFTXI7QOGn/6qvrJ7x9Oem5V7miUTD0wGAIozD7MCVoluf5Psa4Q2a5AFV gROLty059Ex4oK55Op/0e3Aa/a8hZD/tPBT3WE70owdiCwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpzb21uYXRoLmtvdHVyQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUabMpSsFcjDNUWMvGf76o yB7jBJUwDQYJKoZIhvcNAQELBQADggEBAJBDQpQ1TqY57vpQbwtXYP0N01q8J3tfNA/K2vOiNOpv IufqZ5WKdKEtmT21nujCeuaCQ6SmpWqCUJVkLd+u/sHR62vCo8j2fb1pTkA7jeuCAuT9YMPRE86M sUphsGDq2ylriQ7y5kvl728hZ0Oakm3xUCnZ9DYS/32sFGSZyrCGZipTBnjK4n5uLQ0yekSLACiD R0zi4nzkbhwXqDbDaB+Duk52ec/Vj4xuc2uWu9rTmJNVjdk0qu9vh48xcd/BzrlmwY0crGTijAC/ r4x2/y9OfG0FyVmakU0qwDnZX982aa66tXnKNgae2k20WCDVMM5FPTrbMsQyz6Hrv3bg6qgxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgx6wAr6NdQY0sTG G7cwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEILdYOO6i3IQHfTPlylJEwBvAR3TT xgO4rvdLHUBtqW3zMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTI0 MDMwMTAyNTQ0MFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQCJ7OMdddY+2eMMLwypfWO7uMZSBb5yco0GHcwiaPiUbSla DwF5dssTNl/9APNgkuowxCDzkVyJwF0cjVZSiakMjSJlx7AwLoPzkXZUaxjyXgaGgCerRgG09/u7 ITMqCFBkSt4wELObPv7CY8TOYhXDYbrOH9vWGASye7qYimA8lNg9n+1r9AhBheU8+nBoxoR8dsUy F9Wmb6qUtDhejtbawP8FxEMXKdkos2ubSXWCLt06PYfrmPCEGS4k3cMypJM9omzQpsARKkQcA/BS Rkqr3pc+chY6uJKmNxrNXiq1peDPKTdV9AOfGZARI9uu9CuaTtZo99GLiAk85YI5hXhp --0000000000004956380612907fe0--