From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id EF5FA5F17 for ; Fri, 23 Mar 2018 04:35:04 +0100 (CET) Received: by mail-io0-f173.google.com with SMTP id y128so13514824iod.4 for ; Thu, 22 Mar 2018 20:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oP78xxwm0mBKFgNQe76VtPdfTMLeewJJKimVyMWORJ0=; b=dUZ3zIlZs7KjMv0G41Rhs+G20aU5/MvZ9AJ4HkCAlSCkBz+syRfIjKvySpj363XSgg NLSMsZb/yfaKQmiV8AZSWSUXLxudV5wN1z75ZQdREEKPc7eRdBnyemHuOaHdj7RWhM7A 0IpuI9GpdK/ogrxyI4YPAdICckrO5wb+Epd9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oP78xxwm0mBKFgNQe76VtPdfTMLeewJJKimVyMWORJ0=; b=CaRGlHKsGrNUd+loKhogamu+1zdLrRgrYql/JjKLQEoLeosFL0aqcVY4t5L1M05TLt 3BKoYhBDm4764qLVrSseFjzFKbQwiyjj/YNqX4RaHBVy5X0sXUtQPETw3vfdGcy7/kFB l6UiwQB74oAt5LFg10ev9KKb5QlGRVb0coY2ELjdqEk3Y6uFHA5skKpbBAZz3Y5dakhc qBVVx1TnYBg1q60EmMMbdiRnNh27Sl/K/ueVG3ugYXjS3kJQC9c0XU85TY8UU64OPrTR LRp/FMJepCPWNcNbHrJBFQ2jbgc7LLOiDf3mhFddUAJ93jE2nmZdcNizRkm2YSin6zaL Xr8Q== X-Gm-Message-State: AElRT7FPYWXPYsTd87nCN88pk5sCAmX496W2F0tN0q1TzNE3zrra8pQA XkEUHdPGf+tnmMuHT96zT5EbN4D5IH8DZPH7lQ9Utg== X-Google-Smtp-Source: AG47ELuW/hOD3Uvyy9IG276zz/J0ey2dyVHxKBEeXYw1Sp09v9G6n1qX+WmzEXlTkh13/2qKXLKJp4aN2p7oZ/Pa1LM= X-Received: by 10.107.7.68 with SMTP id 65mr28798176ioh.216.1521776103831; Thu, 22 Mar 2018 20:35:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.168.163 with HTTP; Thu, 22 Mar 2018 20:34:43 -0700 (PDT) In-Reply-To: <8712ecbf-57d5-121f-2171-2a573a49871f@intel.com> References: <20180222025822.18421-1-somnath.kotur@broadcom.com> <8712ecbf-57d5-121f-2171-2a573a49871f@intel.com> From: Somnath Kotur Date: Fri, 23 Mar 2018 09:04:43 +0530 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 03:35:05 -0000 Hi Ferruh, On Fri, Mar 23, 2018 at 12:16 AM, Ferruh Yigit wrote: > On 2/22/2018 2:58 AM, Somnath Kotur wrote: > > Please start with lowercase after "net/bnxt: fix" > > > When user reissues same flow director cmd with a different queue > > update the existing filter to redirect flow to the new desired > > queue as destination just like the other filters like 5 tuple and > > generic flow. > > Can you please add a fixes line? > Actually, I'm not sure if this qualifies as a 'fix for a regression', it prescribes a new behavior for this scenario (of same flow-director cmd , different queue) we never handled this before at all , Do you still think it needs it ? > > Also ./devtools/check-git-log.sh complains about long title, what about > something like (just a sample): > "net/bnxt: fix flow director with same cmd different queue" > > > > > Signed-off-by: Somnath Kotur > > <...> > > > @@ -2436,11 +2440,32 @@ bnxt_fdir_filter(struct rte_eth_dev *dev, > > goto free_filter; > > filter->filter_type = HWRM_CFA_NTUPLE_FILTER; > > > > - match = bnxt_match_fdir(bp, filter); > > + if (fdir->action.behavior == RTE_ETH_FDIR_REJECT) > > + vnic = STAILQ_FIRST(&bp->ff_pool[0]); > > + else > > + vnic = > > + STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]); > > Is this done because of column limit? If so I would prefer a few extra > chars > instead of this assignment. > Yes, please thank you , it was going over by 1 character :) > > btw, not related to this patch, but in this switch there are a few "/* > FALLTHROUGH */" comments but they may not be required (or wrong), can you > please > check. > > Sure , will do. > <...> > Thanks Som