From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8271A00C3; Tue, 2 Aug 2022 05:51:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9174A40141; Tue, 2 Aug 2022 05:51:21 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 07ACD400D7 for ; Tue, 2 Aug 2022 05:51:21 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id i71so5775229pge.9 for ; Mon, 01 Aug 2022 20:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=oOYGGOVZwAPx9BfC/rLzbhKfCApCZwBNsuLYRYvDLK0=; b=H7YIcveAWf/OwFHlIvDvtitNRTznUTulT4ZyomA13MMLHYYgRZ90jZR1WK7u7Wcs+p lQJl0P5QrXxoxkxiNVj5hG+NqetLjnQaB49RwkFC7YYAg8+iBVXl2JdHESO1yAFAVCBb QC64i9z8LCzXccjzY9YPf2grpkXoNRogWJx7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=oOYGGOVZwAPx9BfC/rLzbhKfCApCZwBNsuLYRYvDLK0=; b=JccqhLgNt48XUCZOxG4kop67b7bs3Wzj2khGYIry/iQJiFE3p8+jFsN2T2yDSHGo5/ KhdOYKhCoj5DoiJBZjt7qp8gGJFweVveZsVkL45iB5osQXfVfNJFJ/sLzmt6FMJTbJ3N 0sZ5vCXxkId6vCklcAaFv9qC1fniurNtMxKk4lidcaexSJCM580uTacha/NSfrtxr2nz AurWkp/3X3xjkyCE4AFcJ8JJvNNVuE467TjAANGmcMC0OR2Lxepb1uy3yhRUOp5d1X8S NMl0gbItByBe4hTj+1bulYlwwSAF3rmhJp4yg3xztPu4rY38nS0Bv7fvt+wT7YAPcLTi qc0Q== X-Gm-Message-State: AJIora/lw7nThmpXdRB1a9jlC+jxctbwtVlrXnThvRSPRxpcSX4XxIZQ tP9i4W90s5kkscnx+nhsT3Wn9uadMxdG9B6076DlRQ== X-Google-Smtp-Source: AGRyM1sD69S42ddxJM8mYYqu/XI3ragvPoCrbR33I2W8yKcNtJvl2YBLMvPtXJ6ow4CA0HoHklJK3T7ntlNi15bUAZI= X-Received: by 2002:a62:5441:0:b0:52b:ab93:1f05 with SMTP id i62-20020a625441000000b0052bab931f05mr19091889pfb.30.1659412280137; Mon, 01 Aug 2022 20:51:20 -0700 (PDT) MIME-Version: 1.0 References: <1659412069-21091-1-git-send-email-maoyingming@baidu.com> In-Reply-To: <1659412069-21091-1-git-send-email-maoyingming@baidu.com> From: Somnath Kotur Date: Tue, 2 Aug 2022 09:21:08 +0530 Message-ID: Subject: Re: [PATCHv2] net/bnxt: fix null pointer dereference in bnxt_hwrm_port_led_cfg() To: Mao YingMing Cc: dev@dpdk.org, Ajit Khaparde , Kalesh AP , Thomas Monjalon Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000083a11005e53a07dd" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000083a11005e53a07dd Content-Type: text/plain; charset="UTF-8" On Tue, Aug 2, 2022 at 9:17 AM Mao YingMing wrote: > > For VFs, bp->leds is uninitialized, check bp->leds is > not null before use bp->leds->num_leds. Sorry for missing this the first time around, Rephrase it to say 'before checking for bp->leds->num_leds' > segfault backtrace in trex program when use VF: > 11: bnxt_hwrm_port_led_cfg (bp=0x23ffb2140, led_on=true) > 10: bnxt_dev_led_on_op (dev=0x22d7780 ) > 9: rte_eth_led_on (port_id=0) > 8: DpdkTRexPortAttr::set_led (this=0x23b6ce0, on=true) > 7: DpdkTRexPortAttr::DpdkTRexPortAttr > 6: CTRexExtendedDriverBnxt::create_port_attr > 5: CPhyEthIF::Create > 4: CGlobalTRex::device_start > 3: CGlobalTRex::Create > 2: main_test > 1: main > > Fixes: d4d5a04 ("net/bnxt: fix unnecessary memory allocation") > Cc: stable@dpdk.org > > Signed-off-by: Mao YingMing > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 9c52573..51e1e2d 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -4535,7 +4535,7 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on) > uint16_t duration = 0; > int rc, i; > > - if (!bp->leds->num_leds || BNXT_VF(bp)) > + if (BNXT_VF(bp) || !bp->leds || !bp->leds->num_leds) > return -EOPNOTSUPP; > > HWRM_PREP(&req, HWRM_PORT_LED_CFG, BNXT_USE_CHIMP_MB); > -- > 1.8.3.1 > --00000000000083a11005e53a07dd Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDHy8qMPbvB2sZaz/lDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjlaFw0yMjA5MjIxNDUxNTJaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVNvbW5hdGggS290dXIxKTAnBgkqhkiG9w0B CQEWGnNvbW5hdGgua290dXJAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAvR3NlcTd6C7U0Rgv1OW1HMeAMod9IPlwor3Bay5Qa+lg6PoHMHl309AhI0UAHiMw2kzx HeZvRVyMb/k7BLrVfIqekcsbhiV2Q04BbXQe/UiQzKD7UwnVnqYoQszn3j42uYCHRC7sfSCArtDR e0z3k6RZT2P3y9nhpqymdqKxsr61WRLBzITcuv4XAcodRHUiPVURi7Ga6w4Fmwg5JVWGA9RMaSkl oZk87hf9I57ggDu+hSLe1hbPBgKly5q/r8XBHZkKDswEMqn7nOHCwm20q2jGMRVmR8qL4wlTZEVv eKbQAkg/svNjuuAiD+ICbTd74UclYUh//bFNGT8h9SFHWQIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpzb21uYXRoLmtvdHVyQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQU+mf+1dq8iI61FoBk3jqw Jj8z7zMwDQYJKoZIhvcNAQELBQADggEBALjOl6MPEwswIci1hfGUMPy5zkNp7cgxhGE+xKR2wYff RV3S826165wXomj0NkrWhJg3//CyuBx5RTfSuvac280tP+LoTYR6j0oMw1CZbAAnkmUJHToMObs5 7aK1M5vdbNpk5MbMiPGfHqMckjR4+PpgwtiiVke5HSSf0yDjRGZN9pC+VXntZByC8bAakbVbdtEI RgXYbJHgFDMUrMDgm3LGPeZYcaQvasShlOOfME1IGePqI90RMcbhyT4kbetYwTgJGb9OyedCC9TU rBFfmphPrlyu+GZ8t7XjYVacR9/jVOL038uTcYZBbU6XvjAIluKfs69qQgVO2rMQcGDYY/gxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgx8vKjD27wdrGWs /5QwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIEp0uiZfIVhMWq3rxkHOKITBYfsN 6jFseov7HJTDmytWMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIy MDgwMjAzNTEyMFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQATvhVwJs6S/G1V1OJ0azp7Q+EiAcNzutQC/3Y0UyKfJRO+ JmV/+Y1J2ybta+duH7hsKb6sm871vgjXI2zS0Sg+J+dN8FuymfUfMEf2fvSIpidQBlpD9n2gWd3W RjvVsAzTkrE4lEY3FT9mxF8wuOLflfbkSoNUDP7jUfe+LghL9c7Rdwy4rz0SEclhaflk8cUzEMGZ qcnJlZRPJ1YfxZaGImbWihyg25tafEBBeaBlPnrBHedUbgotXor2mt3gm3IBTynQOK2etIXT5R7C P88H63UJQf3P/lGRIyUlV4wMawgGBoYXzXwXV8saWiIt2K5wsQINsKAjpvVbVq+zbDBw --00000000000083a11005e53a07dd--