From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59B4EA0C43; Mon, 18 Oct 2021 13:15:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DD7840142; Mon, 18 Oct 2021 13:15:28 +0200 (CEST) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by mails.dpdk.org (Postfix) with ESMTP id AEC0840141 for ; Mon, 18 Oct 2021 13:15:26 +0200 (CEST) Received: by mail-yb1-f169.google.com with SMTP id v195so3997414ybb.0 for ; Mon, 18 Oct 2021 04:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V656AIom8rQyF9bmrzS1qWYjVzv1s6cxqyiZWI4cXZg=; b=UH7TFhfIY00G2fLJo7K27AXoGgCTn84qsT/R+BLsQVC/mBpDr01kfxGES06ByNRmH6 G0A5qD9roUvz71KXagUgkKU1ThcGTB5vrAus7amZGmqbrVvJB2WWoN4u6NqDXOYTDhaZ RZumVXuj363PhbfaEfSMrPuub8cWCHidV40SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V656AIom8rQyF9bmrzS1qWYjVzv1s6cxqyiZWI4cXZg=; b=sfGZnI2vW9Lv3s7otS8KlUYrM7Dmy5SRt0behuDLJIy7GuIkR5esTxWRkkeXw1piJq fvHCzp0xTAlfxjruzX9pCLiVmgR2q9brW3M7hDpf/eva9aTqWhLVojB/5qmmPNfqGIvf p+shabf72yXY6/wf7FD1MG9tq8BGqbgGwGJGrV7U/TU1LzXUkI6Gab+/TwiQ7/vtpEuf KRV6WgGakKXDaSw129DDIs+ilceTzZZAuAfsiX7cspcDdyaMocMw3M5O+kA/yQX54YxC r0ylLgqotbIU6FOqou9GtNkGUVgBJb09l+yId3jCCBsofxQ+ek2UkcffXPXkJTfG5cOY 0jFg== X-Gm-Message-State: AOAM531imyLUCn83bEJ5c5KTe2linXjWkLelwpUF77+Paz7YNyu0EX6J mQL4y9Rce4utkVIwWLGiLnyXG9GRV/hqmhiXMrjwrg== X-Google-Smtp-Source: ABdhPJy22f6ZmDpan2H9fria3VufIj5QlFhmxc/KUXOl8cLfx1oSKbQZQdMnyXqoRG1gDBiv0gVWyy5jNuflwZV5evE= X-Received: by 2002:a5b:4c6:: with SMTP id u6mr7188724ybp.19.1634555725969; Mon, 18 Oct 2021 04:15:25 -0700 (PDT) MIME-Version: 1.0 References: <20210929214817.18082-1-olivier.matz@6wind.com> <20211015192408.21798-1-olivier.matz@6wind.com> <20211015192408.21798-3-olivier.matz@6wind.com> In-Reply-To: From: Somnath Kotur Date: Mon, 18 Oct 2021 16:45:15 +0530 Message-ID: To: Olivier Matz Cc: Andrew Rybchenko , dev , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 1:40 PM Olivier Matz wrote: > > Hi Andrew, > > On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote: > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > > VLAN flags") (2017). But they were not using the RTE_DEPRECATED > > > macro, because it did not exist at this time. Add it, and replace > > > usage of these flags. > > > > > > Signed-off-by: Olivier Matz > > > > Acked-by: Andrew Rybchenko > > > > I'd remove these flags completely. 4 years is definitely > > enough. Yes, I realize that because of missing > > RTE_DEPRECATED markup users were not warning on build. > > I kept them because David pointed me that these flags are still used by > other projects. Adding an explicit RTE_DEPRECATED() would prevent this, > and... it doesn't bother to add one more year :) > > Thank you for the review. Acked-by Somnath Kotur