From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C90FA053B; Thu, 6 Feb 2020 17:27:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 609CD1C1B7; Thu, 6 Feb 2020 17:27:37 +0100 (CET) Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id E94F21C1B3 for ; Thu, 6 Feb 2020 17:27:35 +0100 (CET) Received: by mail-ua1-f65.google.com with SMTP id 80so2464767uah.9 for ; Thu, 06 Feb 2020 08:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D6MYl1fuszZGll/mC8KJc5Q/I4kciVasbzlpR6NK1H4=; b=FXm9p1QDrMvryJdprHAKww3p8OazYEsD3kiDCPvfAyggIcLWgeBdpZmRqtNBl4kJfP pIceAwyHxnShyBYUAvQfnitBSqTujmRYBmVNHMFFSVOEQq/WLlnkiYdgudksTDywVA0y a00g4NTwk3lSk23rMgdN/eWoYIZ/DIZ/8rRIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D6MYl1fuszZGll/mC8KJc5Q/I4kciVasbzlpR6NK1H4=; b=RUAgEVPo0NOfHTLNTlT/cMi2cedUI+NQdmYVDAyCFrd5wvjKGnp+Tb+AfIiUDSbRs9 YAHeJ297dD8nVwtCROD9scD3WHIMIxhFJG/w4L0I9Gmn3WQ3HmPsexkgU4z8tQihckDZ JYRusVyju8oFsu6RXT0RmvVCpS5NwMsTKVxI7bcfwUypap2+flhIbXM2URRkQcjau2md UcGGdy9ro0QL3n3ZT1GS3i7gxRXAw7kjm9Rhm3xOzVIUfEEFhqnqIbQmOFW+X7RxbFCL wO6s6pbGMcQ26r2p2+FA47Zg3pSLAZUZUDaMo/LMEIQ+BPl8usUJpM5XBWNU2e2GBM2Z nw7Q== X-Gm-Message-State: APjAAAXuntrLl63HxTY+XzZ+J1ecfIr+uzwmhtdPQQswA0Uoh+gNxZf7 hpFa3JZp4n737iUAeHBow9GBCaJFeAh4ASYCH6YPRIZd5kY= X-Google-Smtp-Source: APXvYqyFN5Lf+5YEnijUOiHG0daBEJI8yw/chZyVxu87YPYbf8Uqr33UkRsafdSuc0CwtdBBqL9RcVWzaZs6pVkVUm8= X-Received: by 2002:ab0:6881:: with SMTP id t1mr2091473uar.88.1581006454827; Thu, 06 Feb 2020 08:27:34 -0800 (PST) MIME-Version: 1.0 References: <20200106083423.26600-1-somnath.kotur@broadcom.com> In-Reply-To: <20200106083423.26600-1-somnath.kotur@broadcom.com> From: Somnath Kotur Date: Thu, 6 Feb 2020 21:57:23 +0530 Message-ID: To: dev Cc: Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 6, 2020 at 2:05 PM Somnath Kotur wrote: > > Certain hardware may be able to strip and/or save only the outermost > VLAN instead of both the VLANs in the mbuf in a QinQ scenario. > To handle such cases, we could re-interpret setting of just > PKT_RX_QINQ_STRIPPED to indicate that only the outermost VLAN has > been stripped and saved in mbuf->vlan_tci_outer. > Only When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2 > VLANs have been stripped by the hardware and their TCI are saved in > mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer). > > Signed-off-by: Somnath Kotur > --- > lib/librte_mbuf/rte_mbuf_core.h | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h > index 9a8557d..db1070b 100644 > --- a/lib/librte_mbuf/rte_mbuf_core.h > +++ b/lib/librte_mbuf/rte_mbuf_core.h > @@ -124,12 +124,19 @@ > #define PKT_RX_FDIR_FLX (1ULL << 14) > > /** > - * The 2 vlans have been stripped by the hardware and their tci are > - * saved in mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer). > + * The outer vlan has been stripped by the hardware and their tci are > + * saved in mbuf->vlan_tci_outer (outer). > * This can only happen if vlan stripping is enabled in the RX > * configuration of the PMD. > - * When PKT_RX_QINQ_STRIPPED is set, the flags (PKT_RX_VLAN | > - * PKT_RX_VLAN_STRIPPED | PKT_RX_QINQ) must also be set. > + * When PKT_RX_QINQ_STRIPPED is set, the flags (PKT_RX_VLAN | PKT_RX_QINQ) > + * must also be set. > + * When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2 vlans > + * have been stripped by the hardware and their tci are saved in > + * mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer). > + * This can only happen if vlan stripping is enabled in the RX configuration > + * of the PMD. > + * When PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, > + * (PKT_RX_VLAN | PKT_RX_QINQ) must also be set. > */ > #define PKT_RX_QINQ_STRIPPED (1ULL << 15) > > -- > 1.8.3.1 Seeing as its been a month since it was submitted and no comments on it yet , are we ok to go ahead and merge this in please? Thanks Som