From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86A22A0C43; Fri, 16 Apr 2021 15:17:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1793141DA0; Fri, 16 Apr 2021 15:17:22 +0200 (CEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mails.dpdk.org (Postfix) with ESMTP id D9155141D9B for ; Fri, 16 Apr 2021 15:17:20 +0200 (CEST) Received: by mail-ej1-f47.google.com with SMTP id e14so42061012ejz.11 for ; Fri, 16 Apr 2021 06:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+15x3cX+VtOm5kspPCrqEdKIsK1CHl5dS8nHBiV0JZU=; b=ci8uAspi3xasLLFirIAZ1cOa3O0xUFNiXPCONnKE2+Swc6DzI5ZLPs4NhFs/3vV4TV So9lAhwz9egoMp7jJWaz4QRKKwoPEB/Se0lbHJdnPwCqKKZEpSqR9ARQ0oHeRB00NRrQ h6awdZUIRhjZOao+zILao0aknaQCUByPvZ5x4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+15x3cX+VtOm5kspPCrqEdKIsK1CHl5dS8nHBiV0JZU=; b=DjhZsDv5pK1rq6GD+HAodXEZvU72ze6itQ66+HVJAa3ODMMyA7khL605mfYC8pn9aA iSDRM2DVkjg7fGXRZNjNbcDaL4anr/XoQlhRFly/sEVBBiSXI2dtaBqdkR1W4sfQjBsQ JnMPdt183tyGgsSNcZShtif0rDiwpoYKmrDVZsg7lHHU0d6InGwaPRO9oKaN9I5orC9d 3PiVqwwu0vmqBYXyL7V38bwYMT1GkEFs/fPAenlklKzqz5MVZ1XEbLAx5MwqBsKJP2iY sca9CnPBDhVBgpd4mTm4MRkJ9hJif45gDgrGlTlTi/lzp+9uReC8Byx+xIMlkqsUTdoI zzrg== X-Gm-Message-State: AOAM531gUAYheSzpWIGr8oLrIBZlXr7yr8+TE8hZjnvULOTfjDncPxdh RRczOVNXTWQzT3LSRPCM8ZLSDx6VcQLU/Xq6/PMtIQ== X-Google-Smtp-Source: ABdhPJxRvFdcO0u0Cbll4LIVaDNeEhR98jda3QHwXLa7InmYHcqe7JmaVFo4tnC0/pJOYs0oBIq7rHsSjtBekL70mv4= X-Received: by 2002:a17:906:3e89:: with SMTP id a9mr7994338ejj.405.1618579040527; Fri, 16 Apr 2021 06:17:20 -0700 (PDT) MIME-Version: 1.0 References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <2266462.BEuj6PQKus@thomas> In-Reply-To: <2266462.BEuj6PQKus@thomas> From: Lincoln Lavoie Date: Fri, 16 Apr 2021 09:14:07 -0400 Message-ID: To: Thomas Monjalon Cc: Aaron Conole , David Marchand , dpdklab , Gaetan Rivet , dev , "Xueming(Steven) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko , Dodji Seketeli , ci@dpdk.org, Owen Hilyard Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdklab] Re: [PATCH v5 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We can look into that, but that now will need to be tested to work across all the different OS distros in the containers. For now, we can install the update on the ubuntu 18.04 worker that is running the production and remake the reference cache. Cheers, Lincoln On Fri, Apr 16, 2021 at 8:58 AM Thomas Monjalon wrote: > 16/04/2021 14:43, Lincoln Lavoie: > > All of the UNH ABI testing is moving info containers, so it can be run on > > top of each OS, alongside the other compile and unit testing. This is > > actually ready now, but hasn't been pushed live this week, because of the > > backlog in the system because of the DTS failure. The additional compile > > jobs are already online now, it's just ABI that hasn't been pushed live. > > > > This means the current ABI (what is reporting right now) is running on > > 18.04 for x86 and 20.04 for aarch64. The aarch64 one will continue > > forward, because we're not going to moving to emulated environments for > > testing on that architecture. > > > > This has two implications, first, the scripts for running ABI (and the > > other tests) become part of the container definition, and at the last > > meeting we talked about moving those definitions into the dpdk-ci repo, > > which I think makes sense. Second, there isn't an operating system to > > "maintain" since it's what's inside the container images, which are > > periodically rebuilt, but pretty much treated as ephemeral. Assuming the > > container bases / distros have the updated libabigail version packaged > with > > them. > > No, the version packaged in the OS is not recent enough. > Please check what is done in Travis and GitHub CI > in the shell function install_libabigail(): > https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n22 > > > > On Fri, Apr 16, 2021 at 8:32 AM Aaron Conole wrote: > > > David Marchand writes: > > > > > > > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li > wrote: > > > >> diff --git a/lib/librte_eal/include/rte_devargs.h > > > b/lib/librte_eal/include/rte_devargs.h > > > >> index 296f19324f..134b44a887 100644 > > > >> --- a/lib/librte_eal/include/rte_devargs.h > > > >> +++ b/lib/librte_eal/include/rte_devargs.h > > > >> @@ -60,16 +60,16 @@ struct rte_devargs { > > > >> /** Name of the device. */ > > > >> char name[RTE_DEV_NAME_MAX_LEN]; > > > >> RTE_STD_C11 > > > >> - union { > > > >> - /** Arguments string as given by user or "" for no > argument. */ > > > >> - char *args; > > > >> + union { /**< driver-related part of device string. */ > > > >> + const char *args; /**< legacy name. */ > > > >> const char *drv_str; > > > >> }; > > > >> struct rte_bus *bus; /**< bus handle. */ > > > >> struct rte_class *cls; /**< class handle. */ > > > >> const char *bus_str; /**< bus-related part of device > string. */ > > > >> const char *cls_str; /**< class-related part of device > string. > > > */ > > > >> - const char *data; /**< Device string storage. */ > > > >> + char *data; > > > >> + /**< Raw string including bus, class and driver arguments. > */ > > > >> }; > > > >> > > > >> /** > > > > > > > > - Flagging this patch for info and its impact on UNH jobs. > > > > > > > > This change is fine, but older libabigail versions could not deal > with > > > > such changes (anonymous union, changes of const fields). > > > > This results in an ABI check failure in the UNH x86 job on Ubuntu > > > > 18.04 (and for some people not using recent libabigail). > > > > I can see the ARM job passes fine, so I suppose it is using a more > > > > recent libabigail (running Ubuntu 20.04 maybe?). > > > > > > > > We either need to disable this x86 job or update its libabigail > > > > package (maybe aligning with what we have for public CI which is > > > > libabigail 1.8 manually compiled). > > > > > > > > > > > > - For the longer term, what do you think of using/extending the .ci/ > > > > scripts for use by UNH jobs? > > > > > > I think it would be great if we had some of the scripts shared as a > > > common resource. That would also help us to look at fixes / changes > > > when needed. > > > > > > > > > > > > > > > > -- *Lincoln Lavoie* Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m)