From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A72A2A0C46; Wed, 9 Jun 2021 18:01:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AA114069B; Wed, 9 Jun 2021 18:01:13 +0200 (CEST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id 26A6B4003C for ; Wed, 9 Jun 2021 18:01:12 +0200 (CEST) Received: by mail-ed1-f44.google.com with SMTP id cb9so29193426edb.1 for ; Wed, 09 Jun 2021 09:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sCWNjPiUUNu8cSEwUAx0v/3uPvoVqwYOn4iuKSnMSVU=; b=AiTX3REqHXl/MD5lN1cRZDhDCzBUJgVcdIaZttvHySuHc36uM1m2n0MwNjSP8F+0KV +9fUlDHfJ1QpMqEjGujzuWShIvpA8kYRXEq6r26RmAjGYRYFF28g3smSEQ9QbaIWeZ6T eif8iSJvlQ33qEKWc3A0lkCTYQBPGLWIgJZos= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sCWNjPiUUNu8cSEwUAx0v/3uPvoVqwYOn4iuKSnMSVU=; b=dAZw/SiCSJ5pc8RG5lrbTRCa5YP03i2bzQRCNbK1gqJAZrUc/lbCYSUBGTWFi5hlJy DkYtaGU3DHbZ41bAKo0wGsFH11Vjcv2hmZEGMT1EgwXefDrlrecahSu2mWEcSn9hgpEs PrwNvVMzPu4hbHL0qxjOzmIDdedLYD5OdRxEc/edVEgOmoAAOqHL4gbl5kVn8oHf6Ipa GR5xjazqeDDI6j9DpYdcZjGvwnn+aLV3wEb3ufuS42mw5DwVgXn80upGlisWWKq8bg6G 62uxCVTgEpOS5SHnV3bxHJtR+67qoBoI0RsaBgKw6LuLNS5PYR+WpiurY1kyt81onaYD K+fA== X-Gm-Message-State: AOAM530GuBjJjnke2AXqxfyESvklR4+hqJXJ8WZ8c6fviGIM1qiAybTZ jBRf0PuiaIPldf+w+WRkWmQ6nB8YuzylkUnuoqVjQw== X-Google-Smtp-Source: ABdhPJxmJyiOa9dptl7aCJ0OOkZThkvxdmm+VzjgoJGvbVV07+9lhqLfi1Hio5USEQt6BQubz5csvs5rZ+4oNmmP1Tk= X-Received: by 2002:a50:ed82:: with SMTP id h2mr162612edr.140.1623254471843; Wed, 09 Jun 2021 09:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20210526214343.31352-1-dmitry.kozliuk@gmail.com> <20210527212421.24224-1-dmitry.kozliuk@gmail.com> <20210609185219.5eefdddd@sovereign> In-Reply-To: <20210609185219.5eefdddd@sovereign> From: Lincoln Lavoie Date: Wed, 9 Jun 2021 12:01:00 -0400 Message-ID: To: Dmitry Kozlyuk Cc: dev , Zhihong Peng , Neil Horman , ci@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH v2] pmdinfogen: allow padding after NUL terminator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, If the failing test is the unit test func_reentrancy_autotest, that is being looked into , as it seems like the test case does not reliably run. It passes / fails between different systems running both on bare metal and in virtual environments, on different OSes and architectures. Do you have a link to your patch in patchworks or the lab dashboard? Cheers, Lincoln On Wed, Jun 9, 2021 at 11:52 AM Dmitry Kozlyuk wrote: > 2021-05-28 00:24 (UTC+0300), Dmitry Kozlyuk: > > Size of string constant symbol may be larger than its length > > measured up to NUL terminator. In this case pmdinfogen included padding > > bytes after NUL terminator in generated source, yielding incorrect code. > > > > Always trim string data to NUL terminator while reading ELF. > > It was already done for COFF because there's no symbol size. > > > > Bugzilla ID: 720 > > Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen") > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > v2: return helper to coff.py, where it's needed (David Marchand). > > > > buildtools/pmdinfogen.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py > > index 7a739ec7d4..2a44f17bda 100755 > > --- a/buildtools/pmdinfogen.py > > +++ b/buildtools/pmdinfogen.py > > @@ -28,7 +28,7 @@ def __init__(self, image, symbol): > > def string_value(self): > > size = self._symbol["st_size"] > > value = self.get_value(0, size) > > - return value[:-1].decode() if value else "" > > + return coff.decode_asciiz(value) # not COFF-specific > > > > def get_value(self, offset, size): > > section = self._symbol["st_shndx"] > > There are CI failures that seem unrelated to this patch: > some tests with NICs that I can't check > and an Arch Linux build failure that I failed to reproduce. > GitHub Actions are passing. > Are these known CI bugs or does this patch need any corrections? > -- *Lincoln Lavoie* Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m)