DPDK patches and discussions
 help / color / mirror / Atom feed
From: Simon Jones <batmanustc@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [bugfix] set same mac of bond slave
Date: Tue, 30 Apr 2024 14:37:59 +0800	[thread overview]
Message-ID: <CAOE=1Z0xHwNv+bpksGPU7VUCg7BGR0NKFTxj9b83AFnkHEVTUA@mail.gmail.com> (raw)
In-Reply-To: <20240429203716.1190fa2f@hermes.local>

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

OK

Does you mean that, need this patch to set same mac, but change
"internals->slaves" to "internals->members".

What I want to say is, in my test (DPDK-21.11), bond mac is NOT same in
802.3ad mode.
So when bond connect to some SWITCH, will it NOT work?
So I want to set same mac, and discuss here if it's necessary.

----
Simon Jones


Stephen Hemminger <stephen@networkplumber.org> 于2024年4月30日周二 11:37写道:

> On Tue, 30 Apr 2024 09:17:30 +0800
> Simon Jones <batmanustc@gmail.com> wrote:
>
> > Hi, all
> >
> > Should bond slave need set same mac address?
> > Like this patch does:
> >
> https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722
> > ```
> > commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD ->
> > bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429)
> > Author: batmancn <batmanustc@gmail.com>
> > Date:   Mon Apr 29 18:44:18 2024 +0800
> >
> >     Bugfix, config same mac address of bond slave.
> >
> >     Signed-off-by: Simon Jones <batmanustc@gmail.com>
>
> This won't apply to current DPDK since slave has been renamed to member.
>

[-- Attachment #2: Type: text/html, Size: 2072 bytes --]

  reply	other threads:[~2024-04-30  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  1:17 Simon Jones
2024-04-30  3:37 ` Stephen Hemminger
2024-04-30  6:37   ` Simon Jones [this message]
2024-04-30 15:55 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOE=1Z0xHwNv+bpksGPU7VUCg7BGR0NKFTxj9b83AFnkHEVTUA@mail.gmail.com' \
    --to=batmanustc@gmail.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).