From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE1543F52; Tue, 30 Apr 2024 08:38:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC3B402A8; Tue, 30 Apr 2024 08:38:13 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 4CC3E40262 for ; Tue, 30 Apr 2024 08:38:13 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1ec4dd8525cso1164195ad.3 for ; Mon, 29 Apr 2024 23:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714459092; x=1715063892; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lymiFDHWPZx3UWbGbHMd/ap7PeXONvd+xLlPd8Cangg=; b=Tc56ePk4NcFt22uLvpJrEU+/3tW3CRHAbheeIsYPsk8mtu9XhceT5uSKeqtF5DONVN BcxiCA8JgfG3hU5YgalwgxCwrBFXMmpgYFQyCpV/klaaGDk8iaFnZJm+HPuKaLCsignd A/nKPthYpJW8aCj9WhJqkSQGe/kRFKV4U9W2Mi9eZicSO6EgoYaOgT94c9rhUcvx9jGe KoPhtaI+5UsV6J83kFrQ4+NvNRX0pu0esWYjM22KDnhceInEgsFm+wlCfS13C24bnID1 VLUYQF6Lrh4N5tiSdUFUlxggMrfo+u01XEfI8coGvrx628eE4huQH+lQdMwJ4mrvByCn zu/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714459092; x=1715063892; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lymiFDHWPZx3UWbGbHMd/ap7PeXONvd+xLlPd8Cangg=; b=wbw9UYlDCbri1y3CoO2meCEi5Aimw7yAI3U5JOwChyScq2AxUEUzCgcU5Z6O9GfEAM O3qq8SpA7H11BWfiftQbfsqDeBPi58EDGG57QAbBFm9WwOWav8ZM5CjlS3fS+nowqAS+ nlDRHkP+wABOBKX+ffRBUeWNRgdBKmSlCikczXmqb2ikgqHCtHLMn0lVioy47Jnfr+VL 2J7/zMnvC4KazCMKV2tfL/jYj5jjAcO3bX5cTUR0hMQZcpTu5k5+WIX1MJbJIRziBuMx JTuNvdWDvT6bNiwOFcJ2GrKmWMZztFWcuIGCysW75T3/YyHYSsAJGxUoTn97gPnWRWjs z7iw== X-Gm-Message-State: AOJu0YzIWTl8uQuGWvSzoPcscHo5kkOcMDIRbmnLnLOLGkpjpjk7WFNB T+7G37zXtDSePIW/B7j4/VPk4Cy14vcvJ3jtiST7F7LQlHHwFw9BqDp/dbaBuM/vhm+d502WkcC f7CiFvQ9U6e06wvEVqSTdWJKjrPms8rm76yXIrw== X-Google-Smtp-Source: AGHT+IFjGTsPM61R1tZrbGmUgvq0nNbGq5sspZewyquwZn1C3VR+1kBQck+BmlqJmXMPJM7TuwMy5Ot95fXYz+MRrsU= X-Received: by 2002:a17:903:2447:b0:1e4:17e4:3a1f with SMTP id l7-20020a170903244700b001e417e43a1fmr11364438pls.4.1714459092291; Mon, 29 Apr 2024 23:38:12 -0700 (PDT) MIME-Version: 1.0 References: <20240429203716.1190fa2f@hermes.local> In-Reply-To: <20240429203716.1190fa2f@hermes.local> From: Simon Jones Date: Tue, 30 Apr 2024 14:37:59 +0800 Message-ID: Subject: Re: [bugfix] set same mac of bond slave To: Stephen Hemminger Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000002d960006174a9d96" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000002d960006174a9d96 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK Does you mean that, need this patch to set same mac, but change "internals->slaves" to "internals->members". What I want to say is, in my test (DPDK-21.11), bond mac is NOT same in 802.3ad mode. So when bond connect to some SWITCH, will it NOT work? So I want to set same mac, and discuss here if it's necessary. ---- Simon Jones Stephen Hemminger =E4=BA=8E2024=E5=B9=B44=E6= =9C=8830=E6=97=A5=E5=91=A8=E4=BA=8C 11:37=E5=86=99=E9=81=93=EF=BC=9A > On Tue, 30 Apr 2024 09:17:30 +0800 > Simon Jones wrote: > > > Hi, all > > > > Should bond slave need set same mac address? > > Like this patch does: > > > https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e7= 6833722 > > ``` > > commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD -> > > bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429) > > Author: batmancn > > Date: Mon Apr 29 18:44:18 2024 +0800 > > > > Bugfix, config same mac address of bond slave. > > > > Signed-off-by: Simon Jones > > This won't apply to current DPDK since slave has been renamed to member. > --0000000000002d960006174a9d96 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
OK

Does you mean that, need this patch to set = same mac, but change "internals->slaves" to "internals-&g= t;members".

What I want to say is, in my test (DPDK-21.11), bon= d mac is NOT same in 802.3ad mode.
So when bond connect to some SWITCH, = will it NOT work?
So I want to set same mac, and discuss here if it'= s necessary.

----
Simon Jones


Ste= phen Hemminger <stephen@ne= tworkplumber.org> =E4=BA=8E2024=E5=B9=B44=E6=9C=8830=E6=97=A5=E5=91= =A8=E4=BA=8C 11:37=E5=86=99=E9=81=93=EF=BC=9A
On Tue, 30 Apr 2024 09:17:30 +0800
Simon Jones <b= atmanustc@gmail.com> wrote:

> Hi, all
>
> Should bond slave need set same mac address?
> Like this patch does:
> https://github.= com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722
> ```
> commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD ->
> bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429)=
> Author: batmancn <batmanustc@gmail.com>
> Date:=C2=A0 =C2=A0Mon Apr 29 18:44:18 2024 +0800
>
>=C2=A0 =C2=A0 =C2=A0Bugfix, config same mac address of bond slave.
>
>=C2=A0 =C2=A0 =C2=A0Signed-off-by: Simon Jones <batmanustc@gmail.com>

This won't apply to current DPDK since slave has been renamed to member= .
--0000000000002d960006174a9d96--