From: Simon Jones <batmanustc@gmail.com>
To: dev@dpdk.org
Subject: [bugfix] set same mac of bond slave
Date: Tue, 30 Apr 2024 09:17:30 +0800 [thread overview]
Message-ID: <CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2118 bytes --]
Hi, all
Should bond slave need set same mac address?
Like this patch does:
https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722
```
commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD ->
bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429)
Author: batmancn <batmanustc@gmail.com>
Date: Mon Apr 29 18:44:18 2024 +0800
Bugfix, config same mac address of bond slave.
Signed-off-by: Simon Jones <batmanustc@gmail.com>
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/net/bonding/rte_eth_bond_pmd.c
index c40d18d128..0387a9b2aa 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1562,6 +1562,15 @@ mac_address_members_update(struct rte_eth_dev
*bonding_eth_dev)
}
break;
case BONDING_MODE_8023AD:
+ for (i = 0; i < internals->slave_count; i++) {
+ if (rte_eth_dev_default_mac_addr_set(
+ internals->slaves[i].port_id,
+ bonded_eth_dev->data->mac_addrs)) {
+ RTE_BOND_LOG(ERR, "Failed to update port Id
%d MAC address",
+
internals->slaves[i].port_id);
+ return -1;
+ }
+ }
bond_mode_8023ad_mac_address_update(bonding_eth_dev);
break;
case BONDING_MODE_ACTIVE_BACKUP:
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index f1c658f49e..c3f8b8d01e 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1746,7 +1746,8 @@ rte_eth_dev_start(uint16_t port_id)
return ret;
/* Lets restore MAC now if device does not support live change */
- if (*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR)
+ if ((*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR) &&
+ !(*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE))
eth_dev_mac_restore(dev, &dev_info);
diag = (*dev->dev_ops->dev_start)(dev);
~
```
----
Simon Jones
[-- Attachment #2: Type: text/html, Size: 3029 bytes --]
next reply other threads:[~2024-04-30 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 1:17 Simon Jones [this message]
2024-04-30 3:37 ` Stephen Hemminger
2024-04-30 6:37 ` Simon Jones
2024-04-30 15:55 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com' \
--to=batmanustc@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).