* [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted
@ 2020-05-27 20:13 Muhammad Bilal
2020-05-27 20:59 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Muhammad Bilal @ 2020-05-27 20:13 UTC (permalink / raw)
To: dev
Recently I have submitted patches and some tests were failing on patchwork.
My question is, which tests are compulsory to pass for a patch to be accepted.
As in the below mentioned patch, it is accepted while 1 test was still failing.
http://patches.dpdk.org/patch/70348/
kind regards.
Muhammad Bilal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted
2020-05-27 20:13 [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted Muhammad Bilal
@ 2020-05-27 20:59 ` Stephen Hemminger
2020-06-02 11:42 ` Muhammad Bilal
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-05-27 20:59 UTC (permalink / raw)
To: Muhammad Bilal; +Cc: dev
On Thu, 28 May 2020 01:13:27 +0500
Muhammad Bilal <m.bilal@emumba.com> wrote:
> Recently I have submitted patches and some tests were failing on patchwork.
> My question is, which tests are compulsory to pass for a patch to be accepted.
> As in the below mentioned patch, it is accepted while 1 test was still failing.
> http://patches.dpdk.org/patch/70348/
>
> kind regards.
> Muhammad Bilal
There are two different issues:
1. A patch should not get blamed for some failure in the CI infrastructure.
Or collataral damage from an earlier merge.
2. A patch must not introduce a failure. I.e. if all tests passed before
each patch in a patchset must pass.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted
2020-05-27 20:59 ` Stephen Hemminger
@ 2020-06-02 11:42 ` Muhammad Bilal
0 siblings, 0 replies; 3+ messages in thread
From: Muhammad Bilal @ 2020-06-02 11:42 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
Thank you for your response.
How will we know if a patch is failing because of some failure in the
CI infrastructure or due to earlier merge?
On Thu, May 28, 2020 at 1:59 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 28 May 2020 01:13:27 +0500
> Muhammad Bilal <m.bilal@emumba.com> wrote:
>
> > Recently I have submitted patches and some tests were failing on patchwork.
> > My question is, which tests are compulsory to pass for a patch to be accepted.
> > As in the below mentioned patch, it is accepted while 1 test was still failing.
> > http://patches.dpdk.org/patch/70348/
> >
> > kind regards.
> > Muhammad Bilal
>
> There are two different issues:
> 1. A patch should not get blamed for some failure in the CI infrastructure.
> Or collataral damage from an earlier merge.
> 2. A patch must not introduce a failure. I.e. if all tests passed before
> each patch in a patchset must pass.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-02 11:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 20:13 [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted Muhammad Bilal
2020-05-27 20:59 ` Stephen Hemminger
2020-06-02 11:42 ` Muhammad Bilal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).