From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4E33A04EF; Mon, 2 Dec 2019 22:20:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD79E1F28; Mon, 2 Dec 2019 22:20:43 +0100 (CET) Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) by dpdk.org (Postfix) with ESMTP id 99A0E235 for ; Mon, 2 Dec 2019 22:20:42 +0100 (CET) Received: by mail-yb1-f193.google.com with SMTP id v15so607025ybp.13 for ; Mon, 02 Dec 2019 13:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tg2eiza80w2SWFhR9gIgCNhUzH05BDvyvhqIJTXXXXo=; b=INAkN220zJmi6S0hGdhhSi8eA5+YTYA7G4tJwnSTiqBLrGxPe0xCWE33L+bTi8mUpU MUq23pkuitP1fd5GaWshmw0b9oC2Hb+/ETBMNtTcLeeXcgkRoONhbWsCCnfjqclBaMhD 0pJRGgZpS4ryEZG1IXbLbsUogDNtL3UXdlgd6UzY2zL0Y/kCcqXHawdkhtbeA74AxRyB 0wfQyz55XMceiADRkyOG3xRQDGI+U+g/bY0Aq7xH7qb38yMatF1+k9tk6aEfsZTpnpBP Eriku6z2IF+I7YA2zp0R3OU1W95fBbGpv8IpgVbNDxNQpsZldPqoode4SytOG4+bagA9 iIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tg2eiza80w2SWFhR9gIgCNhUzH05BDvyvhqIJTXXXXo=; b=ammL7Klqsg2JyNQaXmNfE20FvHz8A/IsREMc7P7gCukWLBRG2DLBOVxXOR0lPEpQkM +IQwPhDLbSbyrplWG7vasvey6/b++p+gb8iH1f+7HFScOwyPt/LpI0CLKaiV9oNZ8g86 RLmmpFbPhl3mRfN8U/rs/J1YcCwtW+wbCaMnVmgZOhlWxpRbFwLj+osp04ix3WyKAxsJ +Ah6n/hNkj0MgOCqXSoX9+C7jxPm/UxMXZRXd2xn2GUKSwXyFgk+aXadu57x8ELWJCvt p+cnP1AxLxj0YD/y7F5L7VL8r4OkZOXXXKxq/Gxkcff0aDBO3Fek8bRZP3KTDGM0C6NZ Wbpg== X-Gm-Message-State: APjAAAUusJs0Xojxb0Bi949RjdtJWg1PwxOnJpDKhXHT6FZIofjaPyuj cvdAskp1hMovQMtrTZFqjwvUsZPooReskojUqEA= X-Google-Smtp-Source: APXvYqyEPbWiHbDvyUdaqaetXOD4aSnK1c+piEjb6BxiUbqbzzZop9JQs1oLfil4RTmhw0ySo5JtcHCKYEjaTlfGcvI= X-Received: by 2002:a25:b4e:: with SMTP id 75mr1291570ybl.482.1575321641516; Mon, 02 Dec 2019 13:20:41 -0800 (PST) MIME-Version: 1.0 References: <20191119234258.41004-1-frank.li.65@gmail.com> <20191120004709.48292-1-frank.li.65@gmail.com> In-Reply-To: From: Frank Li Date: Mon, 2 Dec 2019 13:20:30 -0800 Message-ID: To: "Wiles, Keith" Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Keith, Thanks for fixing my macros from ETHER_TYPE_IPv6 to PG_ETHER_TYPE_IPv6 in your latest commit. I tested the 'dev' branch with tap interfaces running the command: `pktgen l 1-5 -n 4 --proc-type auto --log-level debug --file-prefix pg --vdev=3Dnet_tap0 --vdev=3Dnet_tap1 -- -T -P -m [2:3].0 -m [4:5].1` When I use the latest commit, pktgen crashes. When I go back 1 commit to my changes (manually fixing the ether type macros), my IPv6 changes do work as expected running the same command. Here is the error I saw: Initialize Port 0 -- TxQ 1, RxQ 1 Src MAC 5a:d7:d5:38:f8:a7 Initialize Port 1 -- TxQ 1, RxQ 1 !PANIC!: Cannot create mbuf pool (Default TX 1:0) port 1, queue 0, nb_mbufs 16384, socket_id 0: Cannot allocate memory PANIC in pktgen_mbuf_pool_create(): Cannot create mbuf pool (Default TX 1:0) port 1, queue 0, nb_mbufs 16384, socket_id 0: Cannot allocate memory 6: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen() [0x53b853]] 5: [/lib64/libc.so.6(__libc_start_main+0xf5) [0x7fc787ed73d5]] 4: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(main+= 0xf03) [0x4977f3]] 3: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(pktge= n_config_ports+0x1d02) [0x567832]] 2: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(__rte= _panic+0xb8) [0x488bf2]] 1: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(rte_d= ump_stack+0x16) [0x667ca6]] I haven't tried running pktgen with any other options, and I do believe my changes are incorporated properly, just wanted to bring this error to your attention in case it may be helpful for you. Best, Frank On Fri, Nov 29, 2019 at 4:03 PM Wiles, Keith wrote: > > > > On Nov 19, 2019, at 6:47 PM, Frank Li wrote: > > > > Current IPv6 functionality in pktgen is broken. This fix makes it so th= at > > IPv6 addresses are properly set when using the set, sequence, and save > > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresse= s > > are properly set. > > > > To preserve the runtime commands, the `_atoip` function no longer takes > > in flags to specify converting IPv4/6 addresses, and will try both, > > returning, 4, 6, or -1 for a valid IPv4/6, invalid address, respectivel= y. > > > > Also print IPv6 addresses in UI properly. > > > > Co-authored-by Valentin Andrei > > > > Signed-off-by: Frank Li > > --- > > I applied this patch and if you have time do a pull on the pktgen repo an= d > switch over to the =E2=80=98dev=E2=80=99 branch and see if this version w= orks for you. > > Regards, > Keith > >