From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C6E8A04A2; Tue, 5 Nov 2019 22:04:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 468081BF40; Tue, 5 Nov 2019 22:04:29 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id C3AA31BF24 for ; Tue, 5 Nov 2019 22:04:27 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id a11so23142295wra.6 for ; Tue, 05 Nov 2019 13:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=banduracyber-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6UK5Cn/9VXrycwL7X3iYU2UpMc7WfMfj+1SxiSXG/lo=; b=YtIDknuapOWo4JNl15u/OC/kRvWFCieZsRmOhKLsx4kTR817f2QudwxM1Y36bzGZ9G FSkRhic9pLsqjUzycaPg5twdW2DfNln8rcZNKsx6stdjE3x7SzH2vXwTn2lxjrCzWJFS Udic83nwghV6CXsTap4gqUMwLmL8P0eTdEzZcVAp08UjSK1Doeib4j57pIAlu6i11Ikc O1Wasa8lGoT7rJxhDK7Caa/6tdUlwr1frzBtAMMMzYzNf2GZSgSRrF3IOQ6PUUvYkL7D kUhMh3kEUxA+HTrB6IQw+iyKgLmQj10xBC6FXjuvFrf1YcIBYHVwm5+4eW35VG5MFqmT qCpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6UK5Cn/9VXrycwL7X3iYU2UpMc7WfMfj+1SxiSXG/lo=; b=nds3bydSGCHQ8j1dkmwTKrObPvrfPKhD6vnsxD000hvzLINAvAhRQT6V1CWXSj+WEB prDqc7GER+0pEX/v6V5PNVl+1EqR1u0Z6kOOWj4tTThs/Fh+gMaBVqNj/S4HMaaD2P1J tdvO/i0s35W8ryVsVtZ73rJB0cx42/50C2hRI/wVuhpHxclfVRikVmllAX+mhdVy7FJA 0QTXCGhO1gL6WP5ujnGHYjAd5Ceagel/Lr9mo9RZsW+i8YiTVcpClmwmoDmKs+d7mMM/ WfRG81pC/y03b6+qntzKUhLmiu6SlBnE2NkiC3UXUDqrHNFKfZVJa+YmhDREq0V3X5Xw UFhA== X-Gm-Message-State: APjAAAXRD+ehSLnM9bQfg2cWr+rCnSqdYViKO4r8hEy6ZnzdnI0xPvFR LJWh76NdJIsJ2hSF8vhUnp+cJbZUiMa3IKtRNTEjtw== X-Google-Smtp-Source: APXvYqxIxKKviE8rRtXRgpi1aZiuJidJ3bHzQjeu761bwKLzHptRQ4QJ+4drdbb3DkO73ggVh/iXH6JhijDr5jw57cc= X-Received: by 2002:adf:ec4b:: with SMTP id w11mr28823108wrn.243.1572987867453; Tue, 05 Nov 2019 13:04:27 -0800 (PST) MIME-Version: 1.0 References: <20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com> In-Reply-To: From: Devyn Johnson Date: Tue, 5 Nov 2019 15:04:16 -0600 Message-ID: To: David Marchand Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 5, 2019 at 1:36 PM David Marchand wrote: > Hello, > > On Tue, Nov 5, 2019 at 7:17 PM wrote: > > > > From: Devyn Collier Johnson > > > > Signed-off-by: Devyn Collier Johnson > > --- > > lib/librte_cryptodev/rte_cryptodev.c | 4 ++-- > > lib/librte_eal/common/eal_common_cpuflags.c | 4 ++-- > > lib/librte_eal/common/eal_common_errno.c | 2 +- > > lib/librte_eal/common/eal_common_hexdump.c | 4 ++-- > > lib/librte_eal/common/eal_common_lcore.c | 10 +++++----- > > lib/librte_eal/common/eal_common_log.c | 10 +++++----- > > lib/librte_eal/common/eal_common_memalloc.c | 8 ++++---- > > lib/librte_eal/common/eal_common_memory.c | 2 +- > > lib/librte_eal/common/eal_common_proc.c | 2 +- > > lib/librte_eal/common/eal_common_tailqs.c | 2 +- > > lib/librte_eal/common/eal_memalloc.h | 8 ++++---- > > lib/librte_eal/common/eal_private.h | 2 +- > > lib/librte_eal/common/include/rte_bitmap.h | 20 ++++++++++---------- > > lib/librte_eal/common/include/rte_common.h | 2 +- > > lib/librte_eal/common/include/rte_errno.h | 2 +- > > lib/librte_eal/common/include/rte_hexdump.h | 2 +- > > lib/librte_eal/common/include/rte_lcore.h | 10 +++++----- > > lib/librte_eal/common/include/rte_log.h | 8 ++++---- > > lib/librte_eal/common/malloc_elem.c | 4 ++-- > > lib/librte_eal/linux/eal/eal.c | 2 +- > > lib/librte_ethdev/rte_class_eth.c | 2 +- > > lib/librte_ethdev/rte_mtr.c | 2 +- > > lib/librte_ethdev/rte_tm.c | 2 +- > > lib/librte_mbuf/rte_mbuf.c | 4 ++-- > > lib/librte_mbuf/rte_mbuf_dyn.c | 4 ++-- > > lib/librte_mempool/rte_mempool.c | 2 +- > > lib/librte_ring/rte_ring.c | 2 +- > > lib/librte_timer/rte_timer.c | 20 ++++++++++---------- > > 28 files changed, 73 insertions(+), 73 deletions(-) > > Thanks for the patch. > > It is missing a commitlog describing the problem that you faced, and > explaining how this patch fixes this problem. > It touches a lot of different parts of the dpdk, which will make it > harder to review and (if applicable) harder to backport in stable > branches. > > Before submitting new patches, please take the time to read our > contributing guide that you can find here: > http://doc.dpdk.org/guides/contributing/patches.html > > > -- > David Marchand > > These changes are merely one step toward making DPDK compile successfully when using the compiler flags `-Werror -Wall -Wextra -Wpedantic -Wdangling-else -Wdate-time -Wdisabled-optimization -Winit-self -Winvalid-pch -Woverlength-strings -Wpointer-arith -Wredundant-decls -Wshift-negative-value -Wstack-protector -Wuninitialized -Wunused-parameter -Wunused-result`. Doing so can frequently reduce the probability of bugs that are difficult to reproduce as well as point out situations the developer did not intend to create. Currently, DPDK will not compile with such flags set. -- Thanks, Devyn Collier Johnson Devyn.Johnson@BanduraCyber.com