From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 479575597 for ; Mon, 25 Jul 2016 17:15:49 +0200 (CEST) Received: by mail-qk0-f193.google.com with SMTP id q62so14536616qkf.2 for ; Mon, 25 Jul 2016 08:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GKFRmOkKLTyGt8601uyXUWbBjNQJxcl3F/FtBDcBPEU=; b=aMricE8ip4cGmCX7OLIA8ORuLxES+1kg9EOM3Yl1XiaKfqh0yyLmxjooIrUDZJJo5I 2CegEYZ0FPr+id6Z8d7Xzisi7IBhIE4+OorXfKlP6/2sJZz232OAVkfujDKV5XYDo/pB SFdDdvqLc8N23nVCZWMH9iDyoDfPdCNgSh8NIZBfQBopO0QW1vWalBfzDvJ6jza51U1D YOpQKIrWmt4Xe3mQvhdmR1/nJ2QZeIQVi1KU8O2KDcy5qp2VVG9sUkO7TKzwfRFeIZDz d6l3qRKBwSVfTH8astq5OkmY9zVEfKiGBojyswiLxtWN3V9vRBTOOsLvtkINecSK/SF1 v2aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GKFRmOkKLTyGt8601uyXUWbBjNQJxcl3F/FtBDcBPEU=; b=RgSpimCV7+xjd/1qo049Dn17g3AdV4KpSzwmDfieYtMCS/XE499A+8xtovIdzac5oI LhIb/NL6z7dDaGcvQuxsdkc2PBqbYWGnbAbCMyGv/MKFy0Hir0MkwG7n9Kx4Qu439bL/ rGbi6mVy2Eu4q9EHGSiLRJ3wCSS1K6bYM1NnWnOHX45tQLkM5hDBf1zajlgoOOKXI6Vh QXEOm0EirhZ0Hovzyb35sN7fcqm5ENx2a151T3fiZoPnR6KGGGFxi/r1gxW7AJA4BNfj tAHIyVmZxypeBeVQ/+bbjggwrM3L2LB4Q330p2GJ5OE+0P5RbgbJrHk8gV8Rsoext1LN VWAA== X-Gm-Message-State: AEkoousgLIWgGeoBzzLbkVpFCaLSPbfLiECWV3iK49TRBURC3Q0OKjhv9WPU41ajONFjqPgnWAvONlmfUDJPgA== X-Received: by 10.37.66.212 with SMTP id p203mr14656981yba.34.1469459748782; Mon, 25 Jul 2016 08:15:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.36.87 with HTTP; Mon, 25 Jul 2016 08:15:29 -0700 (PDT) In-Reply-To: References: <1468776950-32693-1-git-send-email-h.mikita89@gmail.com> From: Hiroyuki Mikita Date: Tue, 26 Jul 2016 00:15:29 +0900 Message-ID: To: "Sanford, Robert" Cc: "dev@dpdk.org" , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 15:15:49 -0000 Fixes: a4b7a5a45cf5 ("timer: fix race condition") 2016-07-23 7:06 GMT+09:00 Sanford, Robert : > > > On 7/17/16 1:35 PM, "Hiroyuki Mikita" wrote: > >>When timer_set_running_state() fails in rte_timer_manage(), >>the failed timer is put back on pending-list. >>In this case, another core tries to reset or stop the timer. >>It does not need to be on pending-list >> >>Signed-off-by: Hiroyuki Mikita >>--- >> lib/librte_timer/rte_timer.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c >>index 3dcdab5..94878d3 100644 >>--- a/lib/librte_timer/rte_timer.c >>+++ b/lib/librte_timer/rte_timer.c >>@@ -562,10 +562,9 @@ void rte_timer_manage(void) >> pprev = &tim->sl_next[0]; >> } else { >> /* another core is trying to re-config this one, >>- * remove it from local expired list and put it >>- * back on the priv_timer[] skip list */ >>+ * remove it from local expired list >>+ */ >> *pprev = next_tim; >>- timer_add(tim, lcore_id, 1); >> } >> } >> >>-- >>2.7.4 >> > > Acked-by: Robert Sanford >