From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f49.google.com (mail-pg0-f49.google.com [74.125.83.49]) by dpdk.org (Postfix) with ESMTP id 7C7122BB4 for ; Tue, 12 Sep 2017 00:04:03 +0200 (CEST) Received: by mail-pg0-f49.google.com with SMTP id i130so10391387pgc.3 for ; Mon, 11 Sep 2017 15:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tLpyXm97miVFi8A2SFad/qYhGnzsqEeIs6CuT+uom6M=; b=COYltAFuQmqZjXvdRl2gLcW3UIm8qUatkhVL5z6rsQWoPzW3QwcppOWrGCkCiadZ0R CsXSHdTNkIDay/Gcq8AI0PcuQAtRNFq69VwhjTPTd0ZdieiSdBo7/0lwJdTMD9iuufnZ 7MBvDL6sJPdC6GEXh3PzlaTO4Ow1mOIWfqFJPXLM3XWPi6ohGlDERHalwYXuFDvPrHhg hznn1duXN0naFXhZTbIof48mlr6dLIqQo8zae/Vvf22LFK4mDBiRfiMBoicR/AJnbKUm wHXo5ZHMPLobJjlZ6I+ai8NJnhl9ByzY6EWIzw31v1Z8Cza72zzPuZwDFrUnZtxG0mqG +fww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tLpyXm97miVFi8A2SFad/qYhGnzsqEeIs6CuT+uom6M=; b=HX4tM/U943EDDf4nYGnc20vYhXjWEaswH0EoeLPaPJPXD2YnC9EZjkey8+04hYMQZL A/1cSWw1ktH3FHYK3cJriN2MdJENgk09rLqmyL4ArEgqs5ZG4fMbKhizyRaitWY81ikL Hoksm3ANoUdtCE61vMsppA1yyYFaq1Kr3mc3HKUHgOqDFHJdm5yhqgPeRTXzc1tlS4Xq tHIGBKwGWxYy2xLqjY8TE3xZpw+I2G7k+PTa2apD1Wm9DasA/f6WjkTs17oMxP9949oc P+a2kZvDH7OYhXnkH2FMRM2/+GygvmRb9ZPOjVH8fhwOC5sTWGeeGCaU6ohLK3w3vylF qLIg== X-Gm-Message-State: AHPjjUhtiLwjp0BpZTaxXp209sKlvLMzYdyk8m3EXySqna/BwtYKSaF0 JldtCXbomTHuv31G68VK/WcWRtlOmLKu X-Google-Smtp-Source: ADKCNb7ZQMMqtbfxxzl3uVOcP2BUjUtq3muvGo2HFEiBLCZFr10jegXh5Cki1TLMHvCssj+qmq7rxFyHoZQ2s6oyzy0= X-Received: by 10.99.109.139 with SMTP id i133mr12572193pgc.29.1505167442728; Mon, 11 Sep 2017 15:04:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.178.77 with HTTP; Mon, 11 Sep 2017 15:04:01 -0700 (PDT) Received: by 10.100.178.77 with HTTP; Mon, 11 Sep 2017 15:04:01 -0700 (PDT) In-Reply-To: References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de> From: Stephen Hemminger Date: Mon, 11 Sep 2017 15:04:01 -0700 Message-ID: To: Ferruh Yigit Cc: Markus Theil , dev@dpdk.org, nicolas.dichtel@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 22:04:03 -0000 I wonder if it is time to move the bar forward to oldest LTS which is 3.2.92 On Sep 11, 2017 10:56 AM, "Ferruh Yigit" wrote: > On 9/5/2017 1:04 PM, Markus Theil wrote: > > The patch which introduced the usage of pci_alloc_irq_vectors > > came after the patch which switched to non-threaded ISR (f0d1896fa1), > > but did not use non-threaded ISR, if pci_alloc_irq_vectors > > is used. > > > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for > > MSI-X") > > Cc: nicolas.dichtel@6wind.com > > > > Signed-off-by: Markus Theil > > --- > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > index 93bb71d..6885e72 100644 > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > @@ -331,6 +331,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev > *udev) > > #else > > if (pci_alloc_irq_vectors(udev->pdev, 1, 1, PCI_IRQ_MSIX) > == 1) { > > dev_dbg(&udev->pdev->dev, "using MSI-X"); > > + udev->info.irq_flags = IRQF_NO_THREAD; > > IRQF_NO_THREAD seems has been introduced in 2.6.39, so using this flag > causing build error for kernel versions < 2.6.39. > > btw, the flag is already in use, so issue is not related to this patch. > > In DPDK documentation supported Linux kernel version is >= 2.6.34 [1]. > > We should either increase supported version to 2.6.39, or update igb_uio > code. > > I am for increasing minimum supported kernel version to 2.6.39, any > objection / comment? > > 2.6.39 released on May 2011 > 2.6.34 released on May 2010 > > > [1] > http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html#system-software > > > udev->info.irq = pci_irq_vector(udev->pdev, 0); > > udev->mode = RTE_INTR_MODE_MSIX; > > break; > > > >