From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunyang Wu <sunyang.wu@jaguarmicro.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH] ethdev: optimize how the values of the flag variables are assigned
Date: Thu, 8 May 2025 14:34:39 +0900 [thread overview]
Message-ID: <CAOaVG15=NiMUfxtkjPSdQWXKhqJ7x+9n-F1K-LdKpHuSUYnoAQ@mail.gmail.com> (raw)
In-Reply-To: <20250508023334.28416-1-sunyang.wu@jaguarmicro.com>
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
Why bother? This is not critical path.
Original code looked fine
On Thu, May 8, 2025, 11:34 Sunyang Wu <sunyang.wu@jaguarmicro.com> wrote:
> Set the values of the promiscuous and all_multicast variables
> according to the return value.
>
> Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
> ---
> lib/ethdev/rte_ethdev.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
> index d4197322a0..b1f593edc4 100644
> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -3044,10 +3044,8 @@ rte_eth_promiscuous_disable(uint16_t port_id)
> if (dev->dev_ops->promiscuous_disable == NULL)
> return -ENOTSUP;
>
> - dev->data->promiscuous = 0;
> diag = dev->dev_ops->promiscuous_disable(dev);
> - if (diag != 0)
> - dev->data->promiscuous = 1;
> + dev->data->promiscuous = (diag == 0) ? 0 : 1;
>
> diag = eth_err(port_id, diag);
>
> @@ -3112,10 +3110,9 @@ rte_eth_allmulticast_disable(uint16_t port_id)
>
> if (dev->dev_ops->allmulticast_disable == NULL)
> return -ENOTSUP;
> - dev->data->all_multicast = 0;
> +
> diag = dev->dev_ops->allmulticast_disable(dev);
> - if (diag != 0)
> - dev->data->all_multicast = 1;
> + dev->data->all_multicast = (diag == 0) ? 0 : 1;
>
> diag = eth_err(port_id, diag);
>
> --
> 2.19.0.rc0.windows.1
>
>
[-- Attachment #2: Type: text/html, Size: 2162 bytes --]
next prev parent reply other threads:[~2025-05-08 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 2:33 Sunyang Wu
2025-05-08 5:34 ` Stephen Hemminger [this message]
2025-05-08 6:26 ` 回复: " Sunyang Wu
2025-05-08 8:17 ` Morten Brørup
2025-05-20 15:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOaVG15=NiMUfxtkjPSdQWXKhqJ7x+9n-F1K-LdKpHuSUYnoAQ@mail.gmail.com' \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=sunyang.wu@jaguarmicro.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).