From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B139146771; Sat, 17 May 2025 13:09:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 445B74042F; Sat, 17 May 2025 13:09:45 +0200 (CEST) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by mails.dpdk.org (Postfix) with ESMTP id 97E22402E5 for ; Sat, 17 May 2025 13:09:43 +0200 (CEST) Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-52c85c0d473so1072749e0c.2 for ; Sat, 17 May 2025 04:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1747480183; x=1748084983; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qVvSwvdWb4+QhiNl/2vo9cTHJ7vIPKhOEOKw5wqUCB4=; b=TvRSOFl5myYXNjPcCGuzJuIEBgG2p0t+Z/kvvi0Gh51LPUEaJY3jvBAyWmdGn+Q7lS bmmnn9HoJahN3C0cKI+QGOtY0D2HgErGoYMLVjkbi5luMFtGW4Y4IbvLzay9LGnvfxVv u8K7TuzbVrV5EHprxSSfXQYK4wRLCcQy0sILG5VnHScaJ1q7L2EMFLTsyZDUbiUjjhkx 6TV+08oayT9TlV2DjVbgkxoLIeII/YE637vpgoC3D41rVrO5Lbi/8VYaJ10Uqz5fFLYO 0qmp2umixUMb3kHLoHShf/PtMIM2AL1UmETn6PivdDhKLw1MVTE81M1ZD01geRvvWTzc RrNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747480183; x=1748084983; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qVvSwvdWb4+QhiNl/2vo9cTHJ7vIPKhOEOKw5wqUCB4=; b=ivjHgMJREqWPUAnLbLU5M8Ew/RulV3Sa/SVil0xk4QJgedJUPtWB/NmRKg7UGvM7WT FzFu7GBLLPih/XAbnm8L8xhilAQVkZhQ/5yQNiAWUBRYqLVQoccO6xIgYBIxHc7+FBt6 XCOgDeoDxQWRaxejGEyZKopAC/kk45j0j9eGL53650pkkx385vUr56mpEIpokkxotUGk s/ggfHWdgRg8h9CtdOnVPgx9BI5QZTYqIwfiwAc2pOpfpcHflnJKBlfUjGTX37uO/VnM Qu4OPNOREaseMUbZV2XuxuIcSHamD5reeI6J7HavXNcyIykGc0zESv0WiUP/9osR0y3F aaEg== X-Gm-Message-State: AOJu0YwMoP5nomjNEqhJWKSw2uUZRocoHBs+BIOnQOAwCVwYm8ogaAp5 fG2uX54d0PqUrR2DbD9LPKD7QGHoLCb3WEtHiKmx9+0RuykUEatuc5cg+LJRxVy9sIyPebt9zkE esCmC5k6MotnMKb0LB8XaWWNKhDgPDP+/N3hFKSl1LHV/WcXWvZVpmK03PA== X-Gm-Gg: ASbGncsKPKSV4T0IIO0nZc+nMVVtGUhomjceFX2DQwbR6M52Z1dQ37j44LH+h20C9d6 vpqMJGLaWPjPguS4CedpXug4Htc6QL3Ecvm3TSAhtXlLHMD4IOsTSU4NRnZPiRIsvfSG2QMEflB PMgpaqua9/L8u8fDjlYQAEMl1qSLRIjeN2/Db+Bno13/Kiaw== X-Google-Smtp-Source: AGHT+IE9LldE195WjihrYEs1xgcNG6zIDvhQlfd/nEXrIighwWzzXu9AVDBBOI0xs7VtlNzmq5vIVLHwxO3mJKfzBoM= X-Received: by 2002:a05:6122:4085:b0:52a:bf98:55b with SMTP id 71dfb90a1353d-52dba83b131mr7315275e0c.3.1747480182726; Sat, 17 May 2025 04:09:42 -0700 (PDT) MIME-Version: 1.0 References: <1733281010-23780-1-git-send-email-andremue@linux.microsoft.com> <1747428335-3736-1-git-send-email-andremue@linux.microsoft.com> <1747428335-3736-2-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1747428335-3736-2-git-send-email-andremue@linux.microsoft.com> From: Stephen Hemminger Date: Sat, 17 May 2025 20:09:32 +0900 X-Gm-Features: AX0GCFvE6SjZomI0D1KKxNMPva2D3cVVx8l9HEmf5lDdOl831hywEOD98Yv_Xk0 Message-ID: Subject: Re: [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion To: Andre Muezerie Cc: dev , "Medvedkin, Vladimir" Content-Type: multipart/alternative; boundary="0000000000008b3e5e063552efe4" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008b3e5e063552efe4 Content-Type: text/plain; charset="UTF-8" Ok. Wonder if RTE_PTR_ADD should have the cast there instead On Sat, May 17, 2025, 05:45 Andre Muezerie wrote: > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The fix is to cast (1) explicitly to uintptr_t since it is used > in pointer arithmetic. > > Signed-off-by: Andre Muezerie > --- > lib/fib/trie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/fib/trie.c b/lib/fib/trie.c > index 6c20057ac5..24a08b827d 100644 > --- a/lib/fib/trie.c > +++ b/lib/fib/trie.c > @@ -338,7 +338,7 @@ write_edge(struct rte_trie_tbl *dp, const uint8_t > *ip_part, uint64_t next_hop, > if (ret < 0) > return ret; > if (edge == LEDGE) { > - write_to_dp((uint8_t *)p + (1 << dp->nh_sz), > + write_to_dp(RTE_PTR_ADD(p, (uintptr_t)(1) << > dp->nh_sz), > next_hop << 1, dp->nh_sz, UINT8_MAX - > *ip_part); > } else { > write_to_dp(get_tbl_p_by_idx(dp->tbl8, tbl8_idx * > -- > 2.49.0.vfs.0.3 > > --0000000000008b3e5e063552efe4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok.
Wonder if RTE_PTR_ADD should have th= e cast there instead=C2=A0

On Sat, May 17, 2025,= 05:45 Andre Muezerie <a= ndremue@linux.microsoft.com> wrote:
MSVC issues the warning below:

../lib/fib/trie.c(341): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

The fix is to cast (1) explicitly to uintptr_t since it is used
in pointer arithmetic.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
=C2=A0lib/fib/trie.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fib/trie.c b/lib/fib/trie.c
index 6c20057ac5..24a08b827d 100644
--- a/lib/fib/trie.c
+++ b/lib/fib/trie.c
@@ -338,7 +338,7 @@ write_edge(struct rte_trie_tbl *dp, const uint8_t *ip_p= art, uint64_t next_hop,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ret < 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 return ret;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (edge =3D=3D LED= GE) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0write_to_dp((uint8_t *)p + (1 << dp->nh_sz),
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0write_to_dp(RTE_PTR_ADD(p, (uintptr_t)(1) << dp->nh_sz),=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 next_hop << 1, dp->nh_sz, U= INT8_MAX - *ip_part);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 write_to_dp(get_tbl_p_by_idx(dp->tbl8, tbl8_idx *
--
2.49.0.vfs.0.3

--0000000000008b3e5e063552efe4--