From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5800243746; Tue, 19 Dec 2023 17:55:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 443EC42E11; Tue, 19 Dec 2023 17:55:35 +0100 (CET) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by mails.dpdk.org (Postfix) with ESMTP id A4FCA42DED for ; Tue, 19 Dec 2023 17:55:33 +0100 (CET) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5532b348d30so3416401a12.1 for ; Tue, 19 Dec 2023 08:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1703004933; x=1703609733; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iPtnSbLSgRFUFfPnOa9Qzto7FwsTQfYnGFPNa16YWXY=; b=NnW8dsDiZCMyHEG1NF12GCMqXtTbhLdafi+D1XSNUYYXmat+d6bPYuNkaDH0IwOH34 jFmeoZDcXbWWpwQccaYk6IT5yeiev1HiCrRQEiTh0x0sCZYdN+bGPDH+QeHsfd7P73HM CQhKbRNeW2yGu2Ip/mzTO8ZvSGF8rV0jdAw50UYefaFUzIjbGJoTe4Y7FebdMBNpr1YU cbRGN+/rbvP+CXVNKer+59O5t1frGrolhJFtsGe7jUs8GiSCYSx7tXzf6OW0FNaYOlyN F/iH2DssMDaMfiBGTw/1/+nrPiaEtRX7x42dcrp27d/TQJSxaHLdTVHSv1pEuzojeGkh J0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703004933; x=1703609733; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iPtnSbLSgRFUFfPnOa9Qzto7FwsTQfYnGFPNa16YWXY=; b=IcQ51fD6lSGBELuCg0mip1qH8/BsyaIpe8V5JaLEZLbi6KSb7ItYuApn6qd1A4d22V oRGIxGR4By7Ced34juyBPxWftE4wpzCUGAjkdnLvfI8H9cbxTMVSJhtsFeuPPyk6JZtO N5st/dPpDDPbJSmsIOYLY1kCxOIg0yNoolMdw4gc+Z9rzklPGSrlhUG+2JqaKzQc5/ZD mx033elXFJt1hUUwkBSgmBaScKnrqOhvhR8lfGVNaoGHDXF1+PCqLZiGc6lB0VgmvIPD ZAwhkOD23RZoRE8FEeC1e+jIT/qAf/r06pcD3dCTTIXel9awZazE0nqCgcGnx04VPl1H nx1w== X-Gm-Message-State: AOJu0YxPv4vF5k5/BE+LE/Ituxknpyxkfo6Z1uDDPvntJ8I34iwb/eJS Wj3c5ToVvUsBdIUuEesNhhjNWncSzd7Huhhu+SYLLThAk866Qx30v5RwXg== X-Google-Smtp-Source: AGHT+IGJMNS/nEEWeaBx/NOHudeSquJfJPy1QLP3V2xqFWjnnHatMBVFcHQaLVXSxmdJmtJo8KMotL/AdgRW4JUHCBk= X-Received: by 2002:a17:906:4b10:b0:a23:6c61:9b87 with SMTP id y16-20020a1709064b1000b00a236c619b87mr1111860eju.142.1703004933309; Tue, 19 Dec 2023 08:55:33 -0800 (PST) MIME-Version: 1.0 References: <20231218181221.10057-1-jspewock@iol.unh.edu> <20231218181221.10057-5-jspewock@iol.unh.edu> In-Reply-To: <20231218181221.10057-5-jspewock@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Tue, 19 Dec 2023 17:55:22 +0100 Message-ID: Subject: Re: [PATCH v4 4/7] dts: add pci addresses to EAL parameters To: jspewock@iol.unh.edu Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Juraj Linke=C5=A1 On Mon, Dec 18, 2023 at 7:13=E2=80=AFPM wrote: > > From: Jeremy Spewock > > Added allow list to the EAL parameters created in DTS to ensure that > only the relevant PCI devices are considered when launching DPDK > applications. > > Signed-off-by: Jeremy Spewock > --- > dts/framework/testbed_model/sut_node.py | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/test= bed_model/sut_node.py > index 9c92232d9e..77caea2fc9 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -20,6 +20,7 @@ > from framework.utils import MesonArgs > > from .hw import LogicalCoreCount, LogicalCoreList, VirtualDevice > +from .hw.port import Port > from .node import Node > > > @@ -31,6 +32,7 @@ def __init__( > prefix: str, > no_pci: bool, > vdevs: list[VirtualDevice], > + ports: list[Port], > other_eal_param: str, > ): > """ > @@ -46,6 +48,7 @@ def __init__( > VirtualDevice('net_ring0'), > VirtualDevice('net_ring1') > ] > + :param ports: the list of ports to allow. > :param other_eal_param: user defined DPDK eal parameters, eg: > other_eal_param=3D'--single-file-segments' > """ > @@ -56,6 +59,7 @@ def __init__( > self._prefix =3D f"--file-prefix=3D{prefix}" > self._no_pci =3D "--no-pci" if no_pci else "" > self._vdevs =3D " ".join(f"--vdev {vdev}" for vdev in vdevs) > + self._ports =3D " ".join(f"-a {port.pci}" for port in ports) > self._other_eal_param =3D other_eal_param > > def __str__(self) -> str: > @@ -65,6 +69,7 @@ def __str__(self) -> str: > f"{self._prefix} " > f"{self._no_pci} " > f"{self._vdevs} " > + f"{self._ports} " > f"{self._other_eal_param}" > ) > > @@ -294,6 +299,7 @@ def create_eal_parameters( > append_prefix_timestamp: bool =3D True, > no_pci: bool =3D False, > vdevs: list[VirtualDevice] =3D None, > + ports: list[Port] | None =3D None, > other_eal_param: str =3D "", > ) -> "EalParameters": > """ > @@ -317,6 +323,7 @@ def create_eal_parameters( > VirtualDevice('net_ring0'), > VirtualDevice('net_ring1') > ] > + :param ports: the list of ports to allow. > :param other_eal_param: user defined DPDK eal parameters, eg: > other_eal_param=3D'--single-file-segments' > :return: eal param string, eg: > @@ -334,12 +341,16 @@ def create_eal_parameters( > if vdevs is None: > vdevs =3D [] > > + if ports is None: > + ports =3D self.ports > + > return EalParameters( > lcore_list=3Dlcore_list, > memory_channels=3Dself.config.memory_channels, > prefix=3Dprefix, > no_pci=3Dno_pci, > vdevs=3Dvdevs, > + ports=3Dports, > other_eal_param=3Dother_eal_param, > ) > > -- > 2.43.0 >