From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4D1A4292F; Thu, 13 Apr 2023 08:50:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B26E40A84; Thu, 13 Apr 2023 08:50:38 +0200 (CEST) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by mails.dpdk.org (Postfix) with ESMTP id 84AAB4021F for ; Thu, 13 Apr 2023 08:50:37 +0200 (CEST) Received: by mail-ej1-f50.google.com with SMTP id qb20so34413978ejc.6 for ; Wed, 12 Apr 2023 23:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20221208.gappssmtp.com; s=20221208; t=1681368637; x=1683960637; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pv8ivdUqAM8eTvO5R6KMIMxoAcyu3bdxlqEZibtLJyU=; b=ZD6gzVPVO0Dn9AbepP9qf/vVK04Waa3c+1V5qVprYLW8PrFZLuxQlAoW7ca6XtmqaB XMkT4defZ7A790cYw3mPTAiLT9DiISgmq2v65t1pRqNiBZYKRZhlm58ybmoNIGfJlt51 Y/U4tgS4Fk8+I5ol0kS3BThnS8JTX+KjDdLkPFqA/i5jRCKEbpKoid2lRmckLfXpBnx7 /Em7MOAoIkk2kvTHLyVEbTrj303bt1LpxQsbp/0q1AAXQdxV1kjjPdI6NOxw6OFHMdrb 1rGBqUvVHqTKL6M+MJpFs6+ijmjlbmWI02oIZj1S4m3HJhxkZtdO6fJ85b/j3ADYSQNU GDoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681368637; x=1683960637; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pv8ivdUqAM8eTvO5R6KMIMxoAcyu3bdxlqEZibtLJyU=; b=GEd0jnDsUrDriAkuq1W5+q5w52gHQ/qQbs3oZ7WSHILL88Yi8RTBH8D0MvWL0EE4p4 RQrQ4O0nzP0w4KeC5PMEShbIfRs+UEKl+lN3elweWvgmUyTY5bSTdMHvLenW8HdD3SxJ i6kmg4ifSlF7bgZKn3fU375XpExB/b5l1Epi27Qk2LwFHjPgsDXlM2kg1eMFHSAjvS40 dAUYjLgr+vYnjJHS/Cz24lwmG0fa/l0b7cwznf6//Gb2UOgfzf7zO0QzQ1UbnOy+9GBF lhUvf8uK3SLBBNMgF8cp+S3B6n3UknQbpKkalQgYxxAC/KP2PXILjqwMieompSbgCwsJ BwCQ== X-Gm-Message-State: AAQBX9e9lmi30BU5OkxDyzILkt4sWkX5bzHJVHFvtXqSK5Ql1Vm4yFGh ADJjhob8vwKcaY3OoaGERyAp50WDTTEHSdm+jDmSOA== X-Google-Smtp-Source: AKy350agPjM09n4/AMKYNhu5dHo5+AHs65eRzVnO5Puev4R4TVp7EUJnYsQY4On1QM/fxtgKssSOT1A0mQAHnp/HdVg= X-Received: by 2002:a17:906:b796:b0:94a:5615:fbbd with SMTP id dt22-20020a170906b79600b0094a5615fbbdmr733070ejb.15.1681368637140; Wed, 12 Apr 2023 23:50:37 -0700 (PDT) MIME-Version: 1.0 References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5667444.DvuYhMxLoT@thomas> <3228692.44csPzL39Z@thomas> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Thu, 13 Apr 2023 08:50:26 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] dts: fabric requirements To: Honnappa Nagarahalli Cc: "thomas@monjalon.net" , Wathsala Wathawana Vithanage , "jspewock@iol.unh.edu" , "probb@iol.unh.edu" , "lijuan.tu@intel.com" , "bruce.richardson@intel.com" , "dev@dpdk.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 12, 2023 at 5:38=E2=80=AFPM Honnappa Nagarahalli wrote: > > > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, April 12, 2023 10:25 AM > > To: Juraj Linke=C5=A1 > > Cc: Wathsala Wathawana Vithanage ; > > jspewock@iol.unh.edu; probb@iol.unh.edu; Honnappa Nagarahalli > > ; lijuan.tu@intel.com; > > bruce.richardson@intel.com; dev@dpdk.org > > Subject: Re: [PATCH v1 1/2] dts: fabric requirements > > > > 12/04/2023 15:42, Juraj Linke=C5=A1: > > > On Tue, Apr 11, 2023 at 4:48=E2=80=AFPM Thomas Monjalon > > wrote: > > > > > > > > 04/04/2023 13:51, Juraj Linke=C5=A1: > > > > > On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon > > wrote: > > > > > > > > > > > 03/04/2023 16:56, Juraj Linke=C5=A1: > > > > > > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > > > > > > Replace pexpect with Fabric. > > > > > > > > > > > > > > > > You should squash these lines with the move to Fabric. > > > > > > > > > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > > > > > > --- > > > > > > > > > dts/poetry.lock | 553 > > > > > > +++++++++++++++++++++++++++++++++++++++------ > > > > > > > > > > > > > > > > Do we really need *all* these lines? > > > > > > > > I see a lot of lines about Windows and MacOSX which are not > > > > > > > > supported > > > > > > in > > > > > > > > DTS. > > > > > > > > It is so long that it looks impossible to review. > > > > > > > > > > > > > > > > > > > > > > > This is a generated file and doesn't need to be reviewed. > > > > > > > > > > > > In general, I don't like storing generated files. > > > > > > > > > > > > > > > > Me neither, but this one is specifically designed to be stored in > > > > > a > > > > > repository: > > > > > https://python-poetry.org/docs/basic-usage/#commit-your-poetryloc= k > > > > > -file-to-version-control > > > > > > > > > > > > > > > > > > > > > > > I separated the > > > > > > > dependencies part so that the code part is easier to review. > > > > > > > If you > > > > > > want, I > > > > > > > can squash the two commits. > > > > > > > > > > > > What happens if we manually remove the useless lines? > > > > > > > > > > > > > > > > > The lock file is there so that everyone installs exactly the same > > > > > versions of dependencies. We can specify the versions of > > > > > dependencies in pyproject.toml, but we won't control the versions > > > > > of dependencies of dependencies this way. If we remove the change= s > > > > > to the lock file, then we won't be storing tested versions, > > > > > everyone would be using slightly different versions and we may > > > > > potentially need to address versioning issues in the future - bes= t to prevent > > that with a lock file. > > > > > > > > You didn't answer about removing the usuless lines, like unneeded W= indows > > support. > > > > > > > > > > Do you mean the list of files from macos and windows? I tried removin= g > > > those from mypy and testing it and it looks like it didn't have an > > > impact, but I don't know the inner workings of poetry and the lock > > > file to test it properly (i.e. to rule out any breakages). What would > > > be the reason for removing those? Seems like it has more downsides (w= e > > > could potentially break something and it's extra work) than updsides > > > (as this is a generated file, I don't really see any). > > > > Yes this is what I mean. > > Any other opinion? > > > If it is a generated file, there might be an expectation from the tool th= at the file is not changed. It would be good to understand this. > > Since it is a generated file, should we generate this during DTS run time= rather than storing a generated file? > The file is not used during runtime, but rather when installing dependencies. It's supposed to be generated by maintainers (once every time dependencies change or need updating) who verify the versions defined in the generated lockfile so that everyone then uses the same versions from that point on, preventing issues arising from different users using different versions of dependencies. So it's maintainers giving this file to other people. Juraj