From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3356E4366A; Mon, 4 Dec 2023 10:53:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD2E440294; Mon, 4 Dec 2023 10:53:15 +0100 (CET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mails.dpdk.org (Postfix) with ESMTP id C1D3D4028C for ; Mon, 4 Dec 2023 10:53:13 +0100 (CET) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so584234466b.1 for ; Mon, 04 Dec 2023 01:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1701683593; x=1702288393; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s+UO8vUI4ihelN5fn5K+LbV96w1NptO1DjH9uNZfSkk=; b=Ha8xqLtnDxTUBiSuLu3lSOIgQewmdQ1wb3WaGF0IKi/qDyrHzZg2VDgmHAcuJRevbF CUSxm70cnbI8k6Leul4V798WTWOCrvDVcwoUJ/F8G5Oc1ou9UiqA0u7jssoqDPsi6d+f svqv884RZNNR14KsP0Wc1d6OeGfnJm6vODO2tsSgqTsupyJsNKeG4AncsuQYAkvaYoF5 MTO2lTVVi3mA2nflo6wtyFQOl+f08b+YnaFN+igZcmxqpaH4MVJuRsmq09S3x0cBDU0n HI4ZKcAqbTj0u+p/VYtSBk+wPHCeb1CZoxgEBsNDw50+xmpGWMTlfzXijV8UCiSL1pLy wuTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701683593; x=1702288393; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s+UO8vUI4ihelN5fn5K+LbV96w1NptO1DjH9uNZfSkk=; b=h/fN4M+B3sDReHVTsV/LKflDpDhuDc+NP5B5DiMozBrM/zMCLF3UR+e+9dWoOa4dsg uHacW3eNDJd8yotfB0BwENc+Y7eawBxZCYl5oAEeviHyg1B1TKJhFuo1MhDsDF2stxgl FBp3K3InZLh0NicsbLF2KB4yiAr2LMjq8dx6XPaC82Fddr1Ew3wRjuikUyEYj6w/WoJQ t16MXbDFi2UMfOPOq3o7d92r51UWRT1kp0ay4/duiICH6La4Fx/IRUhzAHCOwOCf39TB XpC1DY5yJg31yQkx/XLfQwzJPQW7ZPJ5KOBNxTSsoM96YcHEDNo8KL/QaTtXaniQknHh 73Dg== X-Gm-Message-State: AOJu0Yxm2hLBmGUqi0bPD9kjmgI7S+eCi2vSFptVmhprNaZ9ArrL98hK 0HNTg5oz7l94e9yjgYHzolYSddRSG1BJemSzfFm3hw== X-Google-Smtp-Source: AGHT+IGAXFG1H1+RBfTbssej8Ypjy6cFHJzeyNl8wYScEVZ2LjALrQicQcGD9DWG2wb9F0ezuqC+bdZZ3H7vPu8E1lM= X-Received: by 2002:a17:906:748d:b0:a18:35e2:de31 with SMTP id e13-20020a170906748d00b00a1835e2de31mr3064284ejl.63.1701683593539; Mon, 04 Dec 2023 01:53:13 -0800 (PST) MIME-Version: 1.0 References: <20231115130959.39420-1-juraj.linkes@pantheon.tech> <20231123151344.162812-1-juraj.linkes@pantheon.tech> <20231123151344.162812-16-juraj.linkes@pantheon.tech> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 4 Dec 2023 10:53:02 +0100 Message-ID: Subject: Re: [PATCH v8 15/21] dts: os session docstring update To: Jeremy Spewock Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, Luca.Vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >> diff --git a/dts/framework/testbed_model/os_session.py b/dts/framework/testbed_model/os_session.py >> index 76e595a518..cfdbd1c4bd 100644 >> --- a/dts/framework/testbed_model/os_session.py >> +++ b/dts/framework/testbed_model/os_session.py >> @@ -201,69 +283,119 @@ def build_dpdk( >> rebuild: bool = False, >> timeout: float = SETTINGS.compile_timeout, >> ) -> None: >> - """ >> - Build DPDK in the input dir with specified environment variables and meson >> - arguments. >> + """Build DPDK on the remote node. >> + >> + An extracted DPDK tarball must be present on the node. The build consists of two steps:: >> + >> + meson setup remote_dpdk_dir remote_dpdk_build_dir >> + ninja -C remote_dpdk_build_dir >> + >> + The :option:`--compile-timeout` command line argument and the :envvar:`DTS_COMPILE_TIMEOUT` >> + environment variable configure the timeout of DPDK build. >> + >> + Args: >> + env_vars: Use these environment variables then building DPDK. > > > I think this is meant to be "when building DPDK" instead. > Yes, good catch.