From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E20EC44101; Wed, 29 May 2024 12:30:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C69F2402CD; Wed, 29 May 2024 12:30:35 +0200 (CEST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mails.dpdk.org (Postfix) with ESMTP id 315FC402B9 for ; Wed, 29 May 2024 12:30:34 +0200 (CEST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a63036f2daaso231894666b.1 for ; Wed, 29 May 2024 03:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1716978634; x=1717583434; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OYw/pbng747XiBXfYa5Ag6lEUg0tnhOUnJ0wWWjFX3E=; b=FElyD8AgyVJn/i1I3Tqq0zzpXdw+rY9JqNmB9TImLxae6Jl/tKApFOywhtCb3Ez4Tw 1xtsf/o5yQxdENs162JCmuceJcb0JMevYee2KyqCMiMOI8EGSuwQHeVcPkw6ohfgYewE ACY6UMUlQ0uKkzFYGFw4VX3dy49eUl4QL+vdD1qg3NyZK6imI8kSBwOS77bLu/x423lN kVzVRHRzAS/dTRTvwd0ydc2mWj57ZA4OXHMNJ34cDsVlgjtaEj4DNv0QGEOZa0dvCui2 F4P6lLu9sNt6SwdF+mIN2FLnYSFSrTjiiOjDFuGdGPC8zLNwVsuz+EeA2FL2JLSD1IGb B64Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716978634; x=1717583434; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OYw/pbng747XiBXfYa5Ag6lEUg0tnhOUnJ0wWWjFX3E=; b=XCMnyRkaNAabWtljiF93u5IeT8HkZS09scKCvzSxc0rGcmCjvfyPraLDEAKNQnD8eC tOqxximtLdgiQ66wyvMCFA+bP9Qgz6VytIY0h7Ab/hUc/u8lwKu+cO4chJU+bXXInrY/ nyruh3M3pZTxiZh5I2TbF5YXlhGTJKLVhbFl2wDrS7zC4MaIOpU+OiFdbEPtyMxTZ8Ob Px1EOESsEwf/3zjkFLOVLYATaks/4IT/66rMmkupkadSaHn0SHfgy2x3IIHjP8bP5l7x il+nFbQdC7od2ZCdavyA+OrGkCT1hHW18NptpeqkoKZzfGcr3gFrLKrLlCkY9nb6bsug OAZg== X-Forwarded-Encrypted: i=1; AJvYcCW7qz4GWmrjmNycR47iospwZA/i2jZjPQW7Lx+KaICx3YT2nkVKerSjLTohgkxxmV5fP8E7wuJ5fDGrrm4= X-Gm-Message-State: AOJu0YwuNcXlTI04mGUVp8Z08h0ulPz54zjrfGvRGaeRhKfzRd8fTQdK rbq822gg9TpmQxk5zhQOKMp2vC+tyDHJ6MKNr/wv0ZwtlgBx4J0xBarEN2BliFmhuuFl/rK7smu xPQmqZSGt0RSiCoM8r2yGtYDu0cNdk8gCJqxz7A== X-Google-Smtp-Source: AGHT+IGzpo9T8Dn908kIjZaW1edlgTKsbNPM24mBFfrUzqorJd/GyPlgSrkt7t2EGfX/FkAjhNh6lUYEVpS9JtEYivk= X-Received: by 2002:a17:906:fcb7:b0:a59:c209:3e33 with SMTP id a640c23a62f3a-a62642daa9emr998427366b.15.1716978633694; Wed, 29 May 2024 03:30:33 -0700 (PDT) MIME-Version: 1.0 References: <20240430184533.29247-4-npratte@iol.unh.edu> <20240507174430.29403-1-npratte@iol.unh.edu> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 29 May 2024 12:30:22 +0200 Message-ID: Subject: Re: [PATCH v6 0/2] Methodology change for hugepage configuration To: Nicholas Pratte Cc: probb@iol.unh.edu, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, mb@smartsharesystems.com, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 15, 2024 at 4:50=E2=80=AFPM Nicholas Pratte wrote: > > >What's the difference between this version and v4? > > Version 5 was a response to your suggestions regarding the semantics > of the hugepage variable names as it relates to countable or > uncountable nouns. This patch, which was originally just a single > patch, was expanded into a patch series since the variable changes > suggested are sort of logically independent of the original patch; > there were talks about potentially making this a separate patch > entirely, but we agreed that a patch series for this change is > appropriate. > Ah, ok. There were a lot of patches so that confused me. > But, to answer a question that I think you are indirectly asking, I > ran into some issues when sending out the latest version of this > patch. While the latest version of this patch, version 6, was sent > last week and does show up on patchwork, it seems like the emails > never reached the mailing list for some (I just asked Patrick in the > office and he cannot seem to find them). > > > "type": "object", > > "description": "Optional hugepage configuration. If not specified= , hugepages won't be configured and DTS will use system configuration.", > > "properties": { > >- "amount": { > >+ "quantity": { > > "type": "integer", > >- "description": "The amount of hugepages to configure. Hugepag= e size will be the system default." > >+ "description": "The number of hugepages to configure. Hugepag= e size will be the system default." > > }, > > "force_first_numa": { > > "type": "boolean", > > The only change that version 6 made is in reference to the suggestion > that Bruce made in a separate thread; I changed the description text > from "amount of" to "number of." > As you mentioned in the other thread, I also like changing it in all instances (in code and conf.yaml). > Hopefully this answers your question. Again, I ran into some issues > sending the latest version out for this patch > > On Mon, May 13, 2024 at 5:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > > > What's the difference between this version and v4? > > > > On Tue, May 7, 2024 at 7:44=E2=80=AFPM Nicholas Pratte wrote: > > > > > > In order to prevent accidental misconfiguration of hugepages at runti= me, > > > the following changes are made to only allow for configuration of 2MB > > > hugepages within the DTS config.yaml. In the previous implementation,= a > > > default hugepage size was selected via the size listed in /proc/memin= fo. > > > The problem with this implementation is that, assuming the end-user h= as > > > made prior modifications to the system, /proc/meminfo may default to > > > hugepage sizes that are not recommended to be configured at runtime > > > (i.e. 1GB hugepages). This can lead to two problems: overallocation o= f > > > hugepages (which may crash the remote host) configuration of hugepage= s > > > sizes that are not recommended during runtime. In this new implementa= tion, > > > we stipulate that any runtime hugepage configuration size that is not= 2MB > > > is considered an outlier. If the end-user would like to configure eit= her > > > 1GB hugepages or any unique hugepage size outside of 2MB, then they s= hould > > > make these configurations either at startup (in the case of 1GB hugep= ages) > > > or runtime outside of DTS configuration (if a user would like hugepag= es > > > that are not 2MB). In either case, the expectation is that, if wish t= o > > > use hugepage sizes that are not 2MB, you will make these changes outs= ide > > > and prior to the initialization of DTS. > > > > > > The end-user has two options: remove the option for hugepage > > > configuration in the conf.yaml, or keep the option and specify the > > > amount of 2MB hugepages desired. In the case of the former, then we a= ssume > > > that hugepages are already configured prior to DTS initialization. In > > > the latter case, the user must define the amount of 2MB hugepages to = be > > > configured at runtime. If the amount of 2MB hugepages requested excee= ds > > > the amount of 2MB hugepages already configured on the system, then th= e > > > system will remount hugepages to cover the difference. If the amount = of > > > hugepages requested is either greater than or equal to the amount > > > already configured on the system, then nothing is done. > > > > > > Nicholas Pratte (2): > > > dts: Change hugepage runtime config to 2MB Exclusively > > > dts: Change hugepage 'amount' to a different term > > > > > > doc/guides/tools/dts.rst | 6 ++++- > > > dts/conf.yaml | 8 +++--- > > > dts/framework/config/__init__.py | 8 +++--- > > > dts/framework/config/conf_yaml_schema.json | 12 ++++----- > > > dts/framework/config/types.py | 4 +-- > > > dts/framework/testbed_model/linux_session.py | 28 +++++++++++-------= -- > > > dts/framework/testbed_model/node.py | 4 ++- > > > dts/framework/testbed_model/os_session.py | 7 ++++- > > > 8 files changed, 45 insertions(+), 32 deletions(-) > > > > > > -- > > > 2.44.0 > > >