Re: [PATCH v2 1/2] dts: update mypy static checker

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

On Tue, May 28, 2024 at 2:00 PM Luca Vizzarro <Luca.Vizzarro@arm.com> wrote:
>
> On 24/05/2024 15:51, Patrick Robb wrote:
> > I think this is fine. Another option would be to move sut_nodes and
> > tg_nodes up as DTSRunner attributes.

This is a good suggestion. Everything in DTSRunner is tied to a
particular execution/build target or test suite, except for nodes.
That means they should be instance attributes.

> > I like preserving the type hint,
> > but it also might just be cluttering the code to do this... up to you.
>
> I made the change because of a complaint coming from mypy...
> I think it was complaining that the function is not being type checked?
>

I think it's just saying it's not doing type checks in the untyped
function (the function being run()). We should it make typed:
def run(self) -> None:

When the method is typed, Mypy actually requires the node types.

> The other solution was to add a mypy ignore attribute.