From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 997D944101; Wed, 29 May 2024 12:58:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A964402CD; Wed, 29 May 2024 12:58:36 +0200 (CEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mails.dpdk.org (Postfix) with ESMTP id 354B0402B9 for ; Wed, 29 May 2024 12:58:35 +0200 (CEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-578517c7ae9so2329525a12.3 for ; Wed, 29 May 2024 03:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1716980315; x=1717585115; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rBspJS3x4KpHG5+kRGzrJHKg2pLUXGt0k0ppwO0VsuY=; b=tP/Or/8Wd59UK1NrfaVN8L/fx7G6Vf9kyFe3Kzzu2N5+2+G8zzv2lgRwWuJ2fKu1yR +X8kenUfhM6MCY38Ob2hL5WXoVb5bpjMxkNp+F0rjFIVelgXudzitWDOjNtRvUDMsNEX WmlVal/ft+rZuifGOXZGA4sUw8tSFJslCKzoNpIBJ3zWDzedW1w30tF3qIwKQ/fkcV6J gLXBqLj0W93z0KbDfZfSSQbiR3AWLctNefZdMCptgNMyPJ/vWjRBeF/FRBVliXN7Bxgb BoT0wFE2WoSTR9Of+5webGBOnok7rBTJPKAR69SEsv3L+QMXo1ZeubeS85VqeT4wFslk FepQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716980315; x=1717585115; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rBspJS3x4KpHG5+kRGzrJHKg2pLUXGt0k0ppwO0VsuY=; b=wDKjwmRbVzn5WKOQR4c9qqK2NY+Os4BiqKZBDu13JizOq+b7mxucacn6YtBbbjwXD7 ZXrzE+RanSI/00hNK6LNkEz1vJHLxxyxUSrJaaLlHnFuy0GWF21KJAdJFz1bGxqNP8x0 waVOR+ias+oXE7AGk/Li/QZI9JbSo1wWQO1+NLOi/mXv/CcOrc0FRHipo90dGKCTil3A ycZDlGv1g2ACo43P9lOZdBHitOz8guijh5cAe6W9wELYyzY2s1IT/TI3YrpGnc2FdwLe xWwu0JvK6SD4e0ieTCFAqyiZatimRJ/CCX/Glq5dq7cs5kQ4twSxXfmEBPHI+4TlFPeW KDjA== X-Forwarded-Encrypted: i=1; AJvYcCVkYIRFZswCflBR5fMfI07U8f4a3/+k+Y0md7rQeqwREGaMxCiVLnJGs/hoxjBR7LYzFfrjRBbJRqPfVn4= X-Gm-Message-State: AOJu0YzfnXvjX0bMhaoE4bhqeTDGXYQcLu79USbPVI1GDiFxBFqyiNKd hWxsrET4orTRnK2Nms+/xIayj8y1o5QlkEM8D2NaYHbMW9btyw2zAL3IM0c9oqbjMpdKLQNS5pV EIy4PdhupF/Qeigv+Lp+UglP9rD8YXyZ0Mj5FAQ== X-Google-Smtp-Source: AGHT+IGIv4hBHu0vtFSiClTyW6XQ3guFo8uTGudemHItQQXnJeqRd+Tn+ISL9z6XdCx8QiAOz20u9OHSVIDeIcpzIQ0= X-Received: by 2002:a17:906:fa0f:b0:a59:ae57:1660 with SMTP id a640c23a62f3a-a62642d6185mr962346066b.32.1716980314685; Wed, 29 May 2024 03:58:34 -0700 (PDT) MIME-Version: 1.0 References: <20240509105704.1162449-1-luca.vizzarro@arm.com> <20240514113446.1948050-1-luca.vizzarro@arm.com> <20240514113446.1948050-2-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 29 May 2024 12:58:23 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] dts: update mypy static checker To: Luca Vizzarro Cc: Patrick Robb , dev@dpdk.org, Jeremy Spewock , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 2:00=E2=80=AFPM Luca Vizzarro wrote: > > On 24/05/2024 15:51, Patrick Robb wrote: > > I think this is fine. Another option would be to move sut_nodes and > > tg_nodes up as DTSRunner attributes. This is a good suggestion. Everything in DTSRunner is tied to a particular execution/build target or test suite, except for nodes. That means they should be instance attributes. > > I like preserving the type hint, > > but it also might just be cluttering the code to do this... up to you. > > I made the change because of a complaint coming from mypy... > I think it was complaining that the function is not being type checked? > I think it's just saying it's not doing type checks in the untyped function (the function being run()). We should it make typed: def run(self) -> None: When the method is typed, Mypy actually requires the node types. > The other solution was to add a mypy ignore attribute.