From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
Paul Szczepanek <paul.szczepanek@arm.com>
Subject: Re: [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError
Date: Thu, 30 May 2024 17:47:43 +0200 [thread overview]
Message-ID: <CAOb5WZZJnQ+73miWQsr_jzY3ebW8_o4Vx_NkkciUGm+fQxG2JQ@mail.gmail.com> (raw)
In-Reply-To: <20240514121023.1957025-4-luca.vizzarro@arm.com>
> diff --git a/dts/framework/exception.py b/dts/framework/exception.py
> index cce1e0231a..50724acdf2 100644
> --- a/dts/framework/exception.py
> +++ b/dts/framework/exception.py
> @@ -2,6 +2,7 @@
> # Copyright(c) 2010-2014 Intel Corporation
> # Copyright(c) 2022-2023 PANTHEON.tech s.r.o.
> # Copyright(c) 2022-2023 University of New Hampshire
> +# Copyright(c) 2024 Arm Limited
>
> """DTS exceptions.
>
> @@ -129,21 +130,27 @@ class RemoteCommandExecutionError(DTSError):
> severity: ClassVar[ErrorSeverity] = ErrorSeverity.REMOTE_CMD_EXEC_ERR
> #: The executed command.
> command: str
> + _command_stderr: str
> _command_return_code: int
>
> - def __init__(self, command: str, command_return_code: int):
> + def __init__(self, command: str, command_return_code: int, command_stderr: str):
I wanted to change the order here as well to command, command_stderr
and command_return_code last. The API change doesn't matter as DTS is
still experimental
> """Define the meaning of the first two arguments.
>
> Args:
> command: The executed command.
> command_return_code: The return code of the executed command.
> + command_stderr: The stderr of the executed command.
And here.
> """
> self.command = command
> self._command_return_code = command_return_code
> + self._command_stderr = command_stderr
And here.
>
> def __str__(self) -> str:
> - """Include both the command and return code in the string representation."""
> - return f"Command {self.command} returned a non-zero exit code: {self._command_return_code}"
> + """Include the command, its return code and stderr in the string representation."""
> + return (
> + f"Command '{self.command}' returned a non-zero exit code: "
> + f"{self._command_return_code}\nStderr: {self._command_stderr}"
> + )
>
>
> class InteractiveCommandExecutionError(DTSError):
next prev parent reply other threads:[~2024-05-30 15:47 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 18:26 [PATCH 0/4] dts: error and usage improvements Luca Vizzarro
2024-01-22 18:26 ` [PATCH 1/4] dts: constrain DPDK source flag Luca Vizzarro
2024-01-29 11:47 ` Juraj Linkeš
2024-02-23 19:09 ` Luca Vizzarro
2024-03-01 10:22 ` Juraj Linkeš
2024-01-22 18:26 ` [PATCH 2/4] dts: customise argparse error message Luca Vizzarro
2024-01-29 13:04 ` Juraj Linkeš
2024-02-23 19:12 ` Luca Vizzarro
2024-02-26 9:09 ` Juraj Linkeš
2024-01-22 18:26 ` [PATCH 3/4] dts: show help when DTS is ran without args Luca Vizzarro
2024-01-22 18:26 ` [PATCH 4/4] dts: log stderr with failed remote commands Luca Vizzarro
2024-01-29 13:10 ` Juraj Linkeš
2024-02-23 19:19 ` Luca Vizzarro
2024-02-26 9:05 ` Juraj Linkeš
2024-03-18 17:17 ` [PATCH v2 0/3] dts: error and usage improvements Luca Vizzarro
2024-03-18 17:17 ` [PATCH v2 1/3] dts: rework arguments framework Luca Vizzarro
2024-04-04 9:25 ` Juraj Linkeš
2024-04-09 15:14 ` Luca Vizzarro
2024-04-10 9:46 ` Juraj Linkeš
2024-03-18 17:17 ` [PATCH v2 2/3] dts: constrain DPDK source argument Luca Vizzarro
2024-03-18 17:17 ` [PATCH v2 3/3] dts: store stderr in RemoteCommandExecutionError Luca Vizzarro
2024-05-14 11:44 ` [PATCH v3 0/3] error and usage improvements Luca Vizzarro
2024-05-14 11:44 ` [PATCH v3 1/3] dts: rework arguments framework Luca Vizzarro
2024-05-14 11:55 ` [PATCH v3] " Luca Vizzarro
2024-05-14 11:44 ` [PATCH v3 2/3] dts: constrain DPDK source argument Luca Vizzarro
2024-05-14 11:44 ` [PATCH v3 3/3] dts: store stderr in RemoteCommandExecutionError Luca Vizzarro
2024-05-14 12:04 ` [PATCH v4 0/3] error and usage improvements Luca Vizzarro
2024-05-14 12:05 ` [PATCH v4 1/3] dts: update mypy static checker Luca Vizzarro
2024-05-14 12:05 ` [PATCH v4 2/3] dts: clean up config types Luca Vizzarro
2024-05-14 12:05 ` [PATCH v4 3/3] dts: rework arguments framework Luca Vizzarro
2024-05-14 12:10 ` [PATCH v5 0/3] error and usage improvements Luca Vizzarro
2024-05-14 12:10 ` [PATCH v5 1/3] dts: rework arguments framework Luca Vizzarro
2024-05-30 15:30 ` Juraj Linkeš
2024-05-30 18:43 ` Luca Vizzarro
2024-05-31 9:04 ` Juraj Linkeš
2024-05-14 12:10 ` [PATCH v5 2/3] dts: constrain DPDK source argument Luca Vizzarro
2024-05-30 15:41 ` Juraj Linkeš
2024-05-30 18:46 ` Luca Vizzarro
2024-05-14 12:10 ` [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError Luca Vizzarro
2024-05-30 15:47 ` Juraj Linkeš [this message]
2024-05-30 18:48 ` Luca Vizzarro
2024-05-14 15:26 ` [PATCH v5 0/3] error and usage improvements Luca Vizzarro
2024-05-31 11:20 ` [PATCH v6 " Luca Vizzarro
2024-05-31 11:20 ` [PATCH v6 1/3] dts: rework arguments framework Luca Vizzarro
2024-05-31 12:49 ` Juraj Linkeš
2024-06-14 13:55 ` Jeremy Spewock
2024-05-31 11:20 ` [PATCH v6 2/3] dts: constrain DPDK source argument Luca Vizzarro
2024-05-31 12:50 ` Juraj Linkeš
2024-06-14 13:56 ` Jeremy Spewock
2024-05-31 11:20 ` [PATCH v6 3/3] dts: store stderr in RemoteCommandExecutionError Luca Vizzarro
2024-05-31 12:51 ` Juraj Linkeš
2024-06-14 13:56 ` Jeremy Spewock
2024-06-20 0:24 ` [PATCH v6 0/3] error and usage improvements Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOb5WZZJnQ+73miWQsr_jzY3ebW8_o4Vx_NkkciUGm+fQxG2JQ@mail.gmail.com \
--to=juraj.linkes@pantheon.tech \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).