From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 704A14338D; Tue, 21 Nov 2023 10:27:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42E4540298; Tue, 21 Nov 2023 10:27:58 +0100 (CET) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id 6DB824025F for ; Tue, 21 Nov 2023 10:27:56 +0100 (CET) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-548d60a4d60so2120338a12.2 for ; Tue, 21 Nov 2023 01:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1700558876; x=1701163676; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kyXQO/yCA1Ra0Kcy17o2d7gklatNX4a/lpg3TOMmk9A=; b=arv7zKLpPgd31RSFZagb17eCGU+unIGzmrfRrJNLXuPZ13lm9gWQ2zj7d9w3u68c6j YwSPFLTK+S9ahR7gs01ulmvqB7azJoRffTUwIX13dr87lNwOf3naijIXPm7lnDs45pb8 fg+n/lKp43BM+IxcwBLVO9QozagGdrEvbJW8fAuzk+0LWSLaoTLeTzOcIa2NUZIsGpZz MvskfG7to1zILmbiOMlSyUQDpm/gfs+i89AVHYF0HkbKhLfvAk6I9/FuvPx8q6Rjzws3 SUgu5CQvBMZBoQZSiF97f4Wfum4SpOX9XTBYxvkksco7q8HSdyDb5XzC8717I1QJ9wh1 WEsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700558876; x=1701163676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kyXQO/yCA1Ra0Kcy17o2d7gklatNX4a/lpg3TOMmk9A=; b=SQUbfirE+yr17ppcUUVwhB73PkVPyv/jop42HhJrXO+PNZVj2qtVV1SzS5DeYIvSkQ gddeXsntK/Q502kJxaRL9Lw0Y1HKlfGUnOHpU02n4uUhhVUW3oBtqQGmfQcYMKHL/LST rIJp1HSoOPNH+ML8HYQ626qlBlfDtu3NnU2dMsgMweS3v5C5PGqOMrW0nYLy63NFRwkb MFNdyCU3EDIHx7l4u5Cz3v40x/oOaomPtGjQJjmdFpALvfcF1DLhP4176tefWCKeAPC+ Qzhj7mq8V+854kj7ErquqG8HIx6rLRM7F0QBjo8wxZbIBxngqQFts09JUe0dDKQkrKUb zWKw== X-Gm-Message-State: AOJu0Yw/qDKxHaTRBxOsImFO5AYnAkCYgeveR2O72EcvaZYJ/RLZG7Yr p9V9RZpuoYSpN8rYBCIi8aLxUstvczaKtmK4/jmBag== X-Google-Smtp-Source: AGHT+IGxg+9lqj7OkbxNG0VD7wnVZ728MgkXi51WUaD0W+bO1bdQ418EynjxYGCRs7XP18Av3X0xX0PSkt56bcWwVYM= X-Received: by 2002:a17:906:1097:b0:a02:99b5:d0dc with SMTP id u23-20020a170906109700b00a0299b5d0dcmr409068eju.10.1700558876161; Tue, 21 Nov 2023 01:27:56 -0800 (PST) MIME-Version: 1.0 References: <20231016064559.17609-2-juraj.linkes@pantheon.tech> <20231120123646.43994-1-juraj.linkes@pantheon.tech> <20231120123646.43994-2-juraj.linkes@pantheon.tech> <2170702.Mh6RI2rZIc@thomas> In-Reply-To: <2170702.Mh6RI2rZIc@thomas> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Tue, 21 Nov 2023 10:27:45 +0100 Message-ID: Subject: Re: [PATCH v6 2/2] dts: reformat to 100 line length To: Thomas Monjalon Cc: Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, stephen@networkplumber.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 20, 2023 at 5:50=E2=80=AFPM Thomas Monjalon wrote: > > 20/11/2023 13:36, Juraj Linke=C5=A1: > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > The C recommendation is the maximum with the ideal being 80. The Python > > tools are not suitable for this flexibility. > > > > We require all patches with DTS code to be validated with the > > devtools/dts-check-format.sh script, part of which is the black > > formatting tool. We've set up black to format all of the codebase and > > the reformat is needed so that future submitters are not affected. > > > > Signed-off-by: Juraj Linke=C5=A1 > > Acked-by: Jeremy Spewock > > In general, I don't like doing large cosmetic changes, > but it looks mandatory to allow automatic formatting with black. > > Applied, thanks. > > Note that my pylama is still emitting warning when it goes longer than 79= . > It may be a problem in my environment but something to check. > By the way, why are we using pylama in the script > instead of directly calling the linters we are interested in? > This is a good point. It's mainly a little bit of convenience, as it's easier to run just one tool instead of multiples (and possibly different config files). But seeing as Pylama doesn't seem to be maintained well (it doesn't work with mypy properly and there are issues with pydocstyle as well), we may eschew it and go with running the linters individually - I'll note this for the future. > >