From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6772943BE7; Mon, 26 Feb 2024 10:06:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AAC8402BF; Mon, 26 Feb 2024 10:06:06 +0100 (CET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id E9D4A40144 for ; Mon, 26 Feb 2024 10:06:03 +0100 (CET) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5640fef9fa6so3586461a12.0 for ; Mon, 26 Feb 2024 01:06:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1708938363; x=1709543163; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BdNy/hgNQw6YrWwk5F4mAg0743mQOnU8AG3RRwbX6Cg=; b=cZibKseIVoFj0CY8C+wsCNVTRjWER9dd9J/ZcdOzmaIwCIyfxukwzg24vnJeftrBFO szg17iuY3ZYiwiRzpBQWgZBTtZdjQef4Bu1LEbo9psGUh2+NYRLAmQ2+fkgF72wisciM DsHP8hV1wz2Vl/x8Lpro944NXzAbIAE/ydmzYBF/OSmx1ypM1+Czeaq5/gmwM32xEEpc UzWlEIu5wiph3t6EdpaB8usgrygTDfiqhr4kink9fQaELxI7fe/j2o1zR/JkwiEqsaGw JW4OBDjjpxD5OUg96jLt8gUy6dsyigH3Yf2Deg91Bw8wyFmIj9BzfpRjfdRJ9l+tQeIm E3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708938363; x=1709543163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BdNy/hgNQw6YrWwk5F4mAg0743mQOnU8AG3RRwbX6Cg=; b=A7UfoqhnhcHO4vDrQdo0HLlHh1gVfosSbyEJZJyVpimaBH//H3v2WCaJkMRLbY2fu9 w0E6qa0iKGDMBwzDJ2MGpmpm23cl/keVL3FDUU2LBaFnyCv6uAw92ZjASvPtg0edv+c6 61fe9c8Fj7pLWtj+ugssdXdahk6NhyhATO2G/bosY2BxDQPtK/Xn+G2mbV7T97OHFfip gMICwnNPrW/6nRW9zKL2fiRY1j4PtJS8iuKho0gPd1uMrpiOF8uZrSMEa7bz4lib9ws3 /kNRt2tgdYFED2vzEr+mUIteyOr2YXcqseisYYpEr36cKO3F/mifswUTRmrTxZMJNlFV zPWw== X-Gm-Message-State: AOJu0Yx9apfgGGZeL9mWGsyiQj/1Et18twV/oEi7kPJ2a33fh3eZDJFL flLszG0N5Z9yAWbJgj+ni3Od0B2V+lU9bd2m3dDRHJedxlqPHW05rRNM38a9uBcAnWHIwUlJ7s5 +nJ2aJL4ZulNTB4eOt89fXhld3/oiWrDSK6asXvsjU7HuJIkRwBL86g== X-Google-Smtp-Source: AGHT+IGnSIbYysXdyQsRgIg8WgPHQxj6H5WOt7vVOCNTSzG35ZdOmfbRaheotyw35dPEhs1xmTUFUcJdTk8q3roeW4c= X-Received: by 2002:aa7:d48f:0:b0:565:9f59:b3bf with SMTP id b15-20020aa7d48f000000b005659f59b3bfmr3825920edr.6.1708938362765; Mon, 26 Feb 2024 01:06:02 -0800 (PST) MIME-Version: 1.0 References: <20240122182611.1904974-1-luca.vizzarro@arm.com> <20240122182611.1904974-5-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 26 Feb 2024 10:05:51 +0100 Message-ID: Subject: Re: [PATCH 4/4] dts: log stderr with failed remote commands To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 23, 2024 at 8:19=E2=80=AFPM Luca Vizzarro wrote: > > On 29/01/2024 13:10, Juraj Linke=C5=A1 wrote: > > Here's I'd add logged additionally as an error, as this sounds as if > > we're changing debug to error > > That is also a way of doing this, but an error is an error. If we wanted > to log the same thing in debug and error, then when we go read the debug > we get duplicates... making it less readable. What do you say? > I meant let's change the commit message wording to better reflect what the patch does - it adds stderr to the exception, not doing something instead of logging it as debug (it could be understood this way). But it doesn't really matter much. Maybe a better wording of the second sentence would be "So that, instead of logging it just as debug, it is also stored in an error, ." > > I'd change the order here (and all other places) so that stderr is > > before the return code. > Ack. > > > We should mention that the last string is the stderr output. Maybe we > > just add 'Stderr:' before {self._command_stderr}. And maybe we should > > put quotes around {self._command_stderr}. > > Since you mentioned "quotes", I'd think that it'd be even better to > indent it as if it's a quote. With logs as busy as the ones DTS prints, > adding some quotes may not change much as it's all already very crowded. > Can prefix with 'Stderr: ' though. The prefix is essential so that we know what the output actually is. Indenting it sounds great.