From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50E7C440E3; Fri, 31 May 2024 14:51:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EE5D402C9; Fri, 31 May 2024 14:51:03 +0200 (CEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mails.dpdk.org (Postfix) with ESMTP id 3C25E40265 for ; Fri, 31 May 2024 14:51:01 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a6269885572so383361366b.1 for ; Fri, 31 May 2024 05:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1717159861; x=1717764661; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HxwLkKqNfmqJJh/y59meeUzFy0gFm2XOOQoFedaPoeM=; b=GDXDbcwFdZH0W22yyOZ1Ab09uldSZvg3xa6iZ33NvqqyHzj9GipU0mZiMhvcehteb0 JVLJuAjWdyhVHJHhUbH96F4a9UNiIfmvmn5k7scrqAFy6aAqGS/1Sc2eiea5JA3ww7L2 aWsu3BsVGeYOpwslseZEs7Yo0aoRAq6x+un8nKHVH1O4Wm9OsqbpzUIbQpgnUn0fZ4Br /kRGzx9/TNhtK8b9z4Uejy3REbe6ff8aehu5osx7rTRO4a8Oppqz41MHbthQQzfj4Jc/ qrQ/yb1NCG0PiP0IKKH9U40AorXAk8bKh1NYXoPNHMvn4nB7Lf47+7D9CaJGoShGNHIA uwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717159861; x=1717764661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HxwLkKqNfmqJJh/y59meeUzFy0gFm2XOOQoFedaPoeM=; b=kuBunDidvAZuCr449CGCPhLfKyPlYU48wTvpicxD/ZlV6p6ixOKCHlKPTYhij8qVwQ 2V2qX4z7EkA8Fgc/arQGX8v9zIqqO9QDdISH97NEcvcLK+kwRTkj31geDuBG2tsPxLbB Rem3OFfz29Oi/f8aY5Q0IEgQE2Kmg0HZfDg62lTfQVPbSgRi+0PFoxC04oBV5/+KeH31 uTNZYN5qjsbgXh61fhVmUE9F7TDI3+ytiXS2bLbsASN4v9lrZKrSBh4XllIea26RY/iu L6IJ78OkXJ8fcwhmLOl0qrAa4xKa6ZK0aT8h6ZMW7wOFNCN34uB+e56AcBSRJfp1mtJA kBTQ== X-Gm-Message-State: AOJu0YxkgyjgppDy4474LmOEdaAhi6TwMrUHo1wiIl+XKsjDUWUrnyzW aoe+fSiQkAV9nuRFSVPxICvq4erJgeLDjD/AJLSJKD3Y2uJ0AivggoFFF8PZsphhX7ECv/N6y61 lNbT3+bIT1xp3618vB0NhMQAItFQdjxsaWWWQBQ== X-Google-Smtp-Source: AGHT+IHh2bvWtlcKnaOdUjcLzDBqbFtjRiNEkA6gAc/f9eTOhnR+n8CjTkxr4b7fjHyVusJMy7AEORfF803YP8tGlhU= X-Received: by 2002:a17:906:f903:b0:a63:f0c8:68f8 with SMTP id a640c23a62f3a-a65f0d0bc82mr377950666b.32.1717159860905; Fri, 31 May 2024 05:51:00 -0700 (PDT) MIME-Version: 1.0 References: <20240122182611.1904974-1-luca.vizzarro@arm.com> <20240531112042.18736-1-luca.vizzarro@arm.com> <20240531112042.18736-3-luca.vizzarro@arm.com> In-Reply-To: <20240531112042.18736-3-luca.vizzarro@arm.com> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Fri, 31 May 2024 14:50:49 +0200 Message-ID: Subject: Re: [PATCH v6 2/3] dts: constrain DPDK source argument To: Luca Vizzarro Cc: dev@dpdk.org, Jeremy Spewock , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 31, 2024 at 1:22=E2=80=AFPM Luca Vizzarro wrote: > > DTS needs an input to gather the DPDK source code from. This is then > built on the remote target. This commit makes sure that this input is > more constrained, separating the Git revision ID =E2=80=93 used to create= a > tarball using Git =E2=80=93 and providing tarballed source code directly,= while > retaining mutual exclusion. > > This makes the code more readable and easier to handle for input > validation, of which this commit introduces a basic one based on the > pre-existing code. > > Moreover it ensures that these flags are explicitly required to be set > by the user, dropping a default value. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linke=C5=A1