From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53CD1431DE; Mon, 23 Oct 2023 08:44:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3773A4027E; Mon, 23 Oct 2023 08:44:36 +0200 (CEST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mails.dpdk.org (Postfix) with ESMTP id 6240C40270 for ; Mon, 23 Oct 2023 08:44:34 +0200 (CEST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-9be02fcf268so422127466b.3 for ; Sun, 22 Oct 2023 23:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1698043474; x=1698648274; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a2uZpfneaDkwgy/1feJDMbtQjCzMv74ZOAiine8yGnU=; b=sBbxztrLB5ijjluuEqznCiVcJYXML/O5dmTSPAMVOIXxk0M8EDWY4X//HIX+mmeYaL XRfNUS+EJYJ0ngNGomYfkfv5ZnBKUYN7abg1lNkJv95qeP6SFLb4gJdfMVG11yTav5VE TscQdL6z1mEeH9c49PbLPaJPQwnllu+4FD1TL2jnLFMKtzVpw/S1HSz74C7jzbrVemKI lA9+dySInsPfDb0oKm5L4ffFq1N7+5cWy2vRTs6wqca/mtjE/y0gDcJd/Yd0l5Yad88i Uk0wllrunvVwfgpin6Nr+foSMOeowJOumaJ0trqzslnFa9k//iuoAwq3FgsAA3odzQBK hzqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698043474; x=1698648274; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a2uZpfneaDkwgy/1feJDMbtQjCzMv74ZOAiine8yGnU=; b=Lt550IbzFdJlDMbYVJ6QEWNnKt7Xx7I16PGvtUC4kR/dN7KlXk+nckJsrGKXgnWX5K Atc3K3PiPisMP+5N/re62luo3buENI47p8AdsVXtkRNJwbXEI02FCdxVMaz/7Tv57QrZ wdPxQjE8onEYytylKrnaDJ9Ohvszh1x7pgUz9oA3VOlh7DXBbBrTI/cNYyOvLWmcpNGL WjRiQRWtxjyZQTUlkF8iRJXRvlD980QheRx6GDnGu4fVWb0BkWdOdfz4MoYIBo1cwgUQ uvwYR+3ul1qJg+84P9weSSty5fKbzCoQJeX2h8ikBXF2FbgylCM+OphOSCdC+LcCyqZU vuMQ== X-Gm-Message-State: AOJu0Yx85iwsiSL4xEjcg4HzpkQgvBlTH0zKSGhuat9CwVKh8+MfAan8 NQqW6QkXcUrwjfTPk0pp8FNgWIobqX/RLfMzP/ldKA== X-Google-Smtp-Source: AGHT+IFxUtoD9Aw4t6MVORoBaLiDDmH8B2TgGKXGa+UghPFsB3nICI+J/MXnd5FWP8wZehWIZyFSYYale5f4ZAnUmCs= X-Received: by 2002:a17:906:fd8b:b0:9be:d217:40b7 with SMTP id xa11-20020a170906fd8b00b009bed21740b7mr6809174ejb.32.1698043474171; Sun, 22 Oct 2023 23:44:34 -0700 (PDT) MIME-Version: 1.0 References: <20230511091408.236638-1-juraj.linkes@pantheon.tech> <20230831100407.59865-1-juraj.linkes@pantheon.tech> <20230831100407.59865-2-juraj.linkes@pantheon.tech> <69c39f25-563e-4e32-a6a2-81e0049332d5@foss.arm.com> In-Reply-To: <69c39f25-563e-4e32-a6a2-81e0049332d5@foss.arm.com> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 23 Oct 2023 08:44:23 +0200 Message-ID: Subject: Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx To: Yoan Picchi Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > My only nitpick comment would be on the name of the file common.py that > only contain the MesonArgs class. Looks good otherwise Could you elaborate a bit more, Yoan? The common.py module is supposed to be extended with code common to all other modules in the testbed_model package. Right now we only have MesonArgs which fits in common.py, but we could also move something else into common.py. We also could rename common.py to something else, but then the above purpose would not be clear. I'm finishing the docstrings soon so expect a new version where things like these will be clearer. :-)