From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C42943883; Wed, 10 Jan 2024 14:22:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05C5840269; Wed, 10 Jan 2024 14:22:33 +0100 (CET) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mails.dpdk.org (Postfix) with ESMTP id 3FB5D4025E for ; Wed, 10 Jan 2024 14:22:31 +0100 (CET) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-55783b7b47aso4078127a12.0 for ; Wed, 10 Jan 2024 05:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1704892951; x=1705497751; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g0me/RDamvjBZRRUvQSHDAjJ/0HTeKD0YowePQkwkdM=; b=rBbMqzwMSnwX5cYw8Gds9Tp60Vgfzd6WyU48HkTDOaS1z97zpfEtdsNCD1U9CBtShJ EupYhXT19cFriFVOX16xj20HexqahIvX0tgOPBtFJMUNMDuPY/6BKFrAsS0VwJvHPpNa 9z1eMZn3cHiRwCFoG/kap79HuX9UYY/aDUUv9U8t1zhbUMorWySNobo626YxeIfz4YLS qL3WrKtjmgl1r0/hqBRO3TTGfPiUcdTptUnVMBQ6OvD+Y5gX4NScjV+yy9fnj861V9bN vhQ8Hcy9uYLm/PxS5Tt2U2FxLwdd+gM0uuM3L5Al+5Y/rOtXntYz7xAd6wy/SfrIypLN UKuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704892951; x=1705497751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0me/RDamvjBZRRUvQSHDAjJ/0HTeKD0YowePQkwkdM=; b=pxm9zid3gph5kEGJa+9ulCvTVHaKXEumTq+gQ+G3FfTecCfLkDFEkd9PgBCxseBtcz xLPypr3pY8my6mtrWsf4ZiBP8apq4rxGK38v/8GMaP7G5pov/J1ejcKlLiGluKlFx57o stDGKemwTi1dstVkij+pJiFFPlVpo0EmG+kBLsGrC8scXPe+mRnFdWDwJ1mSd1sINmaH lpeeBxnTeeJVL9DhdAsqXH0tooQSSEOP4qiXVreVHSXD4GF4EGYDX5sf4snVLRTxQVFb Qaag6SY36D7YORetWLYtc25F9BWYluP3/cElvdhgMQ/++5npqfDuC1Rt0S9kJ+krw7xI CVag== X-Gm-Message-State: AOJu0YzYtVGM0td3WxSKUVDt4HwuBJWBla0bB5skT0x7FWtHgaCC0fik SuhEsmU8q+APjfv2pEwJpXsTG+l6YPMRPk1ruopUN2VZehwhGw== X-Google-Smtp-Source: AGHT+IHyXtnjF9kz40pUXdS8bW1oJ0z80qf25sguxmyK+jz4NPwlgnB1xY1WH2d7Z64vB9FceayHHqeXB/SwhdfO10U= X-Received: by 2002:a50:8d43:0:b0:557:e908:f53e with SMTP id t3-20020a508d43000000b00557e908f53emr404226edt.13.1704892950873; Wed, 10 Jan 2024 05:22:30 -0800 (PST) MIME-Version: 1.0 References: <20240103223206.23129-1-jspewock@iol.unh.edu> <20240109153633.766-1-jspewock@iol.unh.edu> In-Reply-To: <20240109153633.766-1-jspewock@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 10 Jan 2024 14:22:18 +0100 Message-ID: Subject: Re: [PATCH v7 0/7] dts: Port scatter suite over To: jspewock@iol.unh.edu Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, lylavoie@iol.unh.edu, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I only had two minor comments in two of the patches. Other than that. for the whole series: Reviewed-by: Juraj Linke=C5=A1 On Tue, Jan 9, 2024 at 4:36=E2=80=AFPM wrote: > > From: Jeremy Spewock > > v7: > > Addressed comments and made appropriate changes. Most changes had to do > with grammatical/spelling errors and expanding upon documentation. Also > fixed the typing of eal parameters when creating interactive shells > through the SUT node. > > Jeremy Spewock (7): > dts: add startup verification and forwarding modes to testpmd shell > dts: limit EAL parameters to DPDK apps and add parameters to all apps > dts: add optional packet filtering to scapy sniffer > dts: add pci addresses to EAL parameters > dts: allow configuring MTU of ports > dts: add scatter to the yaml schema > dts: add pmd_buffer_scatter test suite > > dts/framework/config/conf_yaml_schema.json | 3 +- > dts/framework/exception.py | 7 + > dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++- > dts/framework/test_suite.py | 15 +- > dts/framework/testbed_model/linux_session.py | 8 + > dts/framework/testbed_model/os_session.py | 9 ++ > dts/framework/testbed_model/sut_node.py | 28 +++- > dts/framework/testbed_model/tg_node.py | 14 +- > .../traffic_generator/__init__.py | 7 +- > .../capturing_traffic_generator.py | 22 ++- > .../testbed_model/traffic_generator/scapy.py | 27 ++++ > dts/tests/TestSuite_pmd_buffer_scatter.py | 132 ++++++++++++++++ > 12 files changed, 407 insertions(+), 14 deletions(-) > create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py > > -- > 2.43.0 >