From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F66242354; Fri, 13 Oct 2023 09:57:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 070BB402A1; Fri, 13 Oct 2023 09:57:01 +0200 (CEST) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mails.dpdk.org (Postfix) with ESMTP id 792204028C for <dev@dpdk.org>; Fri, 13 Oct 2023 09:56:59 +0200 (CEST) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-9b2f73e3af3so274268166b.3 for <dev@dpdk.org>; Fri, 13 Oct 2023 00:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1697183819; x=1697788619; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LrSpU5HQc1kiC9jJqyKwGsyAaT0jgdyBQQT4CxzFpDQ=; b=M9eYncZvdVPatw3gjaJpYvi6qRcvPb3QskhT2bUKM9LzQNUoBZhoC3xFSmzQce1W8e KnBvxrFy5l/1WmmRw96Ij1/qrMRdUqke4Y9gu183QtpDSBoIRWrnXBv3kkiXG/dKBZ5y 9sfzfMwtbE3W7g0Z1fYi8dR+pBDg9KkqxNoYvyGqKzPk2XS+mhd3DOgQmVMaomoj0wCX 2X6lGG6aXKaLEsdNC7063FZBO1ml2uh/ak80Wuu09MX0oAwZ1epIbazs2QumH4C5xfau 0aXzR5BlfMrlalU+BXbeaLUOdgz1QFNlhPllR80RE0nnnnTuwK8knoiC/T+3uzLo8qgF /tZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697183819; x=1697788619; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LrSpU5HQc1kiC9jJqyKwGsyAaT0jgdyBQQT4CxzFpDQ=; b=dn/7QebyWVHm/Wiqi4qK3VTDHOnbyfreazSF37+I2Nd4XVbnjKQ4JDaBrlqr56rvbw LT7wFblqtXF9wCBTEB/2q+Bbkpn32ZKWM/88nwQyiNvNodthf4z+e8w9295cufazkL7T JRdIJ4TtKBHK50/Se79dAFySjT6ueUH8mwoI8COt6NnH/YFMIB1cNfl747ZA7Mkxd+Fz Bfyjl8YyItCpQvnl1frUMjVpa+Y1Mpd/vy4/Y72Sf7EKNbMy9+cidn+K+ewjGQo3taKF PZJ7nmrL0500it+RRRtdBOSaWjoHT8lZZhU9E6FDz+H56G8OP4JPAwTxEJU2tfzqAwju fTxA== X-Gm-Message-State: AOJu0YystkKoI5CzYsDvT9kSao2Cgzs/urpy8jO399/C3up2nUMK5GOy ZjOm4PI3K5BpP3OegL6HqRWhRZ8zoSerHXUoTIWfF3+uuv7ZQQ+pg/M= X-Google-Smtp-Source: AGHT+IH3iHUsa5+y/2em/YikkiDchhECzk46e8tdFGY4BDltZ13XhRgyX5hGhW/emUc6wKZw4wT+IEmo4MGqMnDpBQA= X-Received: by 2002:a17:907:75ee:b0:9ba:2da5:d9d7 with SMTP id jz14-20020a17090775ee00b009ba2da5d9d7mr10050098ejc.40.1697183819062; Fri, 13 Oct 2023 00:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20230926121013.23351-1-juraj.linkes@pantheon.tech> <20230928121830.62608-1-juraj.linkes@pantheon.tech> <f95db975-e0d6-4ce7-ad66-db6bb033839b@arm.com> In-Reply-To: <f95db975-e0d6-4ce7-ad66-db6bb033839b@arm.com> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech> Date: Fri, 13 Oct 2023 09:56:44 +0200 Message-ID: <CAOb5WZbS4KZ9oLrAkB6e8hL-U=r96FMzwF9TS9XV3Cwpo3zx+g@mail.gmail.com> Subject: Re: [PATCH v3 1/2] doc: increase python max line length to 100 To: Paul Szczepanek <paul.szczepanek@arm.com> Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, stephen@networkplumber.org, nd@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, Oct 12, 2023 at 2:52=E2=80=AFPM Paul Szczepanek <paul.szczepanek@ar= m.com> wrote: > > > On 28/09/2023 13:18, Juraj Linke=C5=A1 wrote: > > Unify with C recommendations which allow line length of up to 100 > > characters. > > > > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu> > > Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> > > --- > > .editorconfig | 2 +- > > doc/doc_build/meson-private/meson.lock | 0 > > doc/guides/contributing/coding_style.rst | 3 +++ > > dts/pyproject.toml | 4 ++-- > > 4 files changed, 6 insertions(+), 3 deletions(-) > > create mode 100644 doc/doc_build/meson-private/meson.lock > > > > diff --git a/.editorconfig b/.editorconfig > > index ab41c95085..1e7d74213f 100644 > > --- a/.editorconfig > > +++ b/.editorconfig > > @@ -16,7 +16,7 @@ max_line_length =3D 100 > > [*.py] > > indent_style =3D space > > indent_size =3D 4 > > -max_line_length =3D 79 > > +max_line_length =3D 100 > > > > [meson.build] > > indent_style =3D space > > diff --git a/doc/doc_build/meson-private/meson.lock b/doc/doc_build/mes= on-private/meson.lock > > new file mode 100644 > > index 0000000000..e69de29bb2 > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/cont= ributing/coding_style.rst > > index 648849899d..a42cd3d58d 100644 > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > @@ -880,6 +880,9 @@ All Python code should be compliant with > > `PEP8 (Style Guide for Python Code) <https://www.python.org/dev/peps/= pep-0008/>`_. > > > > The ``pep8`` tool can be used for testing compliance with the guideli= nes. > > +Note that line lengths are acceptable up to 100 characters, which is i= n line with C recommendations. > > + > > +.. > > Presumably the bare ".." is some accidental leftover markup. > I'll fix this in the next version. > > > > > Integrating with the Build System > > --------------------------------- > > diff --git a/dts/pyproject.toml b/dts/pyproject.toml > > index 6762edfa6b..980ac3c7db 100644 > > --- a/dts/pyproject.toml > > +++ b/dts/pyproject.toml > > @@ -41,7 +41,7 @@ build-backend =3D "poetry.core.masonry.api" > > [tool.pylama] > > linters =3D "mccabe,pycodestyle,pyflakes" > > format =3D "pylint" > > -max_line_length =3D 88 # https://black.readthedocs.io/en/stable/the_bl= ack_code_style/current_style.html#line-length > > +max_line_length =3D 100 > > > > [tool.mypy] > > python_version =3D "3.10" > > @@ -55,4 +55,4 @@ profile =3D "black" > > [tool.black] > > target-version =3D ['py310'] > > include =3D '\.pyi?$' > > -line-length =3D 88 # https://black.readthedocs.io/en/stable/the_black_= code_style/current_style.html#line-length > > +line-length =3D 100 > > The rest looks good. Wholeheartedly support longer line length. > Thanks, please send your ack's in the new version. >