From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EC5043E32; Wed, 10 Apr 2024 08:53:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B55944027F; Wed, 10 Apr 2024 08:53:53 +0200 (CEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id 8271F4027E for ; Wed, 10 Apr 2024 08:53:51 +0200 (CEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a46a7208eedso919270366b.0 for ; Tue, 09 Apr 2024 23:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1712732031; x=1713336831; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Yg7bX8o4Db9DmHyeaqx9e0E1lslXo8ySk6cuBqEdSYc=; b=iHFmBYy+dYE1+AXifqM+q/fftgK8jmvUdrfjVRPp2D8brxVx4SlxYMizDTNU0cQeqV zckeqTdQWPhMn8A/IUaU0+PiWpO7fZuTeY1+dQ8ubpARsrKElGWX+ZQhx19hePU8bTq1 2vzLVSG8AkuaSxAuEz5RCgqrYwT/DhumIc4Odg7XN59ZM+BEkXAZ5xGuZvYROJbqFKv9 GIHJctqZSU1UNYy3K5XgVpW34Ho9dWqYAXxpMGsDCdTvIagE9SXlN2XxTZmRr0y9e8IU OmB/tk+aH/7HRiC7yC4pgAi7uewmwUTREBDRAyUQ0Jv1hoiXz5gQcG0NDZxyNqJf4MXt otVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712732031; x=1713336831; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yg7bX8o4Db9DmHyeaqx9e0E1lslXo8ySk6cuBqEdSYc=; b=ad4sDA417KHX1YSqdIufoZ+iGkWP0BN6++Vuj81uCiduAoTptKhi69eXpr65RlUIHH MCxVyTZEF0SuVP6jiOp9WexkJ/rAvAmB8kxhBuI0irOmfLJ4XdKlgqUYyumqhQwcRiUu 4RkZphiVPz+0cvotepB1AyZvST16ioUcITCQ6G0DJD6tgKbBftZvzSay9pFlk5eCsP3f zA3azsXt66AwW4iwsbaQuqjOQt5bcvp2LrdMyLoIyBjwq1k2KffisQhJfH9u5XdWQhKp BxnnOoP12x6w+gHhTybh6Evrm4enQylwIVHcSPimzrKhNb1vd8m9aLHDWPSwN6SvFF0I Zfhw== X-Forwarded-Encrypted: i=1; AJvYcCWFnYkasU2sYMvT4MobL6m2/+eU4td0/BZd4s3xyRFV0uJ1UtgqdAuS+k1aCq6z7yIyxpbNSLR/J7j6SJo= X-Gm-Message-State: AOJu0YwH4G+DoC80JpFcVg10SN70a0H9EmE9Nii57HVRrCXHgzLyqeGi jpcejWoZ8VE46IYuHaXqedo9rgj6ptLZ0XeVp94ZJeBWOlhVTQ4ZadKM99hbAKS+HwvNbIS+J7e /lZyNn69e1QE0BGosvM9VrcfMv8rn+/qq8tvfdOTKVMqSrhlH2cc= X-Google-Smtp-Source: AGHT+IFF5O2kyuwiYjR2P1vvxGm7yCaOtch8pRexEXFtig8AqepwO0NVK/YrrU10oKDVJGPSnT5VB9oh53JyEeRM8P0= X-Received: by 2002:a17:906:a90:b0:a51:bd13:96ce with SMTP id y16-20020a1709060a9000b00a51bd1396cemr860715ejf.3.1712732031069; Tue, 09 Apr 2024 23:53:51 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-6-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 10 Apr 2024 08:53:39 +0200 Message-ID: Subject: Re: [PATCH 5/6] dts: add statefulness to InteractiveShell To: Jeremy Spewock Cc: Luca Vizzarro , dev@dpdk.org, Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I have a general question. What are these changes for? Do you anticipate us needing this in the future? Wouldn't it be better to add it only when we need it? On Thu, Mar 28, 2024 at 5:48=E2=80=AFPM Jeremy Spewock wrote: > > On Tue, Mar 26, 2024 at 3:04=E2=80=AFPM Luca Vizzarro wrote: > > > diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/fr= amework/remote_session/interactive_shell.py > > index a2c7b30d9f..5d80061e8d 100644 > > --- a/dts/framework/remote_session/interactive_shell.py > > +++ b/dts/framework/remote_session/interactive_shell.py > > @@ -41,8 +41,10 @@ class InteractiveShell(ABC): > > _stdout: channel.ChannelFile > > _ssh_channel: Channel > > _logger: DTSLogger > > + __default_timeout: float > > Only single underscores are used for other private variables, probably > better to keep that consistent with this one. > I agree, I don't see a reason for the double underscore. > > _timeout: float > > _app_args: Params | None > > + _is_privileged: bool =3D False > > > 2.34.1 > >