From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2D3C43347; Thu, 16 Nov 2023 19:10:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F082402E8; Thu, 16 Nov 2023 19:10:43 +0100 (CET) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mails.dpdk.org (Postfix) with ESMTP id B1569402CD for ; Thu, 16 Nov 2023 19:10:42 +0100 (CET) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-9d267605ceeso154315366b.2 for ; Thu, 16 Nov 2023 10:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1700158242; x=1700763042; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=scRLaRCmo++fAcYEaizkjR9045tsKGrO+ddqHoA7AU4=; b=sv0PoN8HXLqEJh1lFNkQgeiPECfBo/5sdpRWjJDfhMGEU2RUudEsCN2fkXNxQTZpSS OKc5bSr0FifeA+0F6Cnfl04Kf9O/H5v35kHcOYVEfWNvhS/dAHEP+WSYP+sOp1ckdqej wq5fKYsc5IAa0sfkQ/PGbj6BzYu4di3P6Dxz5RUvhs334O0e9XkrtPns+Y/UQ18T4+IA Q0HgE8d8N7XOYDIfFpQr/kHSq9wD+RXkSC08DyzjN4rTMq8QNcA4zy6p2C9ETl6m10HY xTlwUY7Fga40A6qty35Aztqd1KJ2nhF7V12qBnc9kAgIXuRv9V67+lBJGbkSL0pY7nEu u9PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158242; x=1700763042; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=scRLaRCmo++fAcYEaizkjR9045tsKGrO+ddqHoA7AU4=; b=kMHnHm4TBomV+xcwbXGCzAi48TV7IcKRhiBjWIy5dgGGJSRi1FE9kTKKIvmSYALfS3 pCGuUYAXNb5q9H4geiUosw2ghqgGvSP1wcWce0AWlaWwE3AVb6s9X/wGC6B/OJ8A34T7 GKStbLGs7OFAeiviUqT4CX1vdZ5Tg3QCgHfjaP3Ml7esLMn/OWJzqHOIbjY6jbWdk7kD ERLPgjONXv0amK5nWTQNsIrNbUmSoX6b6D7Q1PFLt8DkzUBMbS/bhN4n0Kb6U6YY97LA 4Lrepac3YOBMQBYT9HKQOL/qnH07ezzb1K72rHPiFiYprWuI6w8hMnauGu/wdKTH/Kxk 7fQA== X-Gm-Message-State: AOJu0YzzwQqg2M32sDcEEE7UMro2PzU4gxslNyY3mUOZclhGiubj9ihg emCzPP7qadWu7r/xnemVV9BCRxSRZJd4a81OyLjrQQ== X-Google-Smtp-Source: AGHT+IHRguCRfGrv5UaqqOumWMtWB8p9Isho+bB6FfZxBpsTTpAvC0EhWITb9t9pGkr10GeJYVyqFXjTwmQbH9C8Cp4= X-Received: by 2002:a17:906:a212:b0:9e5:ee70:5da1 with SMTP id r18-20020a170906a21200b009e5ee705da1mr10252415ejy.53.1700158242240; Thu, 16 Nov 2023 10:10:42 -0800 (PST) MIME-Version: 1.0 References: <20231113202833.12900-1-jspewock@iol.unh.edu> <20231113202833.12900-7-jspewock@iol.unh.edu> In-Reply-To: <20231113202833.12900-7-jspewock@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Thu, 16 Nov 2023 19:10:31 +0100 Message-ID: Subject: Re: [PATCH v3 6/7] dts: add pci addresses to EAL parameters To: jspewock@iol.unh.edu Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 13, 2023 at 9:28=E2=80=AFPM wrote: > > From: Jeremy Spewock > > Added allow list to the EAL parameters created in DTS to ensure that > only the relevant PCI devices are considered when launching DPDK > applications. > > Signed-off-by: Jeremy Spewock > --- > dts/framework/testbed_model/sut_node.py | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/test= bed_model/sut_node.py > index bcac939e72..f9c7bd9bf3 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -20,6 +20,7 @@ > from framework.utils import MesonArgs > > from .hw import LogicalCoreCount, LogicalCoreList, VirtualDevice > +from .hw.port import Port > from .node import Node > > > @@ -31,6 +32,7 @@ def __init__( > prefix: str, > no_pci: bool, > vdevs: list[VirtualDevice], > + ports: list[Port], Please add this to the docstring. This overlaps with the docstrings patch. I guess we'll need to modify one of the patches when the other one gets merged. > other_eal_param: str, > ): > """ > @@ -56,6 +58,7 @@ def __init__( > self._prefix =3D f"--file-prefix=3D{prefix}" > self._no_pci =3D "--no-pci" if no_pci else "" > self._vdevs =3D " ".join(f"--vdev {vdev}" for vdev in vdevs) > + self._ports =3D " ".join(f"-a {port.pci}" for port in ports) > self._other_eal_param =3D other_eal_param > > def __str__(self) -> str: > @@ -65,6 +68,7 @@ def __str__(self) -> str: > f"{self._prefix} " > f"{self._no_pci} " > f"{self._vdevs} " > + f"{self._ports} " > f"{self._other_eal_param}" > ) > > @@ -308,6 +312,7 @@ def create_eal_parameters( > append_prefix_timestamp: bool =3D True, > no_pci: bool =3D False, > vdevs: list[VirtualDevice] =3D None, > + ports: list[Port] | None =3D None, Same here. > other_eal_param: str =3D "", > ) -> "EalParameters": > """ > @@ -350,12 +355,16 @@ def create_eal_parameters( > if vdevs is None: > vdevs =3D [] > > + if ports is None: > + ports =3D self.ports > + > return EalParameters( > lcore_list=3Dlcore_list, > memory_channels=3Dself.config.memory_channels, > prefix=3Dprefix, > no_pci=3Dno_pci, > vdevs=3Dvdevs, > + ports=3Dports, > other_eal_param=3Dother_eal_param, > ) > > -- > 2.42.0 >