From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by dpdk.org (Postfix) with ESMTP id 79B5C298F for ; Mon, 28 Mar 2016 20:36:50 +0200 (CEST) Received: by mail-ig0-f170.google.com with SMTP id nk17so58577374igb.1 for ; Mon, 28 Mar 2016 11:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=cxi7PK+Y1Nt6YJL/trfk+KNet8EGVzlWgELmT5rnBgU=; b=yy6yAuSzZpxvHNR7bV1ui7ZBHX8N6n6CgxoUjZihmNElp9p5s4+elMESwnZISBtts4 5fXqERichVZzxDCFhDpjTSGDuw4G895ow/hJr+g/0PqjlIxcCXl2bkironFpDyLdWKQc toHwc0uo73NpdsVaFs6ZuSukEdaVm8AY8Tx95e1LSc2AeWWLrlvbIdOFzk+146YDhShw iyzIsg58WTdVt2siO6O+7FVPClOjX7d3dMTAbHI8FDN81loYrmljeNE1dc+h1b0VwQg8 oCVXvw88twwhIl5ncT/Hv0TzIZsRHoXK7QRX+PKS4/eZ5FmRgzr8EoMTFGw1TaqPFn8u Xphw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=cxi7PK+Y1Nt6YJL/trfk+KNet8EGVzlWgELmT5rnBgU=; b=BYefgo4JOcR21mAYM+yOnYJSbiqAiD1xXZUajIFYeOj2DBO9pLUZy/jMjbMPnXV517 NMtnWeUS/JfDqs9n5UimQ1cARVvk9ZEmCNcDf/5Th+rKTBU6XjBPjyTsCz1sbwLCYGqV PubK+8Lc9yxQRgeuwREqSRvJ5LokE+860hWuqBykjbO4rTyemm9U54HLEbJbyjE8YJ/U FaunUbp6Z8epG9XQef5DLCKFFppZ1cuVKKZleBVPKrKpFryIeqSxskwVyXDoU9bffK/H z9D4FxYRtoULRnOT18xHZQA9W/mm3wBvnXMmEd4j1NUg7AKU0swF83yyh7jvvF1afYAy dMig== X-Gm-Message-State: AD7BkJJXrylHG9bkY4FCbX/JKfxkllsqsJYs/zyxvKO/vpDqbTZsKp4ehk+Siuf9W4tsMa8URtZRx6vQxX5sgA== MIME-Version: 1.0 X-Received: by 10.50.79.168 with SMTP id k8mr11377836igx.55.1459190209870; Mon, 28 Mar 2016 11:36:49 -0700 (PDT) Received: by 10.79.126.197 with HTTP; Mon, 28 Mar 2016 11:36:49 -0700 (PDT) In-Reply-To: <20160324120419.GA13728@bricha3-MOBL3> References: <20160324120419.GA13728@bricha3-MOBL3> Date: Mon, 28 Mar 2016 13:36:49 -0500 Message-ID: From: Michael Habibi To: Bruce Richardson Cc: dev@dpdk.org X-Mailman-Approved-At: Tue, 29 Mar 2016 10:33:24 +0200 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Bug in i40e PMD for flexible payload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2016 18:36:50 -0000 I will have one of my team members follow the instructions and we'll have a patch out this week hopefully. On Thu, Mar 24, 2016 at 7:04 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Wed, Mar 23, 2016 at 01:44:46PM -0500, Michael Habibi wrote: > > We are using the i40 implementation to configure flow director with > > flexible payload rules. When setting up rules, it allows you to set a > value > > to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF). However, the macro > in > > question is always adding an offset value 50 > > (I40E_FLX_OFFSET_IN_FIELD_VECTOR). This doesn't work when you use it in > > conjunction with NONUSE_FLX_PIT_DEST_OFF to disable it, because instead > of > > taking 63 as is, it does 63 + 50 and breaks the functionality. > > > > We used the following fix and it appears to work. Just sharing with the > > DPDK team in case they want to bring it in. > > > Thanks for this. Can you perhaps resubmit this fix in the form of an > official > patch to DPDK, including a proper sign-off on it. The details for > contributing > patches to DPDK is documented here: > http://dpdk.org/doc/guides/contributing/patches.html > > Without a signoff, we can't take in your code and use it. > > Regards, > /Bruce >