From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 199533253 for ; Mon, 31 Jul 2017 17:11:11 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id x64so11805831wmg.1 for ; Mon, 31 Jul 2017 08:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u0tBojyuvRsBfl0MmxXMmGAh5tkxOJ+jI8tqL7RHDq8=; b=S3i9joG/17GR7uJ3pZJvEjDUmzNCDzGgO4dnhXUwdEQT3GGdIUyoV+gmpJylsnwIba dOXdWTzZlH1hXq3RAgBPUqY1La//yuc7cpChDMTt2Fx8JhViYPLi54xxqqdnS5jUF/Ij 7uMl3E0Q1xUwW7N/eNgBWhn0iQ8Q0lLth/+RXAU17Sx7T51f1zOUT+ENqGW8PQTkkgXC eIHAwIq6oN5X7U4ChAszUWxEvvLJKQpsMgah7sVO/s6JBXTe1jYTg9kCBw/hZ8kM+3qn TWWttBH0f+h4DetcEjTILXiy5QjqtT6iaZ4MNnSBs85Q2VoowP5iufhUPQfqpjFZDEUE K4Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u0tBojyuvRsBfl0MmxXMmGAh5tkxOJ+jI8tqL7RHDq8=; b=lFbqWaS8J1B2DRVSXoJFMlO7eRPFVtfABP+qM7TeIjxabgqjXKOnYe4hmfuGHwuQ3H aNGyi4+s+nXRZme2mqsS2FnS3FOmHR1AQtbw8ionDgmj8pe9tOlRe7W1x1eqpN3tmPLv Kbvio0oIV0gb7F9jdGgDK7sy5BWc5qmo5OtqM6AWtTT+xhbV16KsiVIhScifJrnt8i1V 0x0Hnu/d4p7l9K65kX3eJrxBmSm1N2d+zeXc2RKzzPSllohlLiVyfnmIgR9OL57MkUVq MJMMDcaEbeI9Vo010RR8nNRB7Zi01wPCcPoQEmf35utzzSG8XytmPHQYeGSttL46gT0y zHKQ== X-Gm-Message-State: AIVw113jhdcdZNxSsyqtJ2SkrwOknbDylQcValbKuQnY/g4ceJa8CAI1 qmEJnpAPKgtS7TLJ9Ut8wD4/pbfH2A== X-Received: by 10.28.105.28 with SMTP id e28mr11207688wmc.42.1501513871590; Mon, 31 Jul 2017 08:11:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.208.3 with HTTP; Mon, 31 Jul 2017 08:11:11 -0700 (PDT) In-Reply-To: <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> References: <20170727204146.9574-1-asomers@gmail.com> <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> From: alan somers Date: Mon, 31 Jul 2017 09:11:11 -0600 Message-ID: To: Bruce Richardson Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 15:11:12 -0000 On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson wrote: > On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: >> From: Alan Somers >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >> >> Signed-off-by: Alan Somers >> --- >> examples/performance-thread/l3fwd-thread/test.sh | 2 +- >> usertools/dpdk-setup.sh | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh >> index b7718b622..eb1fe2dc2 100755 >> --- a/examples/performance-thread/l3fwd-thread/test.sh >> +++ b/examples/performance-thread/l3fwd-thread/test.sh >> @@ -1,4 +1,4 @@ >> -#!/bin/bash >> +#!/usr/bin/env bash >> >> case "$1" in >> > This script doesn't look to be using any bash specific features to me, > so a better fix might be to change it to use /bin/sh rather than > requiring bash itself. [Needs testing, to check there isn't something > bash-specific hidden away, obviously] True. Unfortunately, I can't test it right now because I can't get DPDK to build on either Linux or FreeBSD, and I'm out of time to debug the build failures for now. Would you like me to resubmit the patch, altered to use /bin/sh, without testing? > >> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh >> index c4fec5a63..ebf36f830 100755 >> --- a/usertools/dpdk-setup.sh >> +++ b/usertools/dpdk-setup.sh >> @@ -1,4 +1,4 @@ >> -#! /bin/bash >> +#! /usr/bin/env bash >> >> # BSD LICENSE >> # >> -- > Not sure having this linux-specific is a problem for dpdk-setup.sh, > since I don't think large parts of that script work with BSD anyway, > e.g. it assumes a linux hugetlbfs filesystem for hugepage setup. Not > that there is any harm in making the change you suggest either. Yep, that's what I figured. -Alan