From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 5EF8C325B for ; Wed, 13 Sep 2017 17:55:41 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id q132so1753911lfe.5 for ; Wed, 13 Sep 2017 08:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0XmLI28CfKVsNCrXKX95vuPSVby1rhjfJjUqzEb2uac=; b=YnQ4d8dwPpt8lsMyD5bxwtrUJ6UMbhwOH/hQBmhK6brGofeWzwGiu41JB7y8atehge YlvlJ6kJyGCOnxcZHFD+cp1/ekEUZmnJobjYTPuYTadviJqG21/JeBf4shaRgqvB4b97 7Ls8mOL5nEzz3WRT+YT+2E646Y9DcfKvAZnm3m58K4OHsxdhOTm5P08Tfn8DX9hhxYd1 j1KNgVLJILyxhkM9ZgLTNn0lm4Lsaa7GYimlREOuVnEt8YrzLqh0/4hH+gKo8oqkA0aR AWq6RhftJb6BOVIu0dAgQn3o8uA4ko2mJqeJoUHGDH9M3bymoxSZNA2DSgzQ46w/7wdS Y80Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0XmLI28CfKVsNCrXKX95vuPSVby1rhjfJjUqzEb2uac=; b=Ix1FTRCZJaD9/NORxMAAIRQ+5BWbJWjydNhl1txqOadgLdzi30M/ZuDrf5GncQcYz8 f8MNvk/mA7+GpRx8WZEIanQS98PkaEnmGZts0Z9I/Eu2PkJf42KEA1ynUi2vnPKfOz03 IzBcLw50sKOhpw+99Ipd+ooPW/F0VAnUKROI9UYlQaSm7L2NRd+ES80uPxdvFuZoRs9e tzTXsBOOANufqZ3eqA8Z7f4XhAr3QsgN2C5zNdHVIqjN8Lw/3G0AtaimdENdQ1L22coM gf13KDi7TvijMOq5RJpDq//FZ3ag+ZOUBzRpx7DD/lb21fKPva+faJTtK8N3cIpp8z7A Es6w== X-Gm-Message-State: AHPjjUjap/QcDd35zxbJOziYveQmj2P8EUGVJR5wdZMVCbEMjHcYdtfQ X969pQwb8Vy1m8xdWFqAf3e5xwf6St1bOzvu/rA= X-Google-Smtp-Source: AOwi7QB5yDDtWHMPG9Uq1bS+TkdZxQvsD7/LuGBmi6SJbGw5Pz2+kAVNaNy1vVBUCLSovMbwPDQVjmbL5RCQo9r9p7E= X-Received: by 10.46.88.22 with SMTP id m22mr4961280ljb.15.1505318140861; Wed, 13 Sep 2017 08:55:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.179.26.6 with HTTP; Wed, 13 Sep 2017 08:55:40 -0700 (PDT) In-Reply-To: <1950575.vEqoHlsAsr@xps> References: <20170727201212.9252-1-asomers@gmail.com> <2043146.lLI0On9UDY@xps> <1950575.vEqoHlsAsr@xps> From: alan somers Date: Wed, 13 Sep 2017 09:55:40 -0600 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 15:55:41 -0000 On Wed, Sep 13, 2017 at 9:39 AM, Thomas Monjalon wrote: > 13/09/2017 16:35, alan somers: >> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: >> > 27/07/2017 22:12, asomers@gmail.com: >> >> From: Alan Somers >> >> >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >> > >> > Why is it an issue? >> > >> > Can you run dpdk-setup.sh on a non-Linux system? >> >> Nope, because even dpdk-setup.sh assumes that bash is located at >> /bin/bash. But "/usr/bin/env bash" works everywhere. > > No, I mean: can you run dpdk-setup.sh on a non-Linux system after your change? > > This script configures a Linux system, so I want to understand > what situation you are trying to fix. I'm using Ceph, which imports DPDK whole (and several other 3rd party projects too). I'm not sure which parts of these 3rd party projects Ceph is actually using, but it's easier to fix the bash path everywhere than to determine which places need it to be fixed. And AFAIK it doesn't cause any problems on any modern Unix derivative. -Alan