From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4E308A0C47;
	Wed,  3 Nov 2021 21:41:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 15B1F40E0F;
	Wed,  3 Nov 2021 21:41:04 +0100 (CET)
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com
 [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id 12CDC40689
 for <dev@dpdk.org>; Wed,  3 Nov 2021 21:41:03 +0100 (CET)
Received: by mail-ed1-f52.google.com with SMTP id j21so13648164edt.11
 for <dev@dpdk.org>; Wed, 03 Nov 2021 13:41:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=4IaXHI+rqEclEigFVZhOkLMDi8t3Bh+j5x41Scd1ABs=;
 b=QokFPrlsvW3G5VNDDqtPRxNhv6uMzU7unGgFO8VGRRyUGoXFtLXFqAJY8EvAtzY6sk
 Guv8VcbdsoBzNxoRjNMd9aqRCy3nQHWPTZWCpl24JzjXkZwfc0lK1sr7YDzGyndILoI2
 A9pxr5n5B07BEsDYz1za0ZiLJ91s33GZPbagQNvJl4V8ozUlBkjvdMPQc4rK7HqKl2q2
 s0UqxpHKEW3WQZjdBHzROMYh1I5LnYPoEiJ4WaoGANJZUlTW3vnVLCI2A/HGT29rGhZ/
 iHHF8TW2sbEOG0QEjOBlQjvBwIe8a1NOgjf6qgXmHn8IO+t+oaqJXC6Qz68267MzDmhD
 EiLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4IaXHI+rqEclEigFVZhOkLMDi8t3Bh+j5x41Scd1ABs=;
 b=uBbT9yg9WBeAutp3H2BmdFiSIGg+58hYxB5o2qUKDm5fshDRTJT6/P1OhnrFMic6Es
 SIdizzxfeyM9xommyz169DxWuszNKBoaL7x7ITZvTO9zHm9E4ZDjbmdren97HdZkaBcj
 IcnGaulTOQ3OSY4ZrWM8RLizbe2DgUL1Ng1qt/JwxMEhaQcCImmMFatZkEnndnFXUiEZ
 qjikaAQhbvVrLQpfhSuldmyzxIDMvpLGrzXHGBQOb0SguY+lh3BfL/wWZDcIdx7cg5TR
 aYoJIxE8uRdQNZRqzE5e3q+8BbKKm3X3R/WUQkIzRfUvtV6pF+T7OhSTDztJ0qcsrRwf
 h+vg==
X-Gm-Message-State: AOAM5320HY590i+y9pbVkYX4qgfPH1P/QiXqOSMlTsXEgrowBxpiA18Q
 pUJZS7gPlG4WoXn5ZjQZE9bEsUKKkkrdpBK7uA1JEV/1Hgw=
X-Google-Smtp-Source: ABdhPJyFnvL4Wgq/ZhAPuNQm0Zq1WzLeGUt8ReEZHbkgGoCmawP8Etcuh6lUyTKE9KHTy7uHbqzH5Jj2B5Zk8ExDeOo=
X-Received: by 2002:a17:907:e86:: with SMTP id
 ho6mr39366728ejc.209.1635972062819; 
 Wed, 03 Nov 2021 13:41:02 -0700 (PDT)
MIME-Version: 1.0
References: <1635849481-47147-1-git-send-email-tudor.cornea@gmail.com>
 <1635868273-69843-1-git-send-email-tudor.cornea@gmail.com>
 <20211102085352.374cece8@hermes.local>
In-Reply-To: <20211102085352.374cece8@hermes.local>
From: Tudor Cornea <tudor.cornea@gmail.com>
Date: Wed, 3 Nov 2021 22:40:51 +0200
Message-ID: <CAOuQ8vUxkryO-dXF3CK6A97czTfWdMDsAC+-rXEvoQEnq_fOeg@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread
 granularity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2 Nov 2021 at 17:53, Stephen Hemminger <stephen@networkplumber.org>
wrote:

> On Tue,  2 Nov 2021 17:51:13 +0200
> Tudor Cornea <tudor.cornea@gmail.com> wrote:
>
> > +#ifdef RTE_KNI_PREEMPT_DEFAULT
> > +module_param(min_scheduling_interval, long, 0644);
> > +MODULE_PARM_DESC(min_scheduling_interval,
> > +"Kni thread min scheduling interval (default=100 microseconds):\n"
> > +"\t\t"
> > +);
>
> Why the non-standard newline's and tab's?
> Please try to make KNI look like other kernel code.
>

Hi Stephen,

I tried to base the description of the new parameters on an existing
parameter implemented for the rte_kni module - carrier.

module_param(carrier, charp, 0644);
MODULE_PARM_DESC(carrier,
"Default carrier state for KNI interface (default=off):\n"
"\t\toff   Interfaces will be created with carrier state set to off.\n"
"\t\ton    Interfaces will be created with carrier state set to on.\n"
"\t\t"
);

I thought about keeping the compatibility in terms of coding style with the
existing Kni module parameters.
Upon browsing the Linux tree, I realise it might not be standard (
checkpatch.pl , interestingly didn't seem to complain about the patch)

I also realise now, that I missed two tabs at the beginning of the params
description.
Should I add the missing tabs, so that the new parameters that I intend to
add through this patch are similar in style to the existing ones, or should
I remove the newlines and tabs altogether, when specifying the description
for min_scheduling_interval and max_scheduling_interval ?

Thanks,
Tudor