From: Tudor Cornea <tudor.cornea@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
linville@tuxdriver.com, Thomas Monjalon <thomas@monjalon.net>,
Mihai Pogonaru <pogonarumihai@gmail.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status
Date: Mon, 13 Sep 2021 20:25:07 +0300 [thread overview]
Message-ID: <CAOuQ8vVFed5c1Obq0ch3q3sMQb2h=3krnNuK+3UH+vT8u3Uqtw@mail.gmail.com> (raw)
In-Reply-To: <20210913080945.309b4c53@hermes.local>
Thanks for the observation.
I have removed the compile-time kernel version check in v2 of the patch
On Mon, 13 Sept 2021 at 18:09, Stephen Hemminger <stephen@networkplumber.org>
wrote:
> On Mon, 13 Sep 2021 17:09:11 +0300
> Tudor Cornea <tudor.cornea@gmail.com> wrote:
>
> > +static inline bool tx_ring_status_unavailable(uint32_t tp_status)
> > +{
> > +#if KERNEL_VERSION(5, 10, 0) > LINUX_VERSION_CODE
>
> No, having kernel dependent userspace in DPDK is not good practice.
>
> Distribution vendors don't number their kernels the same as upstream.
> RHEL for example, keeps same version over life or release but backports
> many fixes.
>
> Also, the system DPDK runs on is often not the system DPDK is built
> on.
>
next prev parent reply other threads:[~2021-09-13 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:09 Tudor Cornea
2021-09-13 15:09 ` Stephen Hemminger
2021-09-13 17:25 ` Tudor Cornea [this message]
2021-09-13 17:23 ` [dpdk-dev] [PATCH v2] " Tudor Cornea
2021-09-20 17:48 ` Ferruh Yigit
2021-09-21 21:02 ` Tudor Cornea
2021-09-23 18:13 ` [dpdk-dev] [PATCH v3] " Tudor Cornea
2021-09-28 13:01 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOuQ8vVFed5c1Obq0ch3q3sMQb2h=3krnNuK+3UH+vT8u3Uqtw@mail.gmail.com' \
--to=tudor.cornea@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linville@tuxdriver.com \
--cc=pogonarumihai@gmail.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).