From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B603A0C45; Mon, 13 Sep 2021 19:25:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D7B540151; Mon, 13 Sep 2021 19:25:20 +0200 (CEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mails.dpdk.org (Postfix) with ESMTP id A4DF14014F for ; Mon, 13 Sep 2021 19:25:18 +0200 (CEST) Received: by mail-ej1-f42.google.com with SMTP id i21so22724551ejd.2 for ; Mon, 13 Sep 2021 10:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0HtCsbY4O2XtEAI9VPPMDW/k+Mn7fpN+aIJzvciLcuQ=; b=GhvgOvKFgnY/KbjZZxvMlgLzWKApW2zUZUMJkb8lpYHNiaSlzEuvOgnbtokZJQU3H2 jyw5atIF1/HhdjkrQyxOnhLlhdPuOb+aMmSIWe7slJ8Y/81oG0AVdYLnZc6vpWKKmckJ 11MZ+pjBsgPwq8jdtd+te/GioxIy9XlZlDZHDq+DolmfaKgYDhZvYjuNRqylHrHznCtW wMSBLzYf3ElG7W0jg674ZpzT6UkWffc19xy/9/zCvp0wD3GzAkgRy451W+kP7REiQqFo WB0IIdb8+ahmW7vhi1fKKC+deWlQ7E27G4p+vvy+mZIp2r6C+34xG+VkIiRUgCr2/Tgu Kv4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0HtCsbY4O2XtEAI9VPPMDW/k+Mn7fpN+aIJzvciLcuQ=; b=NinAILBIWVDhnMV8vOfi1zT0MgflG8D96S59rq1s6ZLwtQnHZbO0pRFrf8hkskBky+ cwjI1ji3lRNBDLuNO3Knn/ad4udNAnlBVu+vA45DBKOmVGh6fJQlWEOdng+iyVj4Vmv6 1f+DtyZTeP0RJMM52/12yZYP6s/RRSdBFSsCRm+SdEcpWuZsBdv7sdn+ZUxG4kzTOpN2 /g3mX+ZIiyaGa4qPGNlKTvAJ+i903rL5t10sH3NnHbqVU7EiCflHi+xxcJPxlqZKMmPH BaH6hHmiTmfufPCcI8kc8u2xXafLCTjzp+i4bhfoUIoYJ8MCSilaZFcjyQrqNdw3kPeR aa+Q== X-Gm-Message-State: AOAM532jnAP12nWelD72CXJEwJ7B/Qyb/+2octOw/PEjuc75IqvgiOhn EBj8oG0l4kjvAX8oViG17JRhbQOr09He+utyZwQ= X-Google-Smtp-Source: ABdhPJzUECuxVbpsqrSQuzRtSci/n1+TfEJ1aAdAcDFh9sqxSislEkzjG01l4ggN+1hmA8SQlIZotSxNh+C5cf6XCGQ= X-Received: by 2002:a17:906:c56:: with SMTP id t22mr14052594ejf.153.1631553918317; Mon, 13 Sep 2021 10:25:18 -0700 (PDT) MIME-Version: 1.0 References: <1631542151-62895-1-git-send-email-tudor.cornea@gmail.com> <20210913080945.309b4c53@hermes.local> In-Reply-To: <20210913080945.309b4c53@hermes.local> From: Tudor Cornea Date: Mon, 13 Sep 2021 20:25:07 +0300 Message-ID: To: Stephen Hemminger Cc: Ferruh Yigit , linville@tuxdriver.com, Thomas Monjalon , Mihai Pogonaru , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for the observation. I have removed the compile-time kernel version check in v2 of the patch On Mon, 13 Sept 2021 at 18:09, Stephen Hemminger wrote: > On Mon, 13 Sep 2021 17:09:11 +0300 > Tudor Cornea wrote: > > > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > > +{ > > +#if KERNEL_VERSION(5, 10, 0) > LINUX_VERSION_CODE > > No, having kernel dependent userspace in DPDK is not good practice. > > Distribution vendors don't number their kernels the same as upstream. > RHEL for example, keeps same version over life or release but backports > many fixes. > > Also, the system DPDK runs on is often not the system DPDK is built > on. >