From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49862A0C45; Tue, 21 Sep 2021 22:59:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C211C4003F; Tue, 21 Sep 2021 22:59:26 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mails.dpdk.org (Postfix) with ESMTP id 485404003C for ; Tue, 21 Sep 2021 22:59:26 +0200 (CEST) Received: by mail-ed1-f42.google.com with SMTP id c22so1229621edn.12 for ; Tue, 21 Sep 2021 13:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4LE+/ExQnYuteLBFmOOEf2x5COhXbL9DT11KfO0OOoc=; b=CnqhChefAIAiDpBBm5Hinmq2ojn21ellLKxmEDaAQiRWdmyPvnKINg1mCvpBbPQGxk QdxevNvLP4RYFeurDjfnUsUdheygcuWbiWzNkD1P9OOar/f6U8Zyn7/BFH8YUiBOyBPe ZVMQCBoTQrVmPMvT0xrJVubNpE40yPwdpBupkNrny5Lp01zGacVplfQlLNlFvpNqlKW2 ialKmte+ttj2OB5yzEFjDZ7Jw3WKhc8upxM/IKVUnjIwrdMLn7FZVNJpkQb5wcQnG3lQ LBEdtc3zvZ9r0zB4yoZ7Dmv0Bp6lG1bufyUBXxTMyQJ0et3xDjI08af3/y70dkLlBAKc 8mrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4LE+/ExQnYuteLBFmOOEf2x5COhXbL9DT11KfO0OOoc=; b=X4vuBCKS8mQDl7CUqaPiKfsKSCPSH2sVGyowMHJBgmfdlVb787KbKPH/NmAVyA0H34 p6Oi5P504VYe0S+uzkuJcar7axpYxbBbbAzsZtxJ6YDi9vxK0c4El4yN2pBMfvgTYlDO q+KwF0YV/6tD8FsB5SDXT+gfliOvzH73UkmvwZdFFWo1kTXURlwIAR3E8AAnQ/8DlR42 ayWZ+l0l1bzPOSc2rPEQemdDgp33JNF6rtPFe96jyjSVRSKsLWo7RC5woNufIkXj4r5T jAVVlKHXXgkOlL3PaE2UPtUNEkqdKPBktZ9f7kSHgqSNSHMrZzWCeCSX+kiDSQRbbCX8 59ug== X-Gm-Message-State: AOAM530Qa1DBT5OmII5SA1hOmDD60+SU7h7rOXos5VL8R0WTHf93TbY2 +UpAPnRnxw1i/2x5IwRgei2me0MukXnaz9oy2lM= X-Google-Smtp-Source: ABdhPJw0o/XgTMEK8qhRlus013YWuBuOtDB4HBbKkSYo1mhi+3+uU+uSLlmw2hOVIkqcAQiKc74kDDNqxmrRT2KTsZY= X-Received: by 2002:aa7:c5d5:: with SMTP id h21mr38094871eds.233.1632257965967; Tue, 21 Sep 2021 13:59:25 -0700 (PDT) MIME-Version: 1.0 References: <1629463607-76292-1-git-send-email-tudor.cornea@gmail.com> <1631091558-63337-1-git-send-email-tudor.cornea@gmail.com> In-Reply-To: From: Tudor Cornea Date: Tue, 21 Sep 2021 23:59:15 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, linville@tuxdriver.com, Stephen Hemminger , Andrew Rybchenko , Thomas Monjalon , jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2] net/af_packet: reinsert the stripped vlan tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, Ferruh I will perform the suggested recommendations in version 3 of the patch. On Mon, 20 Sept 2021 at 18:41, Ferruh Yigit wrote: > On 9/8/2021 9:59 AM, Tudor Cornea wrote: > > The af_packet pmd driver binds to a raw socket and allows > > sending and receiving of packets through the kernel. > > > > Since commit [1], the kernel strips the vlan tags early in > > __netif_receive_skb_core(), so we receive untagged packets while > > running with the af_packet pmd. > > > > Luckily for us, the skb vlan-related fields are still populated from the > > stripped vlan tags, so we end up having all the information > > that we need in the mbuf. > > > > Having the PMD driver support DEV_RX_OFFLOAD_VLAN_STRIP allows the > > application to control the desired vlan stripping behavior. > > > > [1] > https://github.com/torvalds/linux/commit/bcc6d47903612c3861201cc3a866fb604f26b8b2 > > > > Signed-off-by: Tudor Cornea > > > > Hi Tudor, > > The concern was unexpected performance degradation (user not setting any > offload > will have performance drop). But since your measurements show no > significant > drop, I think it is fair to make driver behave same as other drivers. > (Until we have a way to describe offloads that can't be disabled by PMDs.) > > Can you do a few minor updates: > - Put your performance measurements into to the commit log to record them > - Update the af_packet documentation (doc/guides/nics/af_packet.rst) to > document > PMD behavior with packets with VLAN tag > - Update release note (doc/guides/rel_notes/release_21_11.rst) with a > one/two > sentences to document the change, to notify possible users of the > af_packet with > the change. > > Thanks, > ferruh > > > --- > > v2: > > * Add DEV_RX_OFFLOAD_VLAN_STRIP to rxmode->offloads > > --- > > drivers/net/af_packet/rte_eth_af_packet.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c > b/drivers/net/af_packet/rte_eth_af_packet.c > > index b73b211..5ed9dd6 100644 > > --- a/drivers/net/af_packet/rte_eth_af_packet.c > > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > > @@ -48,6 +48,7 @@ struct pkt_rx_queue { > > > > struct rte_mempool *mb_pool; > > uint16_t in_port; > > + uint8_t vlan_strip; > > > > volatile unsigned long rx_pkts; > > volatile unsigned long rx_bytes; > > @@ -78,6 +79,7 @@ struct pmd_internals { > > > > struct pkt_rx_queue *rx_queue; > > struct pkt_tx_queue *tx_queue; > > + uint8_t vlan_strip; > > }; > > > > static const char *valid_arguments[] = { > > @@ -148,6 +150,9 @@ eth_af_packet_rx(void *queue, struct rte_mbuf > **bufs, uint16_t nb_pkts) > > if (ppd->tp_status & TP_STATUS_VLAN_VALID) { > > mbuf->vlan_tci = ppd->tp_vlan_tci; > > mbuf->ol_flags |= (PKT_RX_VLAN | > PKT_RX_VLAN_STRIPPED); > > + > > + if (!pkt_q->vlan_strip && rte_vlan_insert(&mbuf)) > > + PMD_LOG(ERR, "Failed to reinsert VLAN > tag"); > > } > > > > /* release incoming frame and advance ring buffer */ > > @@ -302,6 +307,11 @@ eth_dev_stop(struct rte_eth_dev *dev) > > static int > > eth_dev_configure(struct rte_eth_dev *dev __rte_unused) > > { > > + struct rte_eth_conf *dev_conf = &dev->data->dev_conf; > > + const struct rte_eth_rxmode *rxmode = &dev_conf->rxmode; > > + struct pmd_internals *internals = dev->data->dev_private; > > + > > + internals->vlan_strip = !!(rxmode->offloads & > DEV_RX_OFFLOAD_VLAN_STRIP); > > return 0; > > } > > > > @@ -318,6 +328,7 @@ eth_dev_info(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > > dev_info->min_rx_bufsize = 0; > > dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS | > > DEV_TX_OFFLOAD_VLAN_INSERT; > > + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP; > > > > return 0; > > } > > @@ -448,6 +459,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, > > > > dev->data->rx_queues[rx_queue_id] = pkt_q; > > pkt_q->in_port = dev->data->port_id; > > + pkt_q->vlan_strip = internals->vlan_strip; > > > > return 0; > > } > > > >