From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CC8DA0524; Thu, 2 Jul 2020 10:06:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCF341D6E8; Thu, 2 Jul 2020 10:06:18 +0200 (CEST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by dpdk.org (Postfix) with ESMTP id 96E011D6B3 for ; Thu, 2 Jul 2020 10:06:17 +0200 (CEST) Received: by mail-lj1-f170.google.com with SMTP id n23so30683935ljh.7 for ; Thu, 02 Jul 2020 01:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=elo9VlXdSj1e/23vZzRBBqDs4U3IFgXy9PILydjsTLA=; b=lRH13i/dPN7DyLqzLWUgvJKNcaW3LfNflsXSjturR965L2ZjpYoySwQhWVUj7jTsax ebx7FRdkbnoAiZNjX3/DVGbX2IX0tFG4OhMVEaO7xQSEe3BQko64IVz0VJNBnZaf4cj0 dX6jvBcXzJGMyqlwhMOUVZWc1N+j3Dymtaobm0s9eAhVQ3y8PlMjNZ/UA74L4YJfS/nK ES8y9EH7/E2FvbhTPWTrp9I18XtbkrWf/ya4UaiIs6kNW2v6CY/z5iFOSGzXq+OkCWFR lCamyw3Jv+SEbQqUNf/CvW/Ctzkjn9MG4SC+V0a6NPB5GF657QABj9YnboGU6x9M+JsG yFNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=elo9VlXdSj1e/23vZzRBBqDs4U3IFgXy9PILydjsTLA=; b=NXI/To3vw8jvNnH2U2UWJocw0e4J4rOVqMm+7pG9MQJ+YZRTjDLbdwOLfBejGjjmCA e4O4SE1ZJy3kKe4Ics+f+L6mYVBhUznO/yhRsnIRjAbL7Kbl5EwpD08eqorg0ckJM8qX fNM7qiGJm/B0o6NhAHajcGLcaMDgQydmIuelq02lUOXhoVyp6jvrfcWv+7J0m9GGbErN YM3dcxeo5jS8zPG1BVAejmQ+8eGNWH3fYNVnR5gFS8vL6T8POcDTcCA+Jqf+D7rg9GT2 3wksahpzrQ9OHpjKWNIYhJ2QH59va2J7y2U6a06h7f/ZP1nRShI2XDOoKjA5R8JqiktP xmyQ== X-Gm-Message-State: AOAM532TwkHltkIXm2vHk8nnMypEh1GK6D/+Lt4Bv6XV6BoX0Y97rj9k +4JzGiiolvC402qDMIPq1dzVfCIfMpdwG4Emwss= X-Google-Smtp-Source: ABdhPJxyXysCTF0qNQ+if6IKbDIhHfrxdxMXp64JxcRAnRNSoTE6VEFXOQjDrGHOp6nqBWdvThQPcDzY25Ivo+2/dac= X-Received: by 2002:a2e:81c4:: with SMTP id s4mr12573758ljg.284.1593677177194; Thu, 02 Jul 2020 01:06:17 -0700 (PDT) MIME-Version: 1.0 References: <20200620133257.12441-1-andrey.vesnovaty@gmail.com> <20200701172409.6b82bd6e@hermes.lan> In-Reply-To: From: Andrey Vesnovaty Date: Thu, 2 Jul 2020 11:06:06 +0300 Message-ID: To: Ori Kam Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Andrey Vesnovaty Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 2, 2020 at 10:20 AM Ori Kam wrote: > Hi Stephen, > > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Thursday, July 2, 2020 3:24 AM > > To: Andrey Vesnovaty > > Cc: Thomas Monjalon ; Ferruh Yigit > > ; Andrew Rybchenko ; > > Ori Kam ; dev@dpdk.org; Andrey Vesnovaty > > > > Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API > > > > On Sat, 20 Jun 2020 16:32:57 +0300 > > Andrey Vesnovaty wrote: > > > > > + > > > +void * > > > +rte_flow_shared_action_create(uint16_t port_id, > > > + const struct rte_flow_action *action, > > > + struct rte_flow_error *error) > > > +{ > > > > NAK > > > > API's that return void * (opaque pointer) are dangerous and should > > not be added to DPDK. > > > > To do data hiding. Define a structure but don't expose the internals > > of what that structure are. > > I'll add `struct rte_flow_shared_action` to upcoming patches. Thanks. > I agree with you it is better not to use void * > So I suggest to use new struct rte_action_ctx or something like this. That > will be implemented differently for each driver just like rte_flow. > What do you think? > > Best, > Ori > >