From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97116A0350; Mon, 22 Jun 2020 19:09:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4803F1D904; Mon, 22 Jun 2020 19:09:39 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by dpdk.org (Postfix) with ESMTP id 0BF951D901 for ; Mon, 22 Jun 2020 19:09:38 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id i27so20161076ljb.12 for ; Mon, 22 Jun 2020 10:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MlKu+rjNs09y4zCZ5DW4STHbqkyftkA70uIAZzCUSMc=; b=EEl7m0GpxDYym2cRuJ5FIArGrCdiFJsEh/GDVLNbl+fjQhz+B1BMCz78b32ZF3VD4z m22qm/GXACms+4D1q/of2dEORk7QXWwJD0clPO2fwalCemzC954AZaiq5LYiHzC3f5++ aIQQPI06wxKn4AqT6Xnw1LHwacEiYnYcCCUSwne8otax984coZ5TdbnXfh/u6Bnb5x1v rK3BIcg3KcOmceg4Chqz3dFrs6SXFFDuoCvzhfF1sPEjPvgBFVpsvuRo7q1UyCquIByJ /QYhyFYQvBz+6uXiSTTmTWwbwpYSZ7Ji5PG2dktgWLHvH9H9b7TjLJoP4dZBUIEOe8hw ARLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MlKu+rjNs09y4zCZ5DW4STHbqkyftkA70uIAZzCUSMc=; b=pGiagUAbYXxVy68onIdNVoFovtL5SS5BOzxxa5sRRrJM1w2q/CJdei8DnmpKvltzqW CMWYP7ZQ0orvUSgjm/UUPdvy3Un0j8MNwgZ2QDc06E//4zBt+z9RfeUIA3Z7LVJOWI0d WeDXVhDcClWBMSgtH4NYDPMRrFqy/OZADp5zUMFaKt2iB3ABpQko0JIP4Tdr/z8y1uiD YujHSPA4mSAlbOI4qEOKa6AjEsIjAB2fZT8uMZiqqFG+7MSdmDbh9QlUmr5R7s5cb7bd 8nDsKvMYazTWL+x4aOJCyaOReVOKcvdjflg6P0LlqNlrxYgGqP4TpMuN93UvNc2apzvj OGKg== X-Gm-Message-State: AOAM532sH4C2nG+K2Fxeqy3NLm8xzzz9Zbf0ElctU9PhjRuhUSXUPR7V zfQAjhhtEo2fV/goPze3ZsYFMITmfaQ5fcTgMfc= X-Google-Smtp-Source: ABdhPJwOOV/Bz/TwzJfbzBrPqCLd0S61WbaoDo5Ne7oOtldUj9WTL+8Chup6LSy09VrNUGuqnQFEoKn1TYUN+IqhEXo= X-Received: by 2002:a2e:7016:: with SMTP id l22mr9602057ljc.284.1592845777563; Mon, 22 Jun 2020 10:09:37 -0700 (PDT) MIME-Version: 1.0 References: <20200620133231.12355-1-andrey.vesnovaty@gmail.com> <8953907.gaXCrnZTga@thomas> In-Reply-To: <8953907.gaXCrnZTga@thomas> From: Andrey Vesnovaty Date: Mon, 22 Jun 2020 20:09:27 +0300 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC v2 0/1] add flow action context API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 22, 2020 at 6:22 PM Thomas Monjalon wrote: > 20/06/2020 15:32, Andrey Vesnovaty: > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term 'action context' was unclear and replaced with > > 'shared action'. > > * RFC v2 subject became 'add flow shared action API'. > > * all proposed APIs renamed according the above. > > > > The new shared action is an independent entity decoupled from any flow > > while any flow can reuse such an action. Please go over the RFC > > description, it was almost entirely rewritten. > > > > @Jerin Jacob: > > Thanks again for your comments, it made me admit that v1 description was > > incomplete & unclear. I hope v2 will be better at least in terms of > > clarity. > > @Thomas Monjalon: > > rte_flow_action_ctx_modify() -> rte_flow_action_ctx_modify() > > I guess it is a typo. > I see the name "rte_flow_shared_action_update" in the patch > > Right, a typo. Should be: rte_flow_action_ctx_modify() -> rte_flow_shared_action_update ()