From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f49.google.com (mail-it0-f49.google.com [209.85.214.49]) by dpdk.org (Postfix) with ESMTP id 643115588 for ; Fri, 22 Jul 2016 19:21:18 +0200 (CEST) Received: by mail-it0-f49.google.com with SMTP id j124so53186832ith.1 for ; Fri, 22 Jul 2016 10:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UooU2XbF2eEsufRWs5Sfp6DccMtHjfopWc6ohVGzyEc=; b=SvKhKk/9Kfq0b1pd0DHRM7Nit9PVe0KKROXZaMC6cvfeVekWMmBaagInEvHPCPih2P KIlR/5ynaI9H+VllhGnYZPI+CD6D2Dbifc0SZ6aDuiTHYupLgyEmWfvS9c6NCH0y3i4t jCJ9d/MYlH2kqgNm2F3E0peI364LGu61qOdIYq+wdBQELtPIEFi4ckuJz1lY3m6U9uNZ wu7XWhWGxGLE0DAN61CUSWfvsrOaqRKbt5YfOE4IZerSInwip9KEHFGsYGdkKw7ROx2c vq6KDDl16HsnLSJRXD6w+7w5W5bfxphNV/h9NhjofVGhfrnGIrxoFBhR+D2JpG7CGUQW Oc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UooU2XbF2eEsufRWs5Sfp6DccMtHjfopWc6ohVGzyEc=; b=POgnLRbkzHiPHVITPIkESRCFPAswBXsihMgcfKWuGQ1cwaM1cfASJbRGaoSwbY3zE0 hveTT5CHVRvom3CkrZPd9H+vZhxQMEIc0iqT0aHFUY2BAnfj2GgEFWfaXhcCQJEWzu9O qfnrhntx8WUz1Fyv4ap6AI31XrFVQ/AhJ4VxU/0tzeEa9BFeoHtg/1BAnfypUaTEKk0s hXDa21hLGuAnkri8KshNzb6++7VGAUCPeF+UcPGHYM8qDWHh0FDDapdwSr7EJVq1atW6 yhBbHjPHOHEF7pgLvn3q/TCP2M8CXeC968tKoiFAsSglJ1n2e65nySHaJL6/icA4NORB DRYA== X-Gm-Message-State: AEkooutUcnRF3x3P0hTIZBagUwrczhJi3vR/eeufgUjj1OjymgCwBAjBWeH5PKL1ScvnPIqCrWv0ZrhbeSyDtw== X-Received: by 10.36.127.7 with SMTP id r7mr5528118itc.49.1469208077793; Fri, 22 Jul 2016 10:21:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.38.142 with HTTP; Fri, 22 Jul 2016 10:20:58 -0700 (PDT) In-Reply-To: References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> <7298712.p7zDOZdSxl@xps13> From: Andriy Berestovskyy Date: Fri, 22 Jul 2016 19:20:58 +0200 Message-ID: To: Jay Rolette Cc: Thomas Monjalon , Ferruh Yigit , DPDK Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 17:21:18 -0000 Hi folks, Just to clarify. Thomas is talking about removing just the KNI ethtool (i.e. lib/librte_eal/linuxapp/kni/ethtool/*). The major functionality of those 45K lines of code is to get the same MAC address on the KNI interface and the underlying igb/ixgbe NIC. At the moment the rest of the DPDK eth devices work fine without the KNI ethtool. The workaround is very simple: use ifconfig or ip tool to set the same MAC you have on your NIC. Put it into your network configuration to make it permanent. Examples: ifconfig vEth0_0 hw ether or ip link set vEth0_0 address or in /etc/network/interfaces under the "iface vEth0_0" section add the following: hwaddress Andriy On Thu, Jul 21, 2016 at 10:54 PM, Jay Rolette wrote: > On Thu, Jul 21, 2016 at 3:32 PM, Thomas Monjalon > wrote: > >> 2016-07-21 13:20, Jay Rolette: >> > On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit >> > wrote: >> > > KNI ethtool is functional and maintained, and it may have users! >> > > >> > > Why just removing it, specially without providing an alternative? >> > > Is is good time to discuss KCP again? >> > >> > Yes, my product uses it. >> >> Your product uses what? KCP? KNI? KNI ethtool? >> > > Sorry, that wasn't very clear. It uses KNI + ifconfig to configure the > device/interface in Linux. I'm assuming the "ethtool" bits under discussion > are the same things that make ifconfig work with KNI to the limited extent > it does. > >> Seems like we are back to the same discussion we >> > had a few months ago about the KNI situation... >> > >> > It shouldn't be removed unless there is a replacement, ideally one that >> > works with the normal Linux tools like every other network device. >> >> This ethtool module works only for igb and ixgbe! >> There is already no replacement for other drivers. >> Who works on a replacement? >> > > Ferruh submitted KCP previously, but you guys didn't like the fact that it > was a kernel module. IIRC, one of the gains from that was simplified > maintenance because you didn't need driver specific support for KNI. > Assuming he's still willing to beat it into shape, we have something that > is already most of the way there. > > If people are going to continue to block it because it is a kernel module, > then IMO, it's better to leave the existing support on igx / ixgbe in place > instead of stepping backwards to zero support for ethtool. > >> While the code wasn't ready at the time, it was a definite improvement >> over what >> > we have with KNI today. >> -- Andriy Berestovskyy